From: David Miller <davem@davemloft.net>
To: willemdebruijn.kernel@gmail.com
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org, willemb@google.com,
mst@redhat.com
Subject: Re: [PATCH net-next] virtio-net: on tx, only call napi_disable if tx napi is on
Date: Wed, 26 Apr 2017 14:50:23 -0400 (EDT) [thread overview]
Message-ID: <20170426.145023.520426501343191968.davem__4552.95843207768$1493232631$gmane$org@davemloft.net> (raw)
In-Reply-To: <20170425195917.54209-1-willemdebruijn.kernel@gmail.com>
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Tue, 25 Apr 2017 15:59:17 -0400
> From: Willem de Bruijn <willemb@google.com>
>
> As of tx napi, device down (`ip link set dev $dev down`) hangs unless
> tx napi is enabled. Else napi_enable is not called, so napi_disable
> will spin on test_and_set_bit NAPI_STATE_SCHED.
>
> Only call napi_disable if tx napi is enabled.
>
> Fixes: 5a719c2552ca ("virtio-net: transmit napi")
> Reported-by: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Willem de Bruijn <willemb@google.com>
Applied, thanks.
prev parent reply other threads:[~2017-04-26 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 19:59 [PATCH net-next] virtio-net: on tx, only call napi_disable if tx napi is on Willem de Bruijn
2017-04-25 20:44 ` Michael S. Tsirkin
2017-04-26 0:17 ` Jason Wang
2017-04-26 18:50 ` David Miller
2017-04-26 18:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20170426.145023.520426501343191968.davem__4552.95843207768$1493232631$gmane$org@davemloft.net' \
--to=davem@davemloft.net \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.