Re: [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing

[Simon Horman <horms@verge.net.au>]

On Tue, Apr 25, 2017 at 07:36:25PM +0200, Geert Uytterhoeven wrote:
> If the R-Car RST driver is not included, compile-testing R-Car clock
> drivers fails with a link error:
> 
>     undefined reference to `rcar_rst_read_mode_pins'
> 
> To fix this, provide a dummy version.  Use the exact same test logic as
> in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to
> control compilation of the R-Car RST driver.

Adding a Kconfig symbol would be a bit cleaner IMHO.

> 
> Fixes: 527c02f66d263d2e ("soc: renesas: Add R-Car RST driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This isn't an issue now, but it does prevent enabling compile-testing of
> the R-Car clock drivers.  As this is a dependency between two different
> subsystems, I think this patch should be fast-tracked.
> 
> The #ifdef condition will be revised later, when the R-Car RST driver
> gains its own Kconfig symbol.
> ---
>  include/linux/soc/renesas/rcar-rst.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/linux/soc/renesas/rcar-rst.h b/include/linux/soc/renesas/rcar-rst.h
> index a18e0783946b66ec..787e7ad53d45f61c 100644
> --- a/include/linux/soc/renesas/rcar-rst.h
> +++ b/include/linux/soc/renesas/rcar-rst.h
> @@ -1,6 +1,11 @@
>  #ifndef __LINUX_SOC_RENESAS_RCAR_RST_H__
>  #define __LINUX_SOC_RENESAS_RCAR_RST_H__
>  
> +#if defined(CONFIG_ARCH_RCAR_GEN1) || defined(CONFIG_ARCH_RCAR_GEN2) || \
> +    defined(CONFIG_ARCH_R8A7795) || defined(CONFIG_ARCH_R8A7796)
>  int rcar_rst_read_mode_pins(u32 *mode);
> +#else
> +static inline int rcar_rst_read_mode_pins(u32 *mode) { return -ENODEV; }
> +#endif
>  
>  #endif /* __LINUX_SOC_RENESAS_RCAR_RST_H__ */
> -- 
> 2.7.4
>