All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, armbru@redhat.com,
	eblake@redhat.com, jsnow@redhat.com, famz@redhat.com,
	den@openvz.org, stefanha@redhat.com, vsementsov@virtuozzo.com,
	pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH 11/24] block: bdrv_close: release bitmaps after drv->bdrv_close
Date: Wed, 26 Apr 2017 14:30:25 +0300	[thread overview]
Message-ID: <20170426113038.60044-12-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20170426113038.60044-1-vsementsov@virtuozzo.com>

Release bitmaps after 'if (bs->drv) { ... }' block. This will allow
format driver to save persistent bitmaps, which will appear in following
commits.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 block.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/block.c b/block.c
index a0346c80c6..16cf522219 100644
--- a/block.c
+++ b/block.c
@@ -2322,9 +2322,6 @@ static void bdrv_close(BlockDriverState *bs)
     bdrv_flush(bs);
     bdrv_drain(bs); /* in case flush left pending I/O */
 
-    bdrv_release_named_dirty_bitmaps(bs);
-    assert(QLIST_EMPTY(&bs->dirty_bitmaps));
-
     if (bs->drv) {
         BdrvChild *child, *next;
 
@@ -2363,6 +2360,9 @@ static void bdrv_close(BlockDriverState *bs)
         bs->full_open_options = NULL;
     }
 
+    bdrv_release_named_dirty_bitmaps(bs);
+    assert(QLIST_EMPTY(&bs->dirty_bitmaps));
+
     QLIST_FOREACH_SAFE(ban, &bs->aio_notifiers, list, ban_next) {
         g_free(ban);
     }
-- 
2.11.1

  parent reply	other threads:[~2017-04-26 11:30 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26 11:30 [Qemu-devel] [PATCH v17 00/24] qcow2: persistent dirty bitmaps Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 01/24] specs/qcow2: fix bitmap granularity qemu-specific note Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 02/24] specs/qcow2: do not use wording 'bitmap header' Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 03/24] hbitmap: improve dirty iter Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 04/24] tests: add hbitmap iter test Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 05/24] block: fix bdrv_dirty_bitmap_granularity signature Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 06/24] block/dirty-bitmap: add deserialize_ones func Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 07/24] qcow2-refcount: rename inc_refcounts() and make it public Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 08/24] qcow2: add bitmaps extension Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 09/24] qcow2: autoloading dirty bitmaps Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 10/24] block/dirty-bitmap: add autoload field to BdrvDirtyBitmap Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` Vladimir Sementsov-Ogievskiy [this message]
2017-04-26 11:30 ` [Qemu-devel] [PATCH 12/24] block: introduce persistent dirty bitmaps Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 13/24] block/dirty-bitmap: add bdrv_dirty_bitmap_next() Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 14/24] qcow2: add persistent dirty bitmaps support Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 15/24] block: add bdrv_can_store_new_dirty_bitmap Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 16/24] qcow2: add .bdrv_can_store_new_dirty_bitmap Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 17/24] qmp: add persistent flag to block-dirty-bitmap-add Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 18/24] qmp: add autoload parameter " Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 19/24] qmp: add x-debug-block-dirty-bitmap-sha256 Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 20/24] iotests: test qcow2 persistent dirty bitmap Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 21/24] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 22/24] qcow2: add .bdrv_remove_persistent_dirty_bitmap Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 23/24] qmp: block-dirty-bitmap-remove: remove persistent Vladimir Sementsov-Ogievskiy
2017-04-26 11:30 ` [Qemu-devel] [PATCH 24/24] block: release persistent bitmaps on inactivate Vladimir Sementsov-Ogievskiy
2017-04-27 16:43 ` [Qemu-devel] [PATCH v17 00/24] qcow2: persistent dirty bitmaps John Snow
2017-04-28 11:22   ` Vladimir Sementsov-Ogievskiy
2017-04-28 16:51   ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170426113038.60044-12-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.