From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S3000990AbdDZOJT (ORCPT ); Wed, 26 Apr 2017 10:09:19 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:42885 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1040279AbdDZOJL (ORCPT ); Wed, 26 Apr 2017 10:09:11 -0400 Date: Wed, 26 Apr 2017 17:08:56 +0300 From: Dan Carpenter To: Chandra Annamaneni Cc: christian.gromm@microchip.com, andrey.shvetsov@k2l.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] Staging: most: use __func__ instead of the function name Message-ID: <20170426140856.6ncu47o7klwxllj5@mwanda> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 26, 2017 at 06:02:29AM -0700, Chandra Annamaneni wrote: > > Change video.c to use %s, __func__ instead of function names. > Warnings flagged by checkpatch.pl > > Signed-off-by: Chandra Annamaneni > > diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c > index 59e861e..e074841 100644 > --- a/drivers/staging/most/aim-v4l2/video.c > +++ b/drivers/staging/most/aim-v4l2/video.c > @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp) > struct most_video_dev *mdev = video_drvdata(filp); > struct aim_fh *fh; > > - v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__); > + v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n"); You sent the reversed patch. regards, dan carpenter