From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v8 2/3] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch Date: Wed, 26 Apr 2017 16:58:32 +0200 Message-ID: <20170426145832.GK1867@nanopsycho.orion> References: <20170426110241.GA28251@vergenet.net> <2e09d117-60f9-97ed-9f63-c94130ddbb0c@mojatatu.com> <20170426130506.GF1867@nanopsycho.orion> <20170426.104658.547156121898948265.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: jhs@mojatatu.com, simon.horman@netronome.com, xiyou.wangcong@gmail.com, eric.dumazet@gmail.com, netdev@vger.kernel.org To: David Miller Return-path: Received: from mail-wr0-f193.google.com ([209.85.128.193]:36639 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1434758AbdDZPGC (ORCPT ); Wed, 26 Apr 2017 11:06:02 -0400 Received: by mail-wr0-f193.google.com with SMTP id v42so408075wrc.3 for ; Wed, 26 Apr 2017 08:06:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170426.104658.547156121898948265.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Apr 26, 2017 at 04:46:58PM CEST, davem@davemloft.net wrote: >From: Jiri Pirko >Date: Wed, 26 Apr 2017 15:05:06 +0200 > >> Wed, Apr 26, 2017 at 02:46:22PM CEST, jhs@mojatatu.com wrote: >>>On 17-04-26 07:02 AM, Simon Horman wrote: >>>> On Tue, Apr 25, 2017 at 06:04:45PM +0200, Jiri Pirko wrote: >>>[..] >>> >>>> > So fix iproute2. It is always first kernel, then iproute2. >>>> >>>> Perhaps I am missing the point or somehow misguided but I would expect that >>>> if the UAPI uses BIT() it also provides BIT(). >>> >>>There is a user of BIT() already in iproute2 (devlink). We can move >>>the code to be more generally available for other iproute2 users. >>>Then this UAPI change makes use of it. >> >> Should be part of UAPI as well >> I see that include/uapi/rdma/vmw_pvrdma-abi.h is using BIT macro. >> I don't see BIT macro defined in UAPI (I thought it is). So either >> define it there (not sure where) or just use "<<" > >"BIT" is a pretty crazy small simple name to pollute into the global >namespace, IMHO. Btw, this is also something resolvable nicely if we have NLA_FLAGS netlink attribute type. We can have some helper in UAPI like: #define TCA_FLAG_LARGE_DUMP_ON NLA_FLAGS_F(0)