All of lore.kernel.org
 help / color / mirror / Atom feed
From: mrugiero at gmail.com <mrugiero@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/protobuf: depend on gcc >= 4.5
Date: Wed, 26 Apr 2017 13:28:50 -0300	[thread overview]
Message-ID: <20170426162850.5214-1-mrugiero@gmail.com> (raw)

From: "Mario J. Rugiero" <mrugiero@gmail.com>

Protobuf hits a bug in gcc < 4.5 which breaks the build.
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=189

Signed-off-by: Mario J. Rugiero <mrugiero@gmail.com>
---
 package/protobuf/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/protobuf/Config.in b/package/protobuf/Config.in
index 03d118cfc..e3c94dcd6 100644
--- a/package/protobuf/Config.in
+++ b/package/protobuf/Config.in
@@ -22,6 +22,7 @@ config BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS
 	default y if BR2_x86_64
 	default y if BR2_sparc64
 	default y if BR2_TOOLCHAIN_HAS_ATOMIC
+	depends on BR2_HOST_GCC_AT_LEAST_4_5
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	depends on BR2_USE_MMU # fork()
 
@@ -30,6 +31,7 @@ config BR2_PACKAGE_PROTOBUF
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_5
 	depends on !BR2_STATIC_LIBS
 	help
 	  Protocol buffers are Google's language-neutral, platform-neutral,
@@ -37,7 +39,7 @@ config BR2_PACKAGE_PROTOBUF
 
 	  https://developers.google.com/protocol-buffers
 
-comment "protobuf needs a toolchain w/ C++, threads, dynamic library"
+comment "protobuf needs a toolchain w/ C++, threads, dynamic library, gcc >= 4.5"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS \
-		|| BR2_STATIC_LIBS
+		|| BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_5
 	depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS
-- 
2.12.2

             reply	other threads:[~2017-04-26 16:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26 16:28 mrugiero at gmail.com [this message]
2017-04-29 12:31 ` [Buildroot] [PATCH] package/protobuf: depend on gcc >= 4.5 Thomas Petazzoni
2017-04-29 14:54   ` Mario Rugiero
2017-04-29 20:02     ` Mario Rugiero
2017-04-30  7:29       ` Thomas Petazzoni
2017-05-01  4:57         ` Mario Rugiero
2017-05-02  1:43           ` Matthew Weber
2017-05-02 12:03             ` Thomas Petazzoni
2017-05-02 15:04               ` Mario Rugiero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170426162850.5214-1-mrugiero@gmail.com \
    --to=mrugiero@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.