All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Eric Blake <eblake@redhat.com>
Cc: Zihan Yang <tgnyang@gmail.com>,
	qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 1/5] hw/char: remove console_exit function in sclp
Date: Wed, 26 Apr 2017 17:05:53 +0200	[thread overview]
Message-ID: <20170426170553.1d45e1d7.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <f2769605-4cd0-7f95-0409-850258ccbaeb@redhat.com>

On Wed, 26 Apr 2017 09:42:02 -0500
Eric Blake <eblake@redhat.com> wrote:

> On 04/26/2017 07:53 AM, Zihan Yang wrote:
> > Currently, the console_exit function in sclpconsole-lm.c and sclpconsole.c
> > does nothing, so remove them and convert the callback in SCLPEventClass to
> > void. Since there is a NULL check on the DeviceClass exit callback as
> > suggested by Frederic Konrad, it should be safe to remove them.
> 
> When sending a patch series, please be sure to include a 0/5 cover
> letter, to make it easier on automated tooling that processes the list.
> You can use 'git config format.coverletter auto' to make it easier to
> remember this for patches created by 'git format-patch'/'git send-email'.
> 
> More submission hints at: http://wiki.qemu.org/Contribute/SubmitAPatch
> 

Nod.

Of the hints in the wiki page above, I'd especially like to point out
versioning and change logs.

  reply	other threads:[~2017-04-26 15:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26 12:53 [Qemu-devel] [PATCH 1/5] hw/char: remove console_exit function in sclp Zihan Yang
2017-04-26 12:53 ` [Qemu-devel] [PATCH 2/5] hw/s390x: make virtio_ccw_exit function in virtio-ccw return void Zihan Yang
2017-04-26 12:53 ` [Qemu-devel] [PATCH 3/5] hw/s390: convert exit to unrealize in virtio_ccw_device_class_init Zihan Yang
2017-04-26 12:53 ` [Qemu-devel] [PATCH 4/5] hw/audio: replace exit with unrealize in hda_codec_device_class_init Zihan Yang
2017-04-26 12:53 ` [Qemu-devel] [PATCH 5/5] hw/audio: convert exit callback in HDACodecDeviceClass to void Zihan Yang
2017-04-26 14:42 ` [Qemu-devel] [PATCH 1/5] hw/char: remove console_exit function in sclp Eric Blake
2017-04-26 15:05   ` Cornelia Huck [this message]
2017-04-27 12:23     ` Zihan Yang
2017-04-27 14:03       ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170426170553.1d45e1d7.cornelia.huck@de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=eblake@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=tgnyang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.