From: russell@coker.com.au (Russell Coker)
To: refpolicy@oss.tresys.com
Subject: [refpolicy] [PATCH v2] locallogin: fix the sulogin submodule (emergency shell!)
Date: Thu, 27 Apr 2017 02:20:27 +1000 [thread overview]
Message-ID: <201704270220.27679.russell@coker.com.au> (raw)
In-Reply-To: <5D3FFC2A-F6BB-4056-AA55-CF89D485F79C@trentalancia.net>
On Thu, 27 Apr 2017 01:42:31 AM Guido Trentalancia via refpolicy wrote:
> >> @@ -215,7 +215,8 @@ optional_policy(`
> >>
> >> # Sulogin local policy
> >> #
> >>
> >> -allow sulogin_t self:capability dac_override;
> >> +allow sulogin_t self:capability { dac_override sys_admin
> >
> >sys_tty_config };
> >
> >I suspect that cap_sys_admin can be safely dontaudited
>
> Yes, I thought the same, but then considering it is a sysadmin shell, I did
> not even check.
>
> Also, remember we probably still have sys_admin for getty which runs
> unprivileged shells...
http://oss.tresys.com/pipermail/refpolicy/2016-March/007901.html
Above is the list discussion from last time this came up. If you can get
sulogin to operate correctly without sys_admin then the next thing to do would
be to try and get getty to do the same. As you note getty runs unprivileged
shells, but also it tends to be run from les secure devices such as serial
consoles, modems, etc that sulogin will never be run from.
I'm a little surprised at your "considering it is a sysadmin shell" argument
given that the reason you started working on sulogin policy is that you
believed that I was giving it excess permissions. Previously you didn't
accept my argument that sulogin is permitted to run "bash -c setsebool" etc.
--
My Main Blog http://etbe.coker.com.au/
My Documents Blog http://doc.coker.com.au/
next prev parent reply other threads:[~2017-04-26 16:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 19:18 [refpolicy] [PATCH] locallogin: fix the sulogin submodule (emergency shell!) Guido Trentalancia
2017-04-25 22:50 ` [refpolicy] [PATCH v2] " Guido Trentalancia
2017-04-26 10:43 ` Chris PeBenito
2017-04-26 13:05 ` Dominick Grift
2017-04-26 15:42 ` Guido Trentalancia
2017-04-26 15:44 ` Dominick Grift
2017-04-26 16:20 ` Russell Coker [this message]
2017-04-26 16:32 ` Guido Trentalancia
2017-04-26 17:23 ` Russell Coker
2017-04-26 17:58 ` Dominick Grift
2017-04-26 18:00 ` Guido Trentalancia
2017-04-26 21:04 ` Chris PeBenito
2017-04-26 21:42 ` Guido Trentalancia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201704270220.27679.russell@coker.com.au \
--to=russell@coker.com.au \
--cc=refpolicy@oss.tresys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.