From: Michal Hocko <mhocko@kernel.org> To: linux-mm@kvack.org Cc: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>, Andrea Arcangeli <aarcange@redhat.com>, Jerome Glisse <jglisse@redhat.com>, Reza Arbab <arbab@linux.vnet.ibm.com>, Yasuaki Ishimatsu <yasu.isimatu@gmail.com>, qiuxishi@huawei.com, Kani Toshimitsu <toshi.kani@hpe.com>, slaoub@gmail.com, Joonsoo Kim <js1304@gmail.com>, Andi Kleen <ak@linux.intel.com>, David Rientjes <rientjes@google.com>, Daniel Kiper <daniel.kiper@oracle.com>, Igor Mammedov <imammedo@redhat.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 08/13] mm, compaction: skip over holes in __reset_isolation_suitable Date: Thu, 27 Apr 2017 09:59:22 +0200 [thread overview] Message-ID: <20170427075922.GC4706@dhcp22.suse.cz> (raw) In-Reply-To: <20170421120512.23960-9-mhocko@kernel.org> On Fri 21-04-17 14:05:11, Michal Hocko wrote: > From: Michal Hocko <mhocko@suse.com> > > __reset_isolation_suitable walks the whole zone pfn range and it tries > to jump over holes by checking the zone for each page. It might still > stumble over offline pages, though. Skip those by checking PageReserved. ups, forgot to update the changelog here. s@PageReserved@pfn_to_online_page()@ > Signed-off-by: Michal Hocko <mhocko@suse.com> > --- > mm/compaction.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 613c59e928cb..fb548e4c7bd4 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -236,10 +236,9 @@ static void __reset_isolation_suitable(struct zone *zone) > > cond_resched(); > > - if (!pfn_valid(pfn)) > + page = pfn_to_online_page(pfn); > + if (!page) > continue; > - > - page = pfn_to_page(pfn); > if (zone != page_zone(page)) > continue; > > -- > 2.11.0 > -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: linux-mm@kvack.org Cc: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>, Andrea Arcangeli <aarcange@redhat.com>, Jerome Glisse <jglisse@redhat.com>, Reza Arbab <arbab@linux.vnet.ibm.com>, Yasuaki Ishimatsu <yasu.isimatu@gmail.com>, qiuxishi@huawei.com, Kani Toshimitsu <toshi.kani@hpe.com>, slaoub@gmail.com, Joonsoo Kim <js1304@gmail.com>, Andi Kleen <ak@linux.intel.com>, David Rientjes <rientjes@google.com>, Daniel Kiper <daniel.kiper@oracle.com>, Igor Mammedov <imammedo@redhat.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 08/13] mm, compaction: skip over holes in __reset_isolation_suitable Date: Thu, 27 Apr 2017 09:59:22 +0200 [thread overview] Message-ID: <20170427075922.GC4706@dhcp22.suse.cz> (raw) In-Reply-To: <20170421120512.23960-9-mhocko@kernel.org> On Fri 21-04-17 14:05:11, Michal Hocko wrote: > From: Michal Hocko <mhocko@suse.com> > > __reset_isolation_suitable walks the whole zone pfn range and it tries > to jump over holes by checking the zone for each page. It might still > stumble over offline pages, though. Skip those by checking PageReserved. ups, forgot to update the changelog here. s@PageReserved@pfn_to_online_page()@ > Signed-off-by: Michal Hocko <mhocko@suse.com> > --- > mm/compaction.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 613c59e928cb..fb548e4c7bd4 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -236,10 +236,9 @@ static void __reset_isolation_suitable(struct zone *zone) > > cond_resched(); > > - if (!pfn_valid(pfn)) > + page = pfn_to_online_page(pfn); > + if (!page) > continue; > - > - page = pfn_to_page(pfn); > if (zone != page_zone(page)) > continue; > > -- > 2.11.0 > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-04-27 7:59 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-21 12:05 [PATCH -v3 0/13] mm: make movable onlining suck less Michal Hocko 2017-04-21 12:05 ` Michal Hocko 2017-04-21 12:05 ` [PATCH 01/13] mm: remove return value from init_currently_empty_zone Michal Hocko 2017-04-21 12:05 ` Michal Hocko 2017-04-21 12:05 ` [PATCH 02/13] mm, memory_hotplug: use node instead of zone in can_online_high_movable Michal Hocko 2017-04-21 12:05 ` Michal Hocko 2017-04-21 12:05 ` [PATCH 03/13] mm: drop page_initialized check from get_nid_for_pfn Michal Hocko 2017-04-21 12:05 ` Michal Hocko 2017-04-21 12:05 ` [PATCH 04/13] mm, memory_hotplug: get rid of is_zone_device_section Michal Hocko 2017-04-21 12:05 ` Michal Hocko 2017-04-21 12:05 ` [PATCH 05/13] mm, memory_hotplug: split up register_one_node Michal Hocko 2017-04-21 12:05 ` Michal Hocko 2017-04-21 12:05 ` [PATCH 06/13] mm, memory_hotplug: consider offline memblocks removable Michal Hocko 2017-04-21 12:05 ` Michal Hocko 2017-04-21 12:05 ` [PATCH 07/13] mm: consider zone which is not fully populated to have holes Michal Hocko 2017-04-21 12:05 ` Michal Hocko 2017-04-27 7:58 ` Michal Hocko 2017-04-27 7:58 ` Michal Hocko 2017-04-21 12:05 ` [PATCH 08/13] mm, compaction: skip over holes in __reset_isolation_suitable Michal Hocko 2017-04-21 12:05 ` Michal Hocko 2017-04-27 7:59 ` Michal Hocko [this message] 2017-04-27 7:59 ` Michal Hocko 2017-04-21 12:05 ` [PATCH 09/13] mm: __first_valid_page skip over offline pages Michal Hocko 2017-04-21 12:05 ` Michal Hocko 2017-04-21 12:21 ` [PATCH 11/13] mm, memory_hotplug: replace for_device by want_memblock in arch_add_memory Michal Hocko 2017-04-21 12:21 ` Michal Hocko 2017-04-21 12:21 ` [PATCH 12/13] mm, memory_hotplug: fix the section mismatch warning Michal Hocko 2017-04-21 12:21 ` Michal Hocko 2017-04-21 12:22 ` [PATCH 13/13] mm, memory_hotplug: remove unused cruft after memory hotplug rework Michal Hocko 2017-04-21 12:22 ` Michal Hocko 2017-04-21 12:30 ` [PATCH 10/13] mm, memory_hotplug: do not associate hotadded memory to zones until online Michal Hocko 2017-04-21 12:30 ` Michal Hocko 2017-04-21 12:52 ` Michal Hocko 2017-04-21 12:52 ` Michal Hocko 2017-04-27 7:56 ` [PATCH -v3 0/13] mm: make movable onlining suck less Michal Hocko 2017-04-27 7:56 ` Michal Hocko 2017-04-27 15:31 ` Jerome Glisse 2017-04-27 15:31 ` Jerome Glisse 2017-05-10 4:43 ` Dan Williams 2017-05-10 4:43 ` Dan Williams 2017-05-10 5:53 ` Michal Hocko 2017-05-10 5:53 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170427075922.GC4706@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=aarcange@redhat.com \ --cc=ak@linux.intel.com \ --cc=akpm@linux-foundation.org \ --cc=arbab@linux.vnet.ibm.com \ --cc=daniel.kiper@oracle.com \ --cc=imammedo@redhat.com \ --cc=jglisse@redhat.com \ --cc=js1304@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=qiuxishi@huawei.com \ --cc=rientjes@google.com \ --cc=slaoub@gmail.com \ --cc=toshi.kani@hpe.com \ --cc=vbabka@suse.cz \ --cc=vkuznets@redhat.com \ --cc=yasu.isimatu@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.