All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] ramblock: add new hmp command "info ramblock"
Date: Thu, 27 Apr 2017 16:06:18 +0800	[thread overview]
Message-ID: <20170427080618.GB1542@pxdev.xzpeter.org> (raw)
In-Reply-To: <87wpa6fflb.fsf@dusky.pond.sub.org>

On Thu, Apr 27, 2017 at 09:57:04AM +0200, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
> 
> > On 27/04/2017 09:07, Markus Armbruster wrote:
> >> Example for "makes no sense in QMP": setting the current CPU[1], because
> >> a QMP monitor doesn't have a current CPU.
> >> 
> >> Examples for "is of use only for human users": HMP command "help", the
> >> integrated pocket calculator[2].
> >
> > This example is more or less like "info mtree".
> >
> > In addition, it exposes ram_addr_t which is an internal interface to
> > QEMU.  Therefore it shouldn't be exposed through QMP.
> 
> Makes sense.  Peter, please explain it in your commit message.

Will do. Thanks Markus, Paolo.

-- 
Peter Xu

  reply	other threads:[~2017-04-27  8:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26  7:44 [Qemu-devel] [PATCH 0/2] ramblock: add hmp command "info ramblock" Peter Xu
2017-04-26  7:44 ` [Qemu-devel] [PATCH 1/2] ramblock: add RAMBLOCK_FOREACH() Peter Xu
2017-04-26  7:44 ` [Qemu-devel] [PATCH 2/2] ramblock: add new hmp command "info ramblock" Peter Xu
2017-04-26 12:10   ` Markus Armbruster
2017-04-27  2:09     ` Peter Xu
2017-04-27  7:07       ` Markus Armbruster
2017-04-27  7:39         ` Paolo Bonzini
2017-04-27  7:57           ` Markus Armbruster
2017-04-27  8:06             ` Peter Xu [this message]
2017-04-26 10:21 ` [Qemu-devel] [PATCH 0/2] ramblock: add " no-reply
2017-04-26 10:32   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170427080618.GB1542@pxdev.xzpeter.org \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.