All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: <linux-block@vger.kernel.org>,
	Bart Van Assche <bart.vanassche@sandisk.com>,
	Omar Sandoval <osandov@fb.com>, Hannes Reinecke <hare@suse.com>
Subject: [PATCH 3/6] blk-mq-debugfs: Show atomic request flags
Date: Thu, 27 Apr 2017 08:54:34 -0700	[thread overview]
Message-ID: <20170427155437.23228-4-bart.vanassche@sandisk.com> (raw)
In-Reply-To: <20170427155437.23228-1-bart.vanassche@sandisk.com>

When analyzing e.g. queue lockups it is important to know whether
or not a request has already been started. Hence also show the
atomic request flags.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Omar Sandoval <osandov@fb.com>
Cc: Hannes Reinecke <hare@suse.com>
---
 block/blk-mq-debugfs.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index bcd2a7d4a3a5..9cb673bc7230 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -308,6 +308,12 @@ static const char *const rqf_name[] = {
 	[ilog2((__force u32)RQF_SPECIAL_PAYLOAD)]	= "SPECIAL_PAYLOAD",
 };
 
+static const char *const rqaf_name[] = {
+	[REQ_ATOM_COMPLETE]	= "COMPLETE",
+	[REQ_ATOM_STARTED]	= "STARTED",
+	[REQ_ATOM_POLL_SLEPT]	= "POLL_SLEPT",
+};
+
 static int blk_mq_debugfs_rq_show(struct seq_file *m, void *v)
 {
 	struct request *rq = list_entry_rq(v);
@@ -325,6 +331,8 @@ static int blk_mq_debugfs_rq_show(struct seq_file *m, void *v)
 	seq_puts(m, ", .rq_flags=");
 	blk_flags_show(m, (__force unsigned int)rq->rq_flags, rqf_name,
 		       ARRAY_SIZE(rqf_name));
+	seq_puts(m, ", .atomic_flags=");
+	blk_flags_show(m, rq->atomic_flags, rqaf_name, ARRAY_SIZE(rqaf_name));
 	seq_printf(m, ", .tag=%d, .internal_tag=%d", rq->tag,
 		   rq->internal_tag);
 	if (mq_ops->show_rq)
-- 
2.12.2

  parent reply	other threads:[~2017-04-27 15:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 15:54 [PATCH 0/6] Six more patches for Linux kernel v4.12 Bart Van Assche
2017-04-27 15:54 ` [PATCH 1/6] blk-mq: Make blk_mq_quiesce_queue() wait for all .queue_rq() calls Bart Van Assche
2017-04-28  2:00   ` Ming Lei
2017-04-28  3:48     ` Ming Lei
2017-04-28 15:35     ` Bart Van Assche
2017-04-28 15:35       ` Bart Van Assche
2017-04-28 16:02       ` Ming Lei
2017-04-27 15:54 ` [PATCH 2/6] blk-mq: Fix the comment above blk_mq_quiesce_queue() Bart Van Assche
2017-04-27 22:37   ` Omar Sandoval
2017-04-27 22:40     ` Bart Van Assche
2017-04-28  3:26   ` Ming Lei
2017-04-27 15:54 ` Bart Van Assche [this message]
2017-04-27 22:38   ` [PATCH 3/6] blk-mq-debugfs: Show atomic request flags Omar Sandoval
2017-04-27 15:54 ` [PATCH 4/6] blk-mq-debugfs: Show requeue list Bart Van Assche
2017-04-27 22:40   ` Omar Sandoval
2017-04-27 15:54 ` [PATCH 5/6] blk-mq-debugfs: Show busy requests Bart Van Assche
2017-05-02  0:17   ` Omar Sandoval
2017-05-02 16:13     ` Bart Van Assche
2017-04-27 15:54 ` [PATCH 6/6] blk-mq-debugfs: Add 'kick' operation Bart Van Assche
2017-05-02  0:19   ` Omar Sandoval
2017-05-02  0:24     ` Jens Axboe
2017-05-02 16:23       ` Bart Van Assche
2017-05-02 16:25         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170427155437.23228-4-bart.vanassche@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.com \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.