From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423964AbdD1PiH (ORCPT ); Fri, 28 Apr 2017 11:38:07 -0400 Received: from foss.arm.com ([217.140.101.70]:50570 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1164711AbdD1Ph6 (ORCPT ); Fri, 28 Apr 2017 11:37:58 -0400 Date: Fri, 28 Apr 2017 16:37:58 +0100 From: Will Deacon To: Yury Norov Cc: Adam Wallis , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Peter Zijlstra , Catalin Marinas , Ingo Molnar , Jan Glauber , jason.low2@hp.com Subject: Re: [RFC PATCH 0/3] arm64: queued spinlocks and rw-locks Message-ID: <20170428153758.GV13675@arm.com> References: <1491860104-4103-1-git-send-email-ynorov@caviumnetworks.com> <20170413103309.GA1875@yury-N73SV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170413103309.GA1875@yury-N73SV> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 13, 2017 at 01:33:09PM +0300, Yury Norov wrote: > On Wed, Apr 12, 2017 at 01:04:55PM -0400, Adam Wallis wrote: > > On 4/10/2017 5:35 PM, Yury Norov wrote: > > > The patch of Jan Glauber enables queued spinlocks on arm64. I rebased it on > > > latest kernel sources, and added a couple of fixes to headers to apply it > > > smoothly. > > > > > > Though, locktourture test shows significant performance degradation in the > > > acquisition of rw-lock for read on qemu: > > > > > > Before After > > > spin_lock-torture: 38957034 37076367 -4.83 > > > rw_lock-torture W: 5369471 18971957 253.33 > > > rw_lock-torture R: 6413179 3668160 -42.80 > > > > > > > On our 48 core QDF2400 part, I am seeing huge improvements with these patches on > > the torture tests. The improvements go up even further when I apply Jason Low's > > MCS Spinlock patch: https://lkml.org/lkml/2016/4/20/725 > > It sounds great. So performance issue is looking like my local > problem, most probably because I ran tests on Qemu VM. > > I don't see any problems with this series, other than performance, > and if it looks fine now, I think it's good enough for upstream. I would still like to understand why you see such a significant performance degradation, and whether or not you also see that on native hardware (i.e. without Qemu involved). Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Fri, 28 Apr 2017 16:37:58 +0100 Subject: [RFC PATCH 0/3] arm64: queued spinlocks and rw-locks In-Reply-To: <20170413103309.GA1875@yury-N73SV> References: <1491860104-4103-1-git-send-email-ynorov@caviumnetworks.com> <20170413103309.GA1875@yury-N73SV> Message-ID: <20170428153758.GV13675@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Apr 13, 2017 at 01:33:09PM +0300, Yury Norov wrote: > On Wed, Apr 12, 2017 at 01:04:55PM -0400, Adam Wallis wrote: > > On 4/10/2017 5:35 PM, Yury Norov wrote: > > > The patch of Jan Glauber enables queued spinlocks on arm64. I rebased it on > > > latest kernel sources, and added a couple of fixes to headers to apply it > > > smoothly. > > > > > > Though, locktourture test shows significant performance degradation in the > > > acquisition of rw-lock for read on qemu: > > > > > > Before After > > > spin_lock-torture: 38957034 37076367 -4.83 > > > rw_lock-torture W: 5369471 18971957 253.33 > > > rw_lock-torture R: 6413179 3668160 -42.80 > > > > > > > On our 48 core QDF2400 part, I am seeing huge improvements with these patches on > > the torture tests. The improvements go up even further when I apply Jason Low's > > MCS Spinlock patch: https://lkml.org/lkml/2016/4/20/725 > > It sounds great. So performance issue is looking like my local > problem, most probably because I ran tests on Qemu VM. > > I don't see any problems with this series, other than performance, > and if it looks fine now, I think it's good enough for upstream. I would still like to understand why you see such a significant performance degradation, and whether or not you also see that on native hardware (i.e. without Qemu involved). Will