From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S637868AbdD1QOc (ORCPT ); Fri, 28 Apr 2017 12:14:32 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59102 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S637851AbdD1QOV (ORCPT ); Fri, 28 Apr 2017 12:14:21 -0400 Date: Fri, 28 Apr 2017 18:14:11 +0200 From: Greg Kroah-Hartman To: Catalin Marinas Cc: linux-kernel@vger.kernel.org, a.hajda@samsung.com, geert@linux-m68k.org, Laura Abbott , robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap() Message-ID: <20170428161411.GA26277@kroah.com> References: <1493144543-2497-1-git-send-email-catalin.marinas@arm.com> <20170425182549.GA18677@e104818-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170425182549.GA18677@e104818-lin.cambridge.arm.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 25, 2017 at 07:25:49PM +0100, Catalin Marinas wrote: > On Tue, Apr 25, 2017 at 07:22:23PM +0100, Catalin Marinas wrote: > > The dma_common_pages_remap() function allocates a vm_struct object and > > initialises the pages pointer to value passed as argument. However, when > > this function is called dma_common_contiguous_remap(), the pages array > > is only temporarily allocated, being freed shortly after > > dma_common_contiguous_remap() returns. Architecture code checking the > > validity of an area->pages pointer would incorrectly dereference already > > freed pointers. This has been exposed by the arm64 commit 44176bb38fa4 > > ("arm64: Add support for DMA_ATTR_FORCE_CONTIGUOUS to IOMMU"). > > > > Fixes: 513510ddba96 ("common: dma-mapping: introduce common remapping functions") > > Cc: Laura Abbott > > Cc: Greg Kroah-Hartman > > Reported-by: Andrzej Hajda > > Signed-off-by: Catalin Marinas > > Small correction on the subject, the prefix should be something like: > > drivers: dma-mapping: > > It's not an arm64 patch. If you want to take it through your tree: Acked-by: Greg Kroah-Hartman otherwise feel free to resend it with a fixed subject line and I can take it :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Fri, 28 Apr 2017 18:14:11 +0200 Subject: [PATCH] drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap() In-Reply-To: <20170425182549.GA18677@e104818-lin.cambridge.arm.com> References: <1493144543-2497-1-git-send-email-catalin.marinas@arm.com> <20170425182549.GA18677@e104818-lin.cambridge.arm.com> Message-ID: <20170428161411.GA26277@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Apr 25, 2017 at 07:25:49PM +0100, Catalin Marinas wrote: > On Tue, Apr 25, 2017 at 07:22:23PM +0100, Catalin Marinas wrote: > > The dma_common_pages_remap() function allocates a vm_struct object and > > initialises the pages pointer to value passed as argument. However, when > > this function is called dma_common_contiguous_remap(), the pages array > > is only temporarily allocated, being freed shortly after > > dma_common_contiguous_remap() returns. Architecture code checking the > > validity of an area->pages pointer would incorrectly dereference already > > freed pointers. This has been exposed by the arm64 commit 44176bb38fa4 > > ("arm64: Add support for DMA_ATTR_FORCE_CONTIGUOUS to IOMMU"). > > > > Fixes: 513510ddba96 ("common: dma-mapping: introduce common remapping functions") > > Cc: Laura Abbott > > Cc: Greg Kroah-Hartman > > Reported-by: Andrzej Hajda > > Signed-off-by: Catalin Marinas > > Small correction on the subject, the prefix should be something like: > > drivers: dma-mapping: > > It's not an arm64 patch. If you want to take it through your tree: Acked-by: Greg Kroah-Hartman otherwise feel free to resend it with a fixed subject line and I can take it :) thanks, greg k-h