From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948974AbdD3TjX (ORCPT ); Sun, 30 Apr 2017 15:39:23 -0400 Received: from mout02.posteo.de ([185.67.36.66]:53107 "EHLO mout02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948874AbdD3TjN (ORCPT ); Sun, 30 Apr 2017 15:39:13 -0400 From: Martin Kepplinger To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Kepplinger Subject: [PATCH 2/2 v2] input: touchscreen: ar1021_i2c: use BIT to check for a bit Date: Sun, 30 Apr 2017 21:38:53 +0200 Message-Id: <20170430193853.10958-1-martink@posteo.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <1493295756-17812-2-git-send-email-martin.kepplinger@ginzinger.com> References: <1493295756-17812-2-git-send-email-martin.kepplinger@ginzinger.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The MSB for the first byte of touch data transmission is always 1. Make it a little more obvious we're testing this bit by using BIT(7). Signed-off-by: Martin Kepplinger --- I'd still use the definition :) but otherwise I'd write the following. It really doesn't matter though. thanks for the quick support Dmitry, martin drivers/input/touchscreen/ar1021_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c index eb1874fe52c2..8c76aa435903 100644 --- a/drivers/input/touchscreen/ar1021_i2c.c +++ b/drivers/input/touchscreen/ar1021_i2c.c @@ -44,7 +44,7 @@ static irqreturn_t ar1021_i2c_irq(int irq, void *dev_id) goto out; /* sync bit set ? */ - if ((data[0] & 0x80) == 0) + if (!(data[0] & BIT(7))) goto out; button = data[0] & BIT(0); -- 2.11.0