From: David Gibson <david@gibson.dropbear.id.au>
To: Fam Zheng <famz@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-devel@nongnu.org, f4bug@amsat.org, peterx@redhat.com,
borntraeger@de.ibm.com, alex.williamson@redhat.com,
qemu-ppc@nongnu.org, cornelia.huck@de.ibm.com,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion
Date: Mon, 1 May 2017 14:44:21 +1000 [thread overview]
Message-ID: <20170501044421.GF13773@umbus.fritz.box> (raw)
In-Reply-To: <20170430131104.GA24566@lemon.lan>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
On Sun, Apr 30, 2017 at 09:11:04PM +0800, Fam Zheng wrote:
> On Sat, 04/29 22:36, Alexey Kardashevskiy wrote:
> > > === OUTPUT BEGIN ===
> > > Checking PATCH 1/1: memory/iommu: QOM'fy IOMMU MemoryRegion...
> > > ERROR: spaces required around that '*' (ctx:WxO)
> > > #156: FILE: hw/dma/rc4030.c:720:
> > > +DeviceState *rc4030_init(rc4030_dma **dmas, IOMMUMemoryRegion **dma_mr)
> >
> >
> > What does the script really want here? I am confused.
>
> Must be a false positive here.
Yeah. I think it thinks that's a multiply * rather than a pointer *.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-05-01 4:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-29 11:55 [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion Alexey Kardashevskiy
2017-04-29 11:59 ` no-reply
2017-04-29 12:28 ` no-reply
2017-04-29 12:36 ` Alexey Kardashevskiy
2017-04-30 13:11 ` Fam Zheng
2017-05-01 4:44 ` David Gibson [this message]
2017-05-02 9:30 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501044421.GF13773@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.