Re: [PATCH v2 05/14] power: max17042_battery: Change name in power_supply_desc to "main-battery"

[Sebastian Reichel <sebastian.reichel@collabora.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 2394 bytes --]

Hi,

On Fri, Apr 14, 2017 at 08:32:50PM +0200, Hans de Goede wrote:
> The max17042 will typically be coupled with some charger IC, almost all
> charger drivers contain:
> 
> static char *xxx_charger_supplied_to[] = {
>         "main-battery",
> };
> 
> probe()
> {
> 	struct power_supply_config cfg;
> 
> 	cfg.supplied_to = xxx_charger_supplied_to;
> 	cfg.num_supplicants = ARRAY_SIZE(xxx_charger_supplied_to);
> 	xxx->charger = power_supply_register(dev, &x_charger_desc, &_cfg);
> }
> 
> Change the name in max17042's power_supply_desc to "main-battery" to
> match, so that power_supply_am_i_supplied() can be used to implement
> POWER_SUPPLY_PROP_STATUS.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

I did not queue this patch and patch 14. First of all: Currently 4/30
chargers have this, which I wouldn't call "almost all". I think this
is not the right solution, especially as it will break once a system
has more than one "main" battery (like some of the newer thinkpads).

For DT based systems we have generic support to specify the
dependency as phandle. This obviously won't work for you.
I suggest to use a device property for supplying the correct name
to the charger instead.

-- Sebastian

> ---
>  drivers/power/supply/max17042_battery.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
> index f0ff6e8..3249eb0 100644
> --- a/drivers/power/supply/max17042_battery.c
> +++ b/drivers/power/supply/max17042_battery.c
> @@ -866,7 +866,7 @@ static const struct regmap_config max17042_regmap_config = {
>  };
>  
>  static const struct power_supply_desc max17042_psy_desc = {
> -	.name		= "max170xx_battery",
> +	.name		= "main-battery",
>  	.type		= POWER_SUPPLY_TYPE_BATTERY,
>  	.get_property	= max17042_get_property,
>  	.set_property	= max17042_set_property,
> @@ -876,7 +876,7 @@ static const struct power_supply_desc max17042_psy_desc = {
>  };
>  
>  static const struct power_supply_desc max17042_no_current_sense_psy_desc = {
> -	.name		= "max170xx_battery",
> +	.name		= "main-battery",
>  	.type		= POWER_SUPPLY_TYPE_BATTERY,
>  	.get_property	= max17042_get_property,
>  	.set_property	= max17042_set_property,
> -- 
> 2.9.3
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]