From: Brandon Williams <bmwill@google.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 5/6] submodule: improve submodule_has_commits
Date: Mon, 1 May 2017 09:55:15 -0700 [thread overview]
Message-ID: <20170501165515.GE39135@google.com> (raw)
In-Reply-To: <CAGZ79ka=gALFrzj1OpL9tifiS7eSOSVAMfxY3gD3T6o-teJuaA@mail.gmail.com>
On 05/01, Stefan Beller wrote:
> On Sun, Apr 30, 2017 at 4:14 PM, Brandon Williams <bmwill@google.com> wrote:
>
> > This hunk of logic is essentially a copy and paste from elsewhere in the
> > file. Essentially both code paths were essentially doing the same thing
> > (checking if a submodule has a commit) but one of the code paths included
> > this logic to ensure that it was reachable from a ref in the submodule.
> > In order to merge the two code paths, I included that logic here.
>
> yes, I get that. The question is whether the other code path omitted the check
> intentionally or just missed it (Is it a bug or feature to have this
> check in that code
> path now)?
I'd take a look at Junio's response. This check more than likely needs
to be included.
--
Brandon Williams
next prev parent reply other threads:[~2017-05-01 16:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 23:53 [PATCH 0/6] changed submodules Brandon Williams
2017-04-28 23:53 ` [PATCH 1/6] submodule: rename add_sha1_to_array Brandon Williams
2017-05-01 3:18 ` Junio C Hamano
2017-04-28 23:53 ` [PATCH 2/6] submodule: rename free_submodules_sha1s Brandon Williams
2017-04-28 23:53 ` [PATCH 3/6] submodule: remove add_oid_to_argv Brandon Williams
2017-04-28 23:54 ` [PATCH 4/6] submodule: change string_list changed_submodule_paths Brandon Williams
2017-05-01 3:28 ` Junio C Hamano
2017-05-01 16:35 ` Brandon Williams
2017-04-28 23:54 ` [PATCH 5/6] submodule: improve submodule_has_commits Brandon Williams
2017-04-29 0:28 ` Stefan Beller
2017-04-30 23:14 ` Brandon Williams
2017-05-01 16:52 ` Stefan Beller
2017-05-01 16:55 ` Brandon Williams [this message]
2017-05-01 3:37 ` Junio C Hamano
2017-05-01 16:46 ` Brandon Williams
2017-04-28 23:54 ` [PATCH 6/6] submodule: refactor logic to determine changed submodules Brandon Williams
2017-04-29 0:53 ` Stefan Beller
2017-05-01 16:49 ` Brandon Williams
2017-05-01 1:42 ` [PATCH 0/6] " Junio C Hamano
2017-05-02 1:02 ` [PATCH v2 " Brandon Williams
2017-05-02 1:02 ` [PATCH v2 1/6] submodule: rename add_sha1_to_array Brandon Williams
2017-05-02 1:05 ` Stefan Beller
2017-05-02 1:09 ` Brandon Williams
2017-05-02 1:02 ` [PATCH v2 2/6] submodule: rename free_submodules_sha1s Brandon Williams
2017-05-02 1:02 ` [PATCH v2 3/6] submodule: remove add_oid_to_argv Brandon Williams
2017-05-02 1:02 ` [PATCH v2 4/6] submodule: change string_list changed_submodule_paths Brandon Williams
2017-05-02 1:02 ` [PATCH v2 5/6] submodule: improve submodule_has_commits Brandon Williams
2017-05-02 1:34 ` Stefan Beller
2017-05-02 17:25 ` Brandon Williams
2017-05-02 17:55 ` Stefan Beller
2017-05-02 19:14 ` Brandon Williams
2017-05-02 19:30 ` Brandon Williams
2017-05-02 1:02 ` [PATCH v2 6/6] submodule: refactor logic to determine changed submodules Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501165515.GE39135@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.