All of lore.kernel.org
 help / color / mirror / Atom feed
From: kusumi.tomohiro@gmail.com
To: axboe@kernel.dk, fio@vger.kernel.org
Cc: Tomohiro Kusumi <tkusumi@tuxera.com>
Subject: [PATCH 10/11] configure: Add missing $val != "yes" test to override compile_prog() result
Date: Mon,  1 May 2017 21:48:19 +0300	[thread overview]
Message-ID: <20170501184820.31025-10-tkusumi@tuxera.com> (raw)
In-Reply-To: <20170501184820.31025-1-tkusumi@tuxera.com>

From: Tomohiro Kusumi <tkusumi@tuxera.com>

Since it's possible for some platforms to use statically configured
configurations (e.g. see around L350 for Cygwin), it should test if
the variable hasn't been set to "yes" before initializing the variable
with "no", so that compile_prog() result can be safely ignored when
the platform knows it's supported.

ca205a75 (configure: Make Cygwin take regular configure path) started
this due to a major change in the configuration path, which changed
Cygwin to take the normal path taken by all other platforms, and
these two were added after that change.

Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
---
 configure | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index fe3354e..ce46996 100755
--- a/configure
+++ b/configure
@@ -631,7 +631,9 @@ echo "POSIX AIO fsync               $posix_aio_fsync"
 
 ##########################################
 # POSIX pshared attribute probe
-posix_pshared="no"
+if test "$posix_pshared" != "yes" ; then
+  posix_pshared="no"
+fi
 cat > $TMPC <<EOF
 #include <unistd.h>
 int main(void)
@@ -2024,7 +2026,9 @@ echo "march_armv8_a_crc_crypto      $march_armv8_a_crc_crypto"
 
 ##########################################
 # cuda probe
-cuda="no"
+if test "$cuda" != "yes" ; then
+  cuda="no"
+fi
 cat > $TMPC << EOF
 #include <cuda.h>
 int main(int argc, char **argv)
-- 
2.9.3



  parent reply	other threads:[~2017-05-01 18:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-01 18:48 [PATCH 01/11] configure: Disable CONFIG_POSIX_FALLOCATE on NetBSD even if posix_fallocate(3) compiles kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 02/11] configure: Add compile_exec_prog() to compile and execute the binary kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 03/11] configure: Use single square brackets (POSIX) kusumi.tomohiro
2017-05-02  5:36   ` Sitsofe Wheeler
2017-05-02  5:58     ` Tomohiro Kusumi
2017-05-01 18:48 ` [PATCH 04/11] configure: Use compile_exec_prog() for s390_z196_facilities kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 05/11] configure: output_sym CONFIG_GFIO kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 06/11] configure: Add missing <string.h> to avoid bogus warning kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 07/11] configure: Add void* cast " kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 08/11] configure: Check gfio test result via return value (not printf) kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 09/11] configure: Add missing ########## kusumi.tomohiro
2017-05-01 18:48 ` kusumi.tomohiro [this message]
2017-05-01 18:48 ` [PATCH 11/11] configure: Add print_config() for "<config>... <yes|no>" outputs kusumi.tomohiro
2017-05-01 20:44 ` [PATCH 01/11] configure: Disable CONFIG_POSIX_FALLOCATE on NetBSD even if posix_fallocate(3) compiles Jens Axboe
2017-05-01 20:54   ` Tomohiro Kusumi
2017-05-01 20:57     ` Jens Axboe
2017-05-01 21:10       ` Tomohiro Kusumi
2017-05-01 20:48 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170501184820.31025-10-tkusumi@tuxera.com \
    --to=kusumi.tomohiro@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=tkusumi@tuxera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.