From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Duy Nguyen <pclouds@gmail.com>,
Christian Couder <christian.couder@gmail.com>,
Thomas Gummerer <t.gummerer@gmail.com>, git <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] cache-tree: reject entries with null sha1
Date: Mon, 1 May 2017 15:22:12 -0400 [thread overview]
Message-ID: <20170501192212.xy5o72tinb2hy2a3@sigill.intra.peff.net> (raw)
In-Reply-To: <12c3312c-30a1-2cb1-8f05-63bb663bd0a0@web.de>
On Mon, May 01, 2017 at 01:23:28PM +0200, René Scharfe wrote:
> Am 24.04.2017 um 12:39 schrieb Duy Nguyen:
> > BTW, I ran t7009 with valgrind and it reported this. Is it something
> > we should be worried about? I vaguely recall you're doing something
> > with prio-queue...
> >
> > ==4246== Source and destination overlap in memcpy(0x5952990, 0x5952990, 16)
> > ==4246== at 0x4C2EACD: memcpy@@GLIBC_2.14 (in
> > /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
> > ==4246== by 0x545D05: swap (prio-queue.c:15)
> > ==4246== by 0x545D72: prio_queue_reverse (prio-queue.c:25)
> > ==4246== by 0x4CBC0C: sort_in_topological_order (commit.c:723)
> > ==4246== by 0x574C97: prepare_revision_walk (revision.c:2858)
> > ==4246== by 0x48A2BA: cmd_rev_list (rev-list.c:385)
> > ==4246== by 0x405A6F: run_builtin (git.c:371)
> > ==4246== by 0x405CDC: handle_builtin (git.c:572)
> > ==4246== by 0x405E51: run_argv (git.c:624)
> > ==4246== by 0x405FF3: cmd_main (git.c:701)
> > ==4246== by 0x4A48CE: main (common-main.c:43)
>
> I can only get gcc and clang to call memcpy instead of inlining it by
> specifying -fno-builtin. Do you use that option? If yes, why? (Just
> curious.)
I do my normal edit-compile cycles with -O0 because it's fast, and
because it makes debugging much easier.
> But I can't get Valgrind to report overlapping (nicely explained in
> http://valgrind.org/docs/manual/mc-manual.html#mc-manual.overlap, by
> the way), not for t7009 and not for the short test program at the
> bottom. Do you set flags in GIT_VALGRIND_OPTIONS or use a special
> version of Valgrind? I use valgrind-3.12.0.SVN from Debian testing.
I saw it with 3.12.0-1.1 on Debian unstable.
-Peff
next prev parent reply other threads:[~2017-05-01 19:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 18:46 [PATCH] cache-tree: reject entries with null sha1 Jeff King
2017-04-24 10:39 ` Duy Nguyen
2017-04-24 11:13 ` Jeff King
2017-05-01 11:23 ` René Scharfe
2017-05-01 11:55 ` René Scharfe
2017-05-01 19:22 ` Jeff King [this message]
2017-05-01 21:00 ` René Scharfe
2017-05-01 21:26 ` Jeff King
2017-05-03 9:46 ` Duy Nguyen
2017-05-03 19:48 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501192212.xy5o72tinb2hy2a3@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=pclouds@gmail.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.