From: Christoph Hellwig <hch@lst.de>
To: Amir Goldstein <amir73il@gmail.com>
Cc: "Darrick J . Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Miklos Szeredi <miklos@szeredi.hu>,
Vivek Goyal <vgoyal@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] xfs: publish UUID in struct super_block
Date: Tue, 2 May 2017 09:30:19 +0200 [thread overview]
Message-ID: <20170502073019.GD11582@lst.de> (raw)
In-Reply-To: <1493388001-15879-1-git-send-email-amir73il@gmail.com>
On Fri, Apr 28, 2017 at 05:00:01PM +0300, Amir Goldstein wrote:
> Copy the uuid of the filesystem to struct super_block s_uuid field,
> as several other filesystems already do. Copy regardless of the nouuid
> mount option, because other filesystems also do not guaranty uniqueness
> of the s_uuid field in super_block struct.
No guaranteeing uniqueness will create problems, don't do that.
Other file system didn't use to do the uuid table check that XFS did
either, and that's a fatal bug. In the long run we'll need to move
this check to the VFS now that we have s_uuid.
Also while checking for a nul uuid is probably ok we need to formalize
that at least that the check is needed. Preferably by adding a little
inline helper for it, and documenting it.
next prev parent reply other threads:[~2017-05-02 7:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 14:00 [PATCH v2] xfs: publish UUID in struct super_block Amir Goldstein
2017-04-28 15:13 ` Darrick J. Wong
2017-05-02 7:30 ` Christoph Hellwig [this message]
2017-05-02 14:13 ` Amir Goldstein
2017-05-02 14:17 ` Christoph Hellwig
2017-05-02 14:27 ` Amir Goldstein
2017-05-02 14:47 ` Christoph Hellwig
2017-05-02 15:08 ` Miklos Szeredi
2017-05-02 15:17 ` Christoph Hellwig
2017-05-02 17:09 ` Amir Goldstein
2017-05-02 18:25 ` Amir Goldstein
2017-05-02 18:30 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502073019.GD11582@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vgoyal@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.