From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH RFC 2/6] drm: Make drm_atomic_replace_property_blob_from_id() more generic Date: Tue, 2 May 2017 10:31:07 +0200 Message-ID: <20170502083107.tqkf35b5c5cujgc3@phenom.ffwll.local> References: <851b8504c7f294a10645ba6f6d391ac9764068b7.1492768073.git.jsarha@ti.com> <2096444.83ys8iMxUO@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B16189C68 for ; Tue, 2 May 2017 08:31:12 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id u65so2435591wmu.3 for ; Tue, 02 May 2017 01:31:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <2096444.83ys8iMxUO@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Liviu.Dudau@arm.com, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, Jyri Sarha List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBBcHIgMjEsIDIwMTcgYXQgMDI6NDc6NDRQTSArMDMwMCwgTGF1cmVudCBQaW5jaGFy dCB3cm90ZToKPiBIaSBKeXJpLAo+IAo+IFRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgo+IAo+IE9u IEZyaWRheSAyMSBBcHIgMjAxNyAxMjo1MToxMyBKeXJpIFNhcmhhIHdyb3RlOgo+ID4gQ2hhbmdl IGRybV9hdG9taWNfcmVwbGFjZV9wcm9wZXJ0eV9ibG9iX2Zyb21faWQoKSdzIGZpcnN0IHBhcmFt ZXRlcgo+ID4gZnJvbSBkcm1fY3J0YyB0byBkcm1fZGV2aWNlLCBzbyB0aGF0IHRoZSBmdW5jdGlv biBjYW4gYmUgdXNlZCBmb3Igb3RoZXIKPiA+IGRybV9tb2RlX29iamVjdHMgdG9vLgo+ID4gCj4g PiBTaWduZWQtb2ZmLWJ5OiBKeXJpIFNhcmhhIDxqc2FyaGFAdGkuY29tPgo+IAo+IFJldmlld2Vk LWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+ CgpGaXJzdCB0d28gcGF0Y2hlcyBhcHBsaWVkIGZvciA0LjEzLCB0aGFua3MuCi1EYW5pZWwKCj4g Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jIHwgMTAgKysrKystLS0t LQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4g PiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9hdG9taWMuYwo+ID4gaW5kZXggOWI4OTJhZi4uZjg4MTMxOSAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fYXRvbWljLmMKPiA+IEBAIC00MjUsNyArNDI1LDcgQEAgaW50IGRybV9hdG9t aWNfc2V0X21vZGVfcHJvcF9mb3JfY3J0YyhzdHJ1Y3QKPiA+IGRybV9jcnRjX3N0YXRlICpzdGF0 ZSwgfQo+ID4gCj4gPiAgc3RhdGljIGludAo+ID4gLWRybV9hdG9taWNfcmVwbGFjZV9wcm9wZXJ0 eV9ibG9iX2Zyb21faWQoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4gK2RybV9hdG9taWNfcmVw bGFjZV9wcm9wZXJ0eV9ibG9iX2Zyb21faWQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ICAJ CQkJCSBzdHJ1Y3QgZHJtX3Byb3BlcnR5X2Jsb2IgKipibG9iLAo+ID4gIAkJCQkJIHVpbnQ2NF90 IGJsb2JfaWQsCj4gPiAgCQkJCQkgc3NpemVfdCBleHBlY3RlZF9zaXplLAo+ID4gQEAgLTQzNCw3 ICs0MzQsNyBAQCBpbnQgZHJtX2F0b21pY19zZXRfbW9kZV9wcm9wX2Zvcl9jcnRjKHN0cnVjdAo+ ID4gZHJtX2NydGNfc3RhdGUgKnN0YXRlLCBzdHJ1Y3QgZHJtX3Byb3BlcnR5X2Jsb2IgKm5ld19i bG9iID0gTlVMTDsKPiA+IAo+ID4gIAlpZiAoYmxvYl9pZCAhPSAwKSB7Cj4gPiAtCQluZXdfYmxv YiA9IGRybV9wcm9wZXJ0eV9sb29rdXBfYmxvYihjcnRjLT5kZXYsIGJsb2JfaWQpOwo+ID4gKwkJ bmV3X2Jsb2IgPSBkcm1fcHJvcGVydHlfbG9va3VwX2Jsb2IoZGV2LCBibG9iX2lkKTsKPiA+ICAJ CWlmIChuZXdfYmxvYiA9PSBOVUxMKQo+ID4gIAkJCXJldHVybiAtRUlOVkFMOwo+ID4gCj4gPiBA QCAtNDgzLDcgKzQ4Myw3IEBAIGludCBkcm1fYXRvbWljX2NydGNfc2V0X3Byb3BlcnR5KHN0cnVj dCBkcm1fY3J0YyAqY3J0YywKPiA+ICAJCWRybV9wcm9wZXJ0eV9ibG9iX3B1dChtb2RlKTsKPiA+ ICAJCXJldHVybiByZXQ7Cj4gPiAgCX0gZWxzZSBpZiAocHJvcGVydHkgPT0gY29uZmlnLT5kZWdh bW1hX2x1dF9wcm9wZXJ0eSkgewo+ID4gLQkJcmV0ID0gZHJtX2F0b21pY19yZXBsYWNlX3Byb3Bl cnR5X2Jsb2JfZnJvbV9pZChjcnRjLAo+ID4gKwkJcmV0ID0gZHJtX2F0b21pY19yZXBsYWNlX3By b3BlcnR5X2Jsb2JfZnJvbV9pZChkZXYsCj4gPiAgCQkJCQkmc3RhdGUtPmRlZ2FtbWFfbHV0LAo+ ID4gIAkJCQkJdmFsLAo+ID4gIAkJCQkJLTEsCj4gPiBAQCAtNDkxLDcgKzQ5MSw3IEBAIGludCBk cm1fYXRvbWljX2NydGNfc2V0X3Byb3BlcnR5KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiA+ICAJ CXN0YXRlLT5jb2xvcl9tZ210X2NoYW5nZWQgfD0gcmVwbGFjZWQ7Cj4gPiAgCQlyZXR1cm4gcmV0 Owo+ID4gIAl9IGVsc2UgaWYgKHByb3BlcnR5ID09IGNvbmZpZy0+Y3RtX3Byb3BlcnR5KSB7Cj4g PiAtCQlyZXQgPSBkcm1fYXRvbWljX3JlcGxhY2VfcHJvcGVydHlfYmxvYl9mcm9tX2lkKGNydGMs Cj4gPiArCQlyZXQgPSBkcm1fYXRvbWljX3JlcGxhY2VfcHJvcGVydHlfYmxvYl9mcm9tX2lkKGRl diwKPiA+ICAJCQkJCSZzdGF0ZS0+Y3RtLAo+ID4gIAkJCQkJdmFsLAo+ID4gIAkJCQkJc2l6ZW9m KHN0cnVjdCBkcm1fY29sb3JfY3RtKSwKPiA+IEBAIC00OTksNyArNDk5LDcgQEAgaW50IGRybV9h dG9taWNfY3J0Y19zZXRfcHJvcGVydHkoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4gIAkJc3Rh dGUtPmNvbG9yX21nbXRfY2hhbmdlZCB8PSByZXBsYWNlZDsKPiA+ICAJCXJldHVybiByZXQ7Cj4g PiAgCX0gZWxzZSBpZiAocHJvcGVydHkgPT0gY29uZmlnLT5nYW1tYV9sdXRfcHJvcGVydHkpIHsK PiA+IC0JCXJldCA9IGRybV9hdG9taWNfcmVwbGFjZV9wcm9wZXJ0eV9ibG9iX2Zyb21faWQoY3J0 YywKPiA+ICsJCXJldCA9IGRybV9hdG9taWNfcmVwbGFjZV9wcm9wZXJ0eV9ibG9iX2Zyb21faWQo ZGV2LAo+ID4gIAkJCQkJJnN0YXRlLT5nYW1tYV9sdXQsCj4gPiAgCQkJCQl2YWwsCj4gPiAgCQkJ CQktMSwKPiAKPiAtLSAKPiBSZWdhcmRzLAo+IAo+IExhdXJlbnQgUGluY2hhcnQKPiAKCi0tIApE YW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8v YmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK