From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751249AbdEBLIe (ORCPT ); Tue, 2 May 2017 07:08:34 -0400 Received: from foss.arm.com ([217.140.101.70]:43076 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbdEBLIc (ORCPT ); Tue, 2 May 2017 07:08:32 -0400 Date: Tue, 2 May 2017 12:08:27 +0100 From: Catalin Marinas To: Heinrich Schuchardt Cc: Will Deacon , Steve Capper , Suzuki K Poulose , Andre Przywara , linux-kernel@vger.kernel.org, Julien Grall , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] arm64: Always provide "model name" in /proc/cpuinfo Message-ID: <20170502110827.GA29224@e104818-lin.cambridge.arm.com> References: <20170501223913.6894-1-xypron.glpk@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170501223913.6894-1-xypron.glpk@gmx.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 02, 2017 at 12:39:13AM +0200, Heinrich Schuchardt wrote: > There is no need to hide the model name in processes > that are not PER_LINUX32. > > So let us always provide a model name that is easily readable. > > Fixes: e47b020a323d ("arm64: Provide "model name" in /proc/cpuinfo for PER_LINUX32 tasks") > Signed-off-by: Heinrich Schuchardt > --- > arch/arm64/kernel/cpuinfo.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c > index b3d5b3e8fbcb..9ad9ddcd2f19 100644 > --- a/arch/arm64/kernel/cpuinfo.c > +++ b/arch/arm64/kernel/cpuinfo.c > @@ -118,9 +118,8 @@ static int c_show(struct seq_file *m, void *v) > * "processor". Give glibc what it expects. > */ > seq_printf(m, "processor\t: %d\n", i); > - if (compat) > - seq_printf(m, "model name\t: ARMv8 Processor rev %d (%s)\n", > - MIDR_REVISION(midr), COMPAT_ELF_PLATFORM); > + seq_printf(m, "model name\t: ARMv8 Processor rev %d (%s)\n", > + MIDR_REVISION(midr), COMPAT_ELF_PLATFORM); > > seq_printf(m, "BogoMIPS\t: %lu.%02lu\n", > loops_per_jiffy / (500000UL/HZ), Such patch seems to come up regularly: https://patchwork.kernel.org/patch/9303311/ (and it usually gets rejected) -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 From: catalin.marinas@arm.com (Catalin Marinas) Date: Tue, 2 May 2017 12:08:27 +0100 Subject: [PATCH 1/1] arm64: Always provide "model name" in /proc/cpuinfo In-Reply-To: <20170501223913.6894-1-xypron.glpk@gmx.de> References: <20170501223913.6894-1-xypron.glpk@gmx.de> Message-ID: <20170502110827.GA29224@e104818-lin.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, May 02, 2017 at 12:39:13AM +0200, Heinrich Schuchardt wrote: > There is no need to hide the model name in processes > that are not PER_LINUX32. > > So let us always provide a model name that is easily readable. > > Fixes: e47b020a323d ("arm64: Provide "model name" in /proc/cpuinfo for PER_LINUX32 tasks") > Signed-off-by: Heinrich Schuchardt > --- > arch/arm64/kernel/cpuinfo.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c > index b3d5b3e8fbcb..9ad9ddcd2f19 100644 > --- a/arch/arm64/kernel/cpuinfo.c > +++ b/arch/arm64/kernel/cpuinfo.c > @@ -118,9 +118,8 @@ static int c_show(struct seq_file *m, void *v) > * "processor". Give glibc what it expects. > */ > seq_printf(m, "processor\t: %d\n", i); > - if (compat) > - seq_printf(m, "model name\t: ARMv8 Processor rev %d (%s)\n", > - MIDR_REVISION(midr), COMPAT_ELF_PLATFORM); > + seq_printf(m, "model name\t: ARMv8 Processor rev %d (%s)\n", > + MIDR_REVISION(midr), COMPAT_ELF_PLATFORM); > > seq_printf(m, "BogoMIPS\t: %lu.%02lu\n", > loops_per_jiffy / (500000UL/HZ), Such patch seems to come up regularly: https://patchwork.kernel.org/patch/9303311/ (and it usually gets rejected) -- Catalin