From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 2 May 2017 09:19:30 -0400 Subject: [U-Boot] [PATCH v2 2/3] common: dfu: ignore reset for spl-dfu In-Reply-To: <6C6B28D4DC342643927BEAFCE8707BF6C0B749F3@DBDE04.ent.ti.com> References: <1493295321-15498-1-git-send-email-ravibabu@ti.com> <1493295321-15498-3-git-send-email-ravibabu@ti.com> <20170427123256.GQ12511@bill-the-cat> <6C6B28D4DC342643927BEAFCE8707BF6C0B6E7E1@DBDE04.ent.ti.com> <20170427181313.GW12511@bill-the-cat> <6C6B28D4DC342643927BEAFCE8707BF6C0B74922@DBDE04.ent.ti.com> <20170502125747.GK12511@bill-the-cat> <6C6B28D4DC342643927BEAFCE8707BF6C0B749F3@DBDE04.ent.ti.com> Message-ID: <20170502131930.GL12511@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, May 02, 2017 at 01:02:24PM +0000, B, Ravi wrote: > Tom > > >> >> > >> >> I observed around 7K reduced. > >> > >> >I don't just mean dropping out CLI, I mean after dropping out CLI but leaving in the reset logic. That's _still_ 7k? > >> > >> Without this fix, with cli_simple_run_command(), size of MLO with default dra7xx_evm_defconfig is 130K. > >> With this fix, compile out cli.c, the MLO size is 126K. > >> Around 4K is space saved. > > >OK. And dropping out CLI and leaving in reset, unconditionally vs dropping out CLI and also dropping reset via DFU, what is the savings there? Is that 3K? > > 7K provided earlier was wrong calculation. Sorry for confusion. OK. > If unconditionally dropping CLI and use do_reset instead of > run_command, I will save around 4K. (with this patch v2 series) > If unconditionally dropping CLI and dropping do_reset in SPL-DFU, I > will save around 5K. (with this patch series + drop do_reset in > SPL-DFU unconditionally) Can you give the exact bytes saved in each case, with your specific compiler? I ask since I'm surprised it's more than a function being dropped by the linker in this case. diff'ing the u-boot-spl.map files would also say what is dropped and I'd be interested in that. (And yes, I'm asking for more details to justify adding a Kconfig option here). Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: