From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751267AbdEBRAx (ORCPT ); Tue, 2 May 2017 13:00:53 -0400 Received: from gateway20.websitewelcome.com ([192.185.46.107]:45250 "EHLO gateway20.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750773AbdEBRAw (ORCPT ); Tue, 2 May 2017 13:00:52 -0400 X-Greylist: delayed 1402 seconds by postgrey-1.27 at vger.kernel.org; Tue, 02 May 2017 13:00:52 EDT Date: Tue, 2 May 2017 11:37:22 -0500 From: "Gustavo A. R. Silva" To: Felipe Balbi , Greg Kroah-Hartman , Jussi Kivilinna , Colin Ian King , Tim Harvey , Raz Manor Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Alan Stern , "Gustavo A. R. Silva" , Peter Senna Tschudin Subject: [PATCH v2] usb: gadget: udc: add null check before pointer dereference Message-ID: <20170502163722.GA27331@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170502102901.Horde.V3lYucW4z0pbiibIoA4m_9v@gator4166.hostgator.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 177.237.172.136 X-Exim-ID: 1d5anm-000L9R-2L X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [177.237.172.136]:29505 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 12 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add null check before dereferencing dev->regs pointer inside net2280_led_shutdown() function. Addresses-Coverity-ID: 101783 Cc: Alan Stern Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Move the net2280_led_shutdown() call later. drivers/usb/gadget/udc/net2280.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c index 3828c2e..4f5c0c4 100644 --- a/drivers/usb/gadget/udc/net2280.c +++ b/drivers/usb/gadget/udc/net2280.c @@ -3573,7 +3573,6 @@ static void net2280_remove(struct pci_dev *pdev) BUG_ON(dev->driver); /* then clean up the resources we allocated during probe() */ - net2280_led_shutdown(dev); if (dev->requests) { int i; for (i = 1; i < 5; i++) { @@ -3588,8 +3587,10 @@ static void net2280_remove(struct pci_dev *pdev) free_irq(pdev->irq, dev); if (dev->quirks & PLX_PCIE) pci_disable_msi(pdev); - if (dev->regs) + if (dev->regs) { + net2280_led_shutdown(dev); iounmap(dev->regs); + } if (dev->region) release_mem_region(pci_resource_start(pdev, 0), pci_resource_len(pdev, 0)); -- 2.5.0