All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [RFC] [PATCH] syslog-lib.sh: Produce TCONF instead of TBROK for journald
@ 2017-05-02 18:17 Cyril Hrubis
  2017-05-04 18:59 ` Jan Stancek
  0 siblings, 1 reply; 3+ messages in thread
From: Cyril Hrubis @ 2017-05-02 18:17 UTC (permalink / raw)
  To: ltp

If there is no traditional syslog daemon installed these testcaess exit
with TBROK which is not correct since these tests are simply not
applicable if no syslog daemon is installed.

Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
---
 testcases/kernel/syscalls/syslog/syslog-lib.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/syslog/syslog-lib.sh b/testcases/kernel/syscalls/syslog/syslog-lib.sh
index e166d3a45..35c13daf7 100755
--- a/testcases/kernel/syscalls/syslog/syslog-lib.sh
+++ b/testcases/kernel/syscalls/syslog/syslog-lib.sh
@@ -86,8 +86,8 @@ EOF
 )
 		fi
 	else
-		tst_resm TBROK "Couldn't find syslogd, syslog-ng or rsyslogd"
-		cleanup 1
+		tst_resm TCONF "Couldn't find syslogd, syslog-ng or rsyslogd"
+		cleanup 32
 	fi
 
 	# Back up configuration file
-- 
2.12.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [LTP] [RFC] [PATCH] syslog-lib.sh: Produce TCONF instead of TBROK for journald
  2017-05-02 18:17 [LTP] [RFC] [PATCH] syslog-lib.sh: Produce TCONF instead of TBROK for journald Cyril Hrubis
@ 2017-05-04 18:59 ` Jan Stancek
  2017-05-05  9:11   ` Cyril Hrubis
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Stancek @ 2017-05-04 18:59 UTC (permalink / raw)
  To: ltp



----- Original Message -----
> If there is no traditional syslog daemon installed these testcaess exit
> with TBROK which is not correct since these tests are simply not
> applicable if no syslog daemon is installed.
> 
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> ---
>  testcases/kernel/syscalls/syslog/syslog-lib.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/syslog/syslog-lib.sh
> b/testcases/kernel/syscalls/syslog/syslog-lib.sh
> index e166d3a45..35c13daf7 100755
> --- a/testcases/kernel/syscalls/syslog/syslog-lib.sh
> +++ b/testcases/kernel/syscalls/syslog/syslog-lib.sh
> @@ -86,8 +86,8 @@ EOF
>  )
>  		fi
>  	else
> -		tst_resm TBROK "Couldn't find syslogd, syslog-ng or rsyslogd"
> -		cleanup 1
> +		tst_resm TCONF "Couldn't find syslogd, syslog-ng or rsyslogd"
> +		cleanup 32
>  	fi
>  
>  	# Back up configuration file
> --
> 2.12.2

ACK

Regards,
Jan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [LTP] [RFC] [PATCH] syslog-lib.sh: Produce TCONF instead of TBROK for journald
  2017-05-04 18:59 ` Jan Stancek
@ 2017-05-05  9:11   ` Cyril Hrubis
  0 siblings, 0 replies; 3+ messages in thread
From: Cyril Hrubis @ 2017-05-05  9:11 UTC (permalink / raw)
  To: ltp

Hi!
> ACK

Pushed.

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-05  9:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-02 18:17 [LTP] [RFC] [PATCH] syslog-lib.sh: Produce TCONF instead of TBROK for journald Cyril Hrubis
2017-05-04 18:59 ` Jan Stancek
2017-05-05  9:11   ` Cyril Hrubis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.