All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix for new version of realtek r8153
@ 2017-05-02 23:20 jake Briggs
  2017-05-03  9:18   ` Hayes Wang
  0 siblings, 1 reply; 3+ messages in thread
From: jake Briggs @ 2017-05-02 23:20 UTC (permalink / raw)
  To: hayeswang, mario_limonciello, linux-usb, netdev, linux-kernel; +Cc: jake

From: jake <jake@rabidtech.co.nz>

Fix for new version of realtek r8153 not being recognised by the r8152
driver. The new version of the device with idVendor=0bda, idProduct=8153 is 6010 and treating it as if it was a 5c30 allow it to work.

Error log:

Apr 19 09:55:13 devotron kernel: [  330.167074] usb 2-2.2: New USB
device found, idVendor=0bda, idProduct=8153
Apr 19 09:55:13 devotron kernel: [  330.167078] usb 2-2.2: New USB
device strings: Mfr=1, Product=2, SerialNumber=6
Apr 19 09:55:13 devotron kernel: [  330.167080] usb 2-2.2: Product: USB
10/100/1000 LAN
Apr 19 09:55:13 devotron kernel: [  330.167081] usb 2-2.2: Manufacturer:
Realtek
Apr 19 09:55:13 devotron kernel: [  330.167083] usb 2-2.2: SerialNumber:
001000001
Apr 19 09:55:13 devotron kernel: [  330.258781] usb 2-2.2: reset
SuperSpeed USB device number 5 using xhci_hcd
Apr 19 09:55:13 devotron kernel: [  330.279430] r8152 2-2.2:1.0 (unnamed
net_device) (uninitialized): Unknown version 0x6010
Apr 19 09:55:13 devotron kernel: [  330.279434] r8152 2-2.2:1.0 (unnamed
net_device) (uninitialized): Unknown Device

Signed-off-by: jake <jake@rabidtech.co.nz>
---
 drivers/net/usb/r8152.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 07f788c49d57..2a55459fdfac 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -4277,6 +4277,7 @@ static void r8152b_get_version(struct r8152 *tp)
 		tp->mii.supports_gmii = 1;
 		break;
 	case 0x5c30:
+	case 0x6010:	
 		tp->version = RTL_VER_06;
 		tp->mii.supports_gmii = 1;
 		break;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH] Fix for new version of realtek r8153
@ 2017-05-03  9:18   ` Hayes Wang
  0 siblings, 0 replies; 3+ messages in thread
From: Hayes Wang @ 2017-05-03  9:18 UTC (permalink / raw)
  To: jake Briggs, mario_limonciello, linux-usb, netdev, linux-kernel
  Cc: jake, nic_swsd

jake Briggs [mailto:nexussix@gmail.com]
> Sent: Wednesday, May 03, 2017 7:21 AM
[...]
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index 07f788c49d57..2a55459fdfac 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -4277,6 +4277,7 @@ static void r8152b_get_version(struct r8152 *tp)
>  		tp->mii.supports_gmii = 1;
>  		break;
>  	case 0x5c30:
> +	case 0x6010:

The two chips are different. I don't think it is a good idea.
Maybe you could use the driver from the Realtek website first.

>  		tp->version = RTL_VER_06;
>  		tp->mii.supports_gmii = 1;
>  		break;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] Fix for new version of realtek r8153
@ 2017-05-03  9:18   ` Hayes Wang
  0 siblings, 0 replies; 3+ messages in thread
From: Hayes Wang @ 2017-05-03  9:18 UTC (permalink / raw)
  To: jake Briggs, mario_limonciello-8PEkshWhKlo,
	linux-usb-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: jake, nic_swsd

jake Briggs [mailto:nexussix-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org]
> Sent: Wednesday, May 03, 2017 7:21 AM
[...]
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index 07f788c49d57..2a55459fdfac 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -4277,6 +4277,7 @@ static void r8152b_get_version(struct r8152 *tp)
>  		tp->mii.supports_gmii = 1;
>  		break;
>  	case 0x5c30:
> +	case 0x6010:

The two chips are different. I don't think it is a good idea.
Maybe you could use the driver from the Realtek website first.

>  		tp->version = RTL_VER_06;
>  		tp->mii.supports_gmii = 1;
>  		break;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-03  9:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-02 23:20 [PATCH] Fix for new version of realtek r8153 jake Briggs
2017-05-03  9:18 ` Hayes Wang
2017-05-03  9:18   ` Hayes Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.