All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] arm64: dts: ls1012a: add eSDHC nodes
Date: Wed, 3 May 2017 21:05:47 +0800	[thread overview]
Message-ID: <20170503130545.GB24392@dragon> (raw)
In-Reply-To: <1492746756-12024-4-git-send-email-yangbo.lu@nxp.com>

On Fri, Apr 21, 2017 at 11:52:36AM +0800, Yangbo Lu wrote:
> There are two eSDHC controllers in LS1012A. This patch is to add
> eSDHC nodes for ls1012a dts. Also enable eSDHC for RDB/QDS boards.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts |  8 ++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 13 ++++++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi    | 25 +++++++++++++++++++++++
>  3 files changed, 46 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> index e2a93d5..a21a587 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> @@ -130,3 +130,11 @@
>  &sata {
>  	status = "okay";
>  };
> +
> +&esdhc0 {
> +	status = "okay";
> +};
> +
> +&esdhc1 {
> +	status = "okay";
> +};

Sort these labeled nodes alphabetically.

> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> index ed77f6b..57669b0 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> @@ -61,3 +61,16 @@
>  &sata {
>  	status = "okay";
>  };
> +
> +&esdhc0 {
> +	sd-uhs-sdr104;
> +	sd-uhs-sdr50;
> +	sd-uhs-sdr25;
> +	sd-uhs-sdr12;
> +	status = "okay";
> +};
> +
> +&esdhc1 {
> +	mmc-hs200-1_8v;
> +	status = "okay";
> +};

Ditto

> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> index b497ac1..e3a1943 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> @@ -302,6 +302,31 @@
>  			};
>  		};
>  
> +		esdhc0: esdhc at 1560000 {

Sort the nodes in order of unit-address.

> +			compatible = "fsl,ls1012a-esdhc", "fsl,esdhc";

Please document the compatible.

Shawn

> +			reg = <0x0 0x1560000 0x0 0x10000>;
> +			interrupts = <0 62 0x4>;
> +			clocks = <&clockgen 4 0>;
> +			voltage-ranges = <1800 1800 3300 3300>;
> +			sdhci,auto-cmd12;
> +			big-endian;
> +			bus-width = <4>;
> +			status = "disabled";
> +		};
> +
> +		esdhc1: esdhc at 1580000 {
> +			compatible = "fsl,ls1012a-esdhc", "fsl,esdhc";
> +			reg = <0x0 0x1580000 0x0 0x10000>;
> +			interrupts = <0 65 0x4>;
> +			clocks = <&clockgen 4 0>;
> +			voltage-ranges = <1800 1800 3300 3300>;
> +			sdhci,auto-cmd12;
> +			big-endian;
> +			broken-cd;
> +			bus-width = <4>;
> +			status = "disabled";
> +		};
> +
>  		i2c0: i2c at 2180000 {
>  			compatible = "fsl,vf610-i2c";
>  			#address-cells = <1>;
> -- 
> 2.1.0.27.g96db324
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2017-05-03 13:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21  3:52 [PATCH 0/3] Add eSDHC UHS-I/HS200 mode support for ls1012a/ls1046a/ls208xa Yangbo Lu
2017-04-21  3:52 ` [PATCH 1/3] arm64: dts: ls1046a: support SD UHS-I and eMMC HS200 on RDB Yangbo Lu
2017-05-03 12:57   ` Shawn Guo
2017-05-04 10:44     ` Y.B. Lu
2017-04-21  3:52 ` [PATCH 2/3] arm64: dts: ls208xa: support SD UHS-I on RDB and eMMC HS200 on QDS Yangbo Lu
2017-04-21  3:52 ` [PATCH 3/3] arm64: dts: ls1012a: add eSDHC nodes Yangbo Lu
2017-05-03 13:05   ` Shawn Guo [this message]
2017-05-04 10:45     ` Y.B. Lu
2017-04-24 20:17 ` [PATCH 0/3] Add eSDHC UHS-I/HS200 mode support for ls1012a/ls1046a/ls208xa Ulf Hansson
2017-04-25  9:01   ` Y.B. Lu
2017-05-03 13:17     ` Shawn Guo
2017-05-03 13:14 ` Shawn Guo
2017-05-04 10:57   ` Y.B. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170503130545.GB24392@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.