From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liviu Dudau Subject: Re: [PATCH 1/3] drm: Plumb modifiers through plane init Date: Wed, 3 May 2017 15:07:29 +0100 Message-ID: <20170503140729.GJ28653@e110455-lin.cambridge.arm.com> References: <20170503051428.4734-1-ben@bwidawsk.net> <20170503103412.GH28653@e110455-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Stone Cc: Ben Widawsky , Intel GFX , DRI Development List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXkgMDMsIDIwMTcgYXQgMDI6NDU6MjZQTSArMDEwMCwgRGFuaWVsIFN0b25lIHdy b3RlOgo+IEhpIExpdml1LAo+IAo+IE9uIDMgTWF5IDIwMTcgYXQgMTE6MzQsIExpdml1IER1ZGF1 IDxMaXZpdS5EdWRhdUBhcm0uY29tPiB3cm90ZToKPiA+IE9uIFR1ZSwgTWF5IDAyLCAyMDE3IGF0 IDEwOjE0OjI2UE0gLTA3MDAsIEJlbiBXaWRhd3NreSB3cm90ZToKPiA+PiB2MjogQSBtaW5vciBh ZGRpdGlvbiBmcm9tIERhbmllbAo+ID4KPiA+IFlvdSBhcmUgKnJlYWxseSogcHVzaGluZyB5b3Vy IGx1Y2sgYnkgbm90IENjLWluZyAqYW55KiBvZiB0aGUgbWFpbnRhaW5lcnMgb2YKPiA+IHRoZSBk cml2ZXJzIHlvdSB0b3VjaC4gWW91IGRvIHdhbnQgcmV2aWV3cywgZG9uJ3QgeW91Pwo+IAo+IE91 Y2guIEknbSB2ZXJ5IHN1cmUgQmVuIGRvZXMgd2FudCByZXZpZXdzLCBidXQgaGUgbWFpbmx5IHdv cmtzIGluIE1lc2EKPiB3aGVyZSB5b3UgY2FuIHJlbHkgb24gdGhlIGxpc3QgcmF0aGVyIHRoYW4g aGF2aW5nIHRvIENDIGV2ZXJ5b25lCj4gaW5kaXZpZHVhbGx5LiBJdCB3YXMgYSBtaXN0YWtlLCBz byBwbGVhc2UgYmUgbW9yZSBnZW50bGUgd2l0aCBoaW07Cj4geW91ciB3aG9sZSBtYWlsIGNvbWVz IGFjcm9zcyBhcyBxdWl0ZSBob3N0aWxlIHRvIG1lLgoKU29ycnksIEknbSBub3QgdHJ5aW5nIHRv IGJlIGhvc3RpbGUuIFRyeSB0byByZWFkIHRoZSBib2xkZWQgd29yZHMgd2l0aCBhIGxvbmcKKHNv dXRoZXJuIFVTQSkgaW50b25hdGlvbiBhcyBpZiB0byBkcmF3IGF0dGVudGlvbiB0byB0aGVtLiBZ b3Ugd2lsbCBzZWUgdGhhdAppdCBpcyBqdXN0IHBvaW50aW5nIHRvIHR3byBmYWN0czogaGUgZG9l cyBub3Qgd2FybiBhbnlvbmUgYWJvdXQgdGhlIGNoYW5nZXMgYW5kCmhlIGlzIG5vdCBtYWtpbmcg dGhlIHBhdGNoc2V0IHRoYXQgb2J2aW91c2x5IGNyaXRpY2FsIGJ5IGhhdmluZyBhIGNvbW1pdCBt ZXNzYWdlCnRoYXQgaW1wbGllcyBldmVyeW9uZSBzaG91bGQgcGF5IGF0dGVudGlvbiB0byBpdC4g U28gaGUgaXMgcmVhbGx5IGhvcGluZyB0byBiZQpsdWNreSB0byBnZXQgcmV2aWV3cyAob3IgZG9l c24ndCBhY3RpdmVseSBzZWVrIHRoZW0pLgoKPiAKPiA+IEZpbmFsbHksIHRoZSBxdWVzdGlvbnMg SSBzaG91bGQndmUgc3RhcnRlZCB3aXRoOiB3aHkgdGhlIGNoYW5nZT8gV2hhdCBhcmUgeW91IHRy eWluZyB0bwo+ID4gYWNoaWV2ZT8gSXQgaXMgbm90IHZlcnkgY2xlYXIgZnJvbSB0aGUgY29tbWl0 IG1lc3NhZ2UgYXQgYWxsLgo+IAo+IEl0IGRvZXMgZGVzZXJ2ZSBhIG11Y2ggYmV0dGVyIGNvbW1p dCBtZXNzYWdlIHRoYW4gd2hhdCBpdCBoYXMsIGJ1dCBhcwo+IGhlIGlzIG9uIGhvbGlkYXkgZm9y IHRoZSByZXN0IG9mIHRoZSB3ZWVrLCBJIGNhbiBhbnN3ZXIuIEN1cnJlbnRseSwgd2UKPiBhZHZl cnRpc2Ugd2hpY2ggZm9ybWF0cyBlYWNoIHBsYW5lIGlzIGNhcGFibGUgb2YgZGlzcGxheWluZy4g SW4gb3JkZXIKPiBmb3IgdXNlcnNwYWNlIHRvIGJlIGFibGUgdG8gYWxsb2NhdGUgdGlsZWQvY29t cHJlc3NlZCBidWZmZXJzIGZvcgo+IHNjYW5vdXQsIHdlIHdhbnQgdXNlcnNwYWNlIHRvIGJlIGFi bGUgdG8gZGlzY292ZXIgd2hpY2ggbW9kaWZpZXJzIGVhY2gKPiBwbGFuZSBzdXBwb3J0cyBhcyB3 ZWxsLgoKSSBnZXQgdGhlIG92ZXJhbGwgZ29hbC4gV2UgbmVlZC93YW50IHNvbWV0aGluZyBzaW1p bGFyIGZvciBNYWxpIERQIGFuZCBBRkJDIGJ1ZmZlcnMuCldoYXQgSSBkb24ndCB1bmRlcnN0YW5k IGlzIHRoZSBjdXJyZW50IGFwcm9hY2ggKGJ1dCBJJ3ZlIGZvdW5kIGZyb20gQnJpYW4gdGhhdCBz b21laG93CkkndmUgbWlzc2VkIHRoZSBsb25nIGRpc2N1c3Npb24ocykgYXJvdW5kIHRoZSBzdWJq ZWN0KS4gSSB3YXMgaG9waW5nIHRvIGxlYXJuCmZyb20gdGhlIGNvbW1pdCBtZXNzYWdlIHdoeSBo ZSB0aGlua3MgdGhlIGludHJvZHVjdGlvbiBvZiB0aGlzIGNvZGUgaXMgdGhlIHJpZ2h0CndheSBv ZiBkb2luZyBpdC4gQW5kIHRoZSBJUkMgbG9ncyBzZWVtIHRvIGltcGx5IHRoYXQgaGUgaXMgbW9z dGx5IGRvaW5nIHNvbWV0aGluZwp0aGF0IG90aGVycyBoYXZlIGFncmVlZCB1cG9uIGFuZCBoZSBk b2Vzbid0IHJlYWxseSBjYXJlIGFib3V0IHRoZSBhcHByb2FjaCBhcyBsb25nCmFzIGl0IHRpY2tz IHRoZSAic3VwcG9ydGVkIGJ5IGludGVsIGRyaXZlciIgYm94LgoKPiAKPiA+PiBAQCAtMTA1LDYg KzEwOCwyOCBAQCBpbnQgZHJtX3VuaXZlcnNhbF9wbGFuZV9pbml0KHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsIHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ID4+ICAgICAgICAgICAgICAgcmV0dXJu IC1FTk9NRU07Cj4gPj4gICAgICAgfQo+ID4+Cj4gPj4gKyAgICAgLyogRmlyc3QgZHJpdmVyIHRv IG5lZWQgbW9yZSB0aGFuIDY0IGZvcm1hdHMgbmVlZHMgdG8gZml4IHRoaXMgKi8KPiA+PiArICAg ICBpZiAoV0FSTl9PTihmb3JtYXRfY291bnQgPiA2NCkpCj4gPj4gKyAgICAgICAgICAgICByZXR1 cm4gLUVJTlZBTDsKPiA+Cj4gPiBXaGF0IGlzIHRoZSBsaW5rIGJldHdlZW4gZm9ybWF0X2NvdW50 IGFuZCBmb3JtYXQgbW9kaWZpZXJzPyBXaHkgYXJlIHlvdSBpbnRyb2R1Y2luZwo+ID4gdGhpcyBh cnRpZmljaWFsIHJlc3RyaWN0aW9uIG9uIHRoZSBmb3JtYXRfY291bnQ/IEFsc28sIHRoZXJlIGRv ZXNuJ3Qgc2VlbSB0byBiZSBhbnkKPiA+IGNoZWNrIGlmIGZvcm1hdF9tb2RpZmllcl9jb3VudCA9 PSBmb3JtYXRfY291bnQuIFdoYXQgaGFwcGVucyB3aGVuIHRoZXkgZG9uJ3QgbWF0Y2g/Cj4gCj4g SW5zaWRlIHRoZSBibG9iLCBlYWNoIG1vZGlmaWVyIGNhcnJpZXMgYSBiaXRtYXNrIG9mIGZvcm1h dHMgKHNwZWNpZmllZAo+IGJ5IGluZGV4KSB0aGF0IHRoZSBtb2RpZmllciBhcHBsaWVzIHRvLCBp LmUuIHdpdGg6Cj4gICAuZm9ybWF0cyA9IHsgQVJHQjg4ODgsIFhSR0I4ODg4LCBSR0I1NjUgfSwK PiAKPiBhIG1vZGlmaWVyIHdoaWNoIGFwcGxpZWQgb25seSB0byB0aGUgMzItYml0IGZvcm1hdHMg d291bGQgc3BlY2lmeSBhCj4gYml0bWFzayBvZiAweDMuIFRoZSB1QUJJIHN1cHBvcnRzIHRoaXMg anVzdCBmaW5lLCBidXQgdGhlIGludGVybmFsCj4gcGx1bWJpbmcgZG9lcyBub3QgeWV0LCBiZWNh dXNlIG5vLW9uZSBzdXBwb3J0cyBtb3JlIHRoYW4gNjQgZm9ybWF0cy4KClllYWgsIHN0aWxsIGRv ZXNuJ3QgYW5zd2VyIHRoZSBxdWVzdGlvbi4gTWF5YmUgaWYgdGhlIGNvbW1lbnQgc2FpZCBzb21l dGhpbmcgbGlrZToKIldoZW4gYnVpbGRpbmcgZm9ybWF0IG1vZGlmaWVycyBiaXRtYXAgd2Ugb25s eSBoYXZlIHNwYWNlIHRvIG1hcCB1cCB0byA2NCBmb3JtYXRzLgpDaGVjayB0aGF0IHRoZSBkcml2 ZXIgaXMgbm90IHRyeWluZyB0byBleGNlZWQgdGhhdC4iIHRoZW4gaXQgd291bGQndmUgYmVlbiBt b3JlCm9idmlvdXMgd2h5IHRoZSBjaGVjayBpcyBuZWVkZWQgYW5kIGFsc28gd2h5IG9uZSBkb2Vz bid0IGNhcmUgYWJvdXQgZm9ybWF0X21vZGlmaWVyX2NvdW50LgoKVG8gZXhwbGFpbiBteSBtaW5k c2V0OiB0aGUgd2F5IHRoZSBwYXRjaCBzZXJpZXMgd2FzIGZvcm1hdHRlZCBhbmQgdGhlIHdheSBJ J3ZlIHJlYWQgaXQKaW5pdGlhbGx5IEkgZGlkIG5vdCByZWFsaXNlZCB0aGF0IHRoZSBpZGVhIGlz IHRvIGJ1aWxkIGEgYml0bWFzay4gTm90aGluZyBpbiB0aGlzIHBhdGNoCmFsbHVkZXMgdG8gdGhh dCBzbyBJIGFzc3VtZWQgdGhlcmUgd2FzIGEgMToxIHJlbGF0aW9uc2hpcCBiZXR3ZWVuIGZvcm1h dCBtb2RpZmllcnMgYW5kCmZvcm1hdC4KCj4gCj4gPj4gKwo+ID4+ICsgICAgIGlmIChmb3JtYXRf bW9kaWZpZXJzKSB7Cj4gPj4gKyAgICAgICAgICAgICBjb25zdCB1aW50NjRfdCAqdGVtcF9tb2Rp ZmllcnMgPSBmb3JtYXRfbW9kaWZpZXJzOwo+ID4+ICsgICAgICAgICAgICAgd2hpbGUgKCp0ZW1w X21vZGlmaWVycysrICE9IERSTV9GT1JNQVRfTU9EX0lOVkFMSUQpCj4gPj4gKyAgICAgICAgICAg ICAgICAgICAgIGZvcm1hdF9tb2RpZmllcl9jb3VudCsrOwo+ID4+ICsgICAgIH0KPiA+PiArCj4g Pj4gKyAgICAgcGxhbmUtPm1vZGlmaWVyX2NvdW50ID0gZm9ybWF0X21vZGlmaWVyX2NvdW50Owo+ ID4KPiA+IFdoeSBkbyB5b3UgbmVlZCB0byByZW1lbWJlciB0aGlzPyBJdCBpcyBub3QgdXNlZCBh bnl3aGVyZSBlbHNlIQo+IAo+IEl0IGlzIHVzZWQgdG8gcG9wdWxhdGUgdGhlIGJsb2IgaW4gYSBs YXRlciBwYXRjaCEKCkkgY2Fubm90IGZpbmQgdGhhdCBwYXRjaC4gTm90aGluZyBpbiB0aGUgMyBw YXRjaGVzIHVzZXMgdGhhdC4gSGF2ZSBhIGxvb2shCgpCZXN0IHJlZ2FyZHMsCkxpdml1Cgo+IAo+ IENoZWVycywKPiBEYW5pZWwKCi0tIAo9PT09PT09PT09PT09PT09PT09PQp8IEkgd291bGQgbGlr ZSB0byB8CnwgZml4IHRoZSB3b3JsZCwgIHwKfCBidXQgdGhleSdyZSBub3QgfAp8IGdpdmluZyBt ZSB0aGUgICB8CiBcIHNvdXJjZSBjb2RlISAgLwogIC0tLS0tLS0tLS0tLS0tLQogICAgwq9cXyjj g4QpXy/CrwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK