From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752757AbdECOPo (ORCPT ); Wed, 3 May 2017 10:15:44 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34223 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbdECOPg (ORCPT ); Wed, 3 May 2017 10:15:36 -0400 Date: Wed, 3 May 2017 16:15:33 +0200 From: Jiri Pirko To: Colin King Cc: Jamal Hadi Salim , Cong Wang , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, "David S . Miller" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/sched: remove redundant null check on head Message-ID: <20170503141533.GC2077@nanopsycho.orion> References: <20170503135040.32023-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170503135040.32023-1-colin.king@canonical.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wed, May 03, 2017 at 03:50:40PM CEST, colin.king@canonical.com wrote: >From: Colin Ian King > >head is previously null checked and so the 2nd null check on head >is redundant and therefore can be removed. > >Detected by CoverityScan, CID#1399505 ("Logically dead code") > >Signed-off-by: Colin Ian King Acked-by: Jiri Pirko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Date: Wed, 03 May 2017 14:15:33 +0000 Subject: Re: [PATCH] net/sched: remove redundant null check on head Message-Id: <20170503141533.GC2077@nanopsycho.orion> List-Id: References: <20170503135040.32023-1-colin.king@canonical.com> In-Reply-To: <20170503135040.32023-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Jamal Hadi Salim , Cong Wang , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, "David S . Miller" , linux-kernel@vger.kernel.org Wed, May 03, 2017 at 03:50:40PM CEST, colin.king@canonical.com wrote: >From: Colin Ian King > >head is previously null checked and so the 2nd null check on head >is redundant and therefore can be removed. > >Detected by CoverityScan, CID#1399505 ("Logically dead code") > >Signed-off-by: Colin Ian King Acked-by: Jiri Pirko