From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752450AbdECPVk (ORCPT ); Wed, 3 May 2017 11:21:40 -0400 Received: from mga11.intel.com ([192.55.52.93]:7809 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbdECPVe (ORCPT ); Wed, 3 May 2017 11:21:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,284,1491289200"; d="scan'208";a="852460522" Date: Wed, 3 May 2017 18:21:29 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jose Abreu , dri-devel , Linux Kernel Mailing List , Carlos Palminha , Alexey Brodkin , Dave Airlie Subject: Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Message-ID: <20170503152129.GO12629@intel.com> References: <3e1dba0cd5fc053e56f1c9c94d0cb8789ecca4ae.1493203049.git.joabreu@synopsys.com> <20170502084807.k7ioo7a5j33xtnpj@phenom.ffwll.local> <80752cfe-4bc7-b7c6-c29b-e634c356a509@synopsys.com> <9edb415e-4d0b-5a2a-a735-0dbb98d77984@synopsys.com> <20170503150031.rpd5xs2bb67mpsnc@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170503150031.rpd5xs2bb67mpsnc@phenom.ffwll.local> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 03, 2017 at 05:00:31PM +0200, Daniel Vetter wrote: > On Wed, May 03, 2017 at 03:16:13PM +0100, Jose Abreu wrote: > > Hi Daniel, > > > > > > On 03-05-2017 07:19, Daniel Vetter wrote: > > > On Tue, May 2, 2017 at 11:29 AM, Jose Abreu wrote: > > >> On 02-05-2017 09:48, Daniel Vetter wrote: > > >>> On Wed, Apr 26, 2017 at 11:48:34AM +0100, Jose Abreu wrote: > > >>>> Some crtc's may have restrictions in the mode they can display. In > > >>>> this patch a new callback (crtc->mode_valid()) is introduced that > > >>>> is called at the same stage of connector->mode_valid() callback. > > >>>> > > >>>> This shall be implemented if the crtc has some sort of restriction > > >>>> so that we don't probe modes that will fail in the commit() stage. > > >>>> For example: A given crtc may be responsible to set a clock value. > > >>>> If the clock can not produce all the values for the available > > >>>> modes then this callback can be used to restrict the number of > > >>>> probbed modes to only the ones that can be displayed. > > >>>> > > >>>> If the crtc does not implement the callback then the behaviour will > > >>>> remain the same. Also, for a given set of crtcs that can be bound to > > >>>> the connector, if at least one can display the mode then the mode > > >>>> will be probbed. > > >>>> > > >>>> Signed-off-by: Jose Abreu > > >>>> Cc: Carlos Palminha > > >>>> Cc: Alexey Brodkin > > >>>> Cc: Ville Syrjälä > > >>>> Cc: Daniel Vetter > > >>>> Cc: Dave Airlie > > >>> Not sure this is useful, since you still have to duplicate the exact same > > >>> check into your ->mode_fixup hook. That seems to make things even more > > >>> confusing. > > >> Yeah, in arcpgu I had to duplicate the code in ->atomic_check. > > >> > > >>> Also this doesn't update the various kerneldoc comments. For the existing > > >>> hooks. Since this topic causes so much confusion, I don't think a > > >>> half-solution will help, but has some good potential to make things worse. > > >> I only documented the callback in drm_modeset_helper_vtables.h. > > >> > > >> Despite all of this, I think it doesn't makes sense delivering > > >> modes to userspace which can never be used. > > >> > > >> This is really annoying in arcpgu. Imagine: I try to use mpv to > > >> play a video, the full set of modes from EDID were probed so if I > > >> just start mpv it will pick the native mode of the TV instead of > > >> the one that is supported, so mpv will fail to play. I know the > > >> value of clock which will work (so I know what mode shall be > > >> used), but a normal user which is not aware of the HW will have > > >> to cycle through the list of modes and try them all until it hits > > >> one that works. Its really boring. > > >> > > >> For the modes that user specifies manually there is nothing we > > >> can do, but we should not trick users into thinking that a given > > >> mode is supported when it will always fail at commit. > > > Yes, you are supposed to filter these out in ->mode_valid. But my > > > stance is that only adding a half-baked support for a new callback to > > > the core isn't going to make life easier for drivers, it will just add > > > to the confusion. There's already piles of docs for both @mode_valid > > > and @mode_fixup hooks explaining this, I don't want to make the > > > documentation even more complex. And half-baked crtc checking is > > > _much_ easier to implement in the driver directly (e.g. i915 checks > > > for crtc constraints since forever, as do the other big x86 drivers). > > > > But i915 crtc checks are done after handing the mode to > > userspace, arcpgu also does that. We must let users specify > > manually a mode but there is no point in returning modes in > > get_connector which will always fail to commit. I get your point > > and this can lead to code duplication, but I don't think it will > > lead to confusion as long as it is well documented. And besides, > > the callback is completely optional. > > Look closer, e.g. intel_dp_mode_valid calls > intel_dp_downstream_max_dotclock which also looks at > dev_priv->max_dotclkc_freq (which is the source dotclk limit, yeah it's a > misnamed function). > > And the max dotclk is very much a crtc limit, not a port limit. Note that > a bunch of other ports have port limits which are guaranteed to be lower > than the crtc limit, hence the absence of the checks. > > > > So all taken together, if we add a ->mode_valid to crtcs, then imo we > > > should do it right and actually make life easier for drivers. A good > > > proof would be if your patch would allow us to drop a lot of the > > > lenghty language from the @mode_valid hooks. > > > > I completely agree that it should make life easier for drivers > > but unfortunately I don't really see how :/ > > > > So, in summary: > > Disadvantage 1: Code duplication > > Disadvantage 2: Confusing documentation can lead to callback > > misuse > > > > Advantage 1: User will get life simpler > > Ok, let me try to explain a bit in more detail what I think would be a > real improvement: > - Add ->mode_valid checks to all the places where we currently have > ->mode_fixup. That'd be crtc, encoder and bridges. > > - Pimp the probe helper code to go through all of the combinations, > filtering out those that aren't allowed by possible_* masks (essentially > do the same thing that userspace is supposed to do). > > - Call all these ->mode_valid checks from the atomic check functions (I > think we can forget about the legacy crtc helpers for old drivers). Do > this also for connector->mode_valid. > > Taken all together this gives us the guarantee that that any mode which > fails the check in the probe path is guaranteed to never pass in an atomic > commit. We don't actually want the codepaths to match exactly. In i915 we allow the user to exceed some of the display/dongle limits because those things often tell us that something shouldn't work when in fact it does. And some users are quick to complain if something stops working for them. -- Ville Syrjälä Intel OTC From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Date: Wed, 3 May 2017 18:21:29 +0300 Message-ID: <20170503152129.GO12629@intel.com> References: <3e1dba0cd5fc053e56f1c9c94d0cb8789ecca4ae.1493203049.git.joabreu@synopsys.com> <20170502084807.k7ioo7a5j33xtnpj@phenom.ffwll.local> <80752cfe-4bc7-b7c6-c29b-e634c356a509@synopsys.com> <9edb415e-4d0b-5a2a-a735-0dbb98d77984@synopsys.com> <20170503150031.rpd5xs2bb67mpsnc@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id AEE4289DF9 for ; Wed, 3 May 2017 15:21:34 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170503150031.rpd5xs2bb67mpsnc@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jose Abreu , dri-devel , Linux Kernel Mailing List , Carlos Palminha , Alexey Brodkin , Dave Airlie List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXkgMDMsIDIwMTcgYXQgMDU6MDA6MzFQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBXZWQsIE1heSAwMywgMjAxNyBhdCAwMzoxNjoxM1BNICswMTAwLCBKb3NlIEFi cmV1IHdyb3RlOgo+ID4gSGkgRGFuaWVsLAo+ID4gCj4gPiAKPiA+IE9uIDAzLTA1LTIwMTcgMDc6 MTksIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiA+IE9uIFR1ZSwgTWF5IDIsIDIwMTcgYXQgMTE6 MjkgQU0sIEpvc2UgQWJyZXUgPEpvc2UuQWJyZXVAc3lub3BzeXMuY29tPiB3cm90ZToKPiA+ID4+ IE9uIDAyLTA1LTIwMTcgMDk6NDgsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiA+Pj4gT24gV2Vk LCBBcHIgMjYsIDIwMTcgYXQgMTE6NDg6MzRBTSArMDEwMCwgSm9zZSBBYnJldSB3cm90ZToKPiA+ ID4+Pj4gU29tZSBjcnRjJ3MgbWF5IGhhdmUgcmVzdHJpY3Rpb25zIGluIHRoZSBtb2RlIHRoZXkg Y2FuIGRpc3BsYXkuIEluCj4gPiA+Pj4+IHRoaXMgcGF0Y2ggYSBuZXcgY2FsbGJhY2sgKGNydGMt Pm1vZGVfdmFsaWQoKSkgaXMgaW50cm9kdWNlZCB0aGF0Cj4gPiA+Pj4+IGlzIGNhbGxlZCBhdCB0 aGUgc2FtZSBzdGFnZSBvZiBjb25uZWN0b3ItPm1vZGVfdmFsaWQoKSBjYWxsYmFjay4KPiA+ID4+ Pj4KPiA+ID4+Pj4gVGhpcyBzaGFsbCBiZSBpbXBsZW1lbnRlZCBpZiB0aGUgY3J0YyBoYXMgc29t ZSBzb3J0IG9mIHJlc3RyaWN0aW9uCj4gPiA+Pj4+IHNvIHRoYXQgd2UgZG9uJ3QgcHJvYmUgbW9k ZXMgdGhhdCB3aWxsIGZhaWwgaW4gdGhlIGNvbW1pdCgpIHN0YWdlLgo+ID4gPj4+PiBGb3IgZXhh bXBsZTogQSBnaXZlbiBjcnRjIG1heSBiZSByZXNwb25zaWJsZSB0byBzZXQgYSBjbG9jayB2YWx1 ZS4KPiA+ID4+Pj4gSWYgdGhlIGNsb2NrIGNhbiBub3QgcHJvZHVjZSBhbGwgdGhlIHZhbHVlcyBm b3IgdGhlIGF2YWlsYWJsZQo+ID4gPj4+PiBtb2RlcyB0aGVuIHRoaXMgY2FsbGJhY2sgY2FuIGJl IHVzZWQgdG8gcmVzdHJpY3QgdGhlIG51bWJlciBvZgo+ID4gPj4+PiBwcm9iYmVkIG1vZGVzIHRv IG9ubHkgdGhlIG9uZXMgdGhhdCBjYW4gYmUgZGlzcGxheWVkLgo+ID4gPj4+Pgo+ID4gPj4+PiBJ ZiB0aGUgY3J0YyBkb2VzIG5vdCBpbXBsZW1lbnQgdGhlIGNhbGxiYWNrIHRoZW4gdGhlIGJlaGF2 aW91ciB3aWxsCj4gPiA+Pj4+IHJlbWFpbiB0aGUgc2FtZS4gQWxzbywgZm9yIGEgZ2l2ZW4gc2V0 IG9mIGNydGNzIHRoYXQgY2FuIGJlIGJvdW5kIHRvCj4gPiA+Pj4+IHRoZSBjb25uZWN0b3IsIGlm IGF0IGxlYXN0IG9uZSBjYW4gZGlzcGxheSB0aGUgbW9kZSB0aGVuIHRoZSBtb2RlCj4gPiA+Pj4+ IHdpbGwgYmUgcHJvYmJlZC4KPiA+ID4+Pj4KPiA+ID4+Pj4gU2lnbmVkLW9mZi1ieTogSm9zZSBB YnJldSA8am9hYnJldUBzeW5vcHN5cy5jb20+Cj4gPiA+Pj4+IENjOiBDYXJsb3MgUGFsbWluaGEg PHBhbG1pbmhhQHN5bm9wc3lzLmNvbT4KPiA+ID4+Pj4gQ2M6IEFsZXhleSBCcm9ka2luIDxhYnJv ZGtpbkBzeW5vcHN5cy5jb20+Cj4gPiA+Pj4+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPj4+PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4KPiA+ID4+Pj4gQ2M6IERhdmUgQWlybGllIDxhaXJsaWVkQGxpbnV4 LmllPgo+ID4gPj4+IE5vdCBzdXJlIHRoaXMgaXMgdXNlZnVsLCBzaW5jZSB5b3Ugc3RpbGwgaGF2 ZSB0byBkdXBsaWNhdGUgdGhlIGV4YWN0IHNhbWUKPiA+ID4+PiBjaGVjayBpbnRvIHlvdXIgLT5t b2RlX2ZpeHVwIGhvb2suIFRoYXQgc2VlbXMgdG8gbWFrZSB0aGluZ3MgZXZlbiBtb3JlCj4gPiA+ Pj4gY29uZnVzaW5nLgo+ID4gPj4gWWVhaCwgaW4gYXJjcGd1IEkgaGFkIHRvIGR1cGxpY2F0ZSB0 aGUgY29kZSBpbiAtPmF0b21pY19jaGVjay4KPiA+ID4+Cj4gPiA+Pj4gQWxzbyB0aGlzIGRvZXNu J3QgdXBkYXRlIHRoZSB2YXJpb3VzIGtlcm5lbGRvYyBjb21tZW50cy4gRm9yIHRoZSBleGlzdGlu Zwo+ID4gPj4+IGhvb2tzLiBTaW5jZSB0aGlzIHRvcGljIGNhdXNlcyBzbyBtdWNoIGNvbmZ1c2lv biwgSSBkb24ndCB0aGluayBhCj4gPiA+Pj4gaGFsZi1zb2x1dGlvbiB3aWxsIGhlbHAsIGJ1dCBo YXMgc29tZSBnb29kIHBvdGVudGlhbCB0byBtYWtlIHRoaW5ncyB3b3JzZS4KPiA+ID4+IEkgb25s eSBkb2N1bWVudGVkIHRoZSBjYWxsYmFjayBpbiBkcm1fbW9kZXNldF9oZWxwZXJfdnRhYmxlcy5o Lgo+ID4gPj4KPiA+ID4+IERlc3BpdGUgYWxsIG9mIHRoaXMsIEkgdGhpbmsgaXQgZG9lc24ndCBt YWtlcyBzZW5zZSBkZWxpdmVyaW5nCj4gPiA+PiBtb2RlcyB0byB1c2Vyc3BhY2Ugd2hpY2ggY2Fu IG5ldmVyIGJlIHVzZWQuCj4gPiA+Pgo+ID4gPj4gVGhpcyBpcyByZWFsbHkgYW5ub3lpbmcgaW4g YXJjcGd1LiBJbWFnaW5lOiBJIHRyeSB0byB1c2UgbXB2IHRvCj4gPiA+PiBwbGF5IGEgdmlkZW8s IHRoZSBmdWxsIHNldCBvZiBtb2RlcyBmcm9tIEVESUQgd2VyZSBwcm9iZWQgc28gaWYgSQo+ID4g Pj4ganVzdCBzdGFydCBtcHYgaXQgd2lsbCBwaWNrIHRoZSBuYXRpdmUgbW9kZSBvZiB0aGUgVFYg aW5zdGVhZCBvZgo+ID4gPj4gdGhlIG9uZSB0aGF0IGlzIHN1cHBvcnRlZCwgc28gbXB2IHdpbGwg ZmFpbCB0byBwbGF5LiBJIGtub3cgdGhlCj4gPiA+PiB2YWx1ZSBvZiBjbG9jayB3aGljaCB3aWxs IHdvcmsgKHNvIEkga25vdyB3aGF0IG1vZGUgc2hhbGwgYmUKPiA+ID4+IHVzZWQpLCBidXQgYSBu b3JtYWwgdXNlciB3aGljaCBpcyBub3QgYXdhcmUgb2YgdGhlIEhXIHdpbGwgaGF2ZQo+ID4gPj4g dG8gY3ljbGUgdGhyb3VnaCB0aGUgbGlzdCBvZiBtb2RlcyBhbmQgdHJ5IHRoZW0gYWxsIHVudGls IGl0IGhpdHMKPiA+ID4+IG9uZSB0aGF0IHdvcmtzLiBJdHMgcmVhbGx5IGJvcmluZy4KPiA+ID4+ Cj4gPiA+PiBGb3IgdGhlIG1vZGVzIHRoYXQgdXNlciBzcGVjaWZpZXMgbWFudWFsbHkgdGhlcmUg aXMgbm90aGluZyB3ZQo+ID4gPj4gY2FuIGRvLCBidXQgd2Ugc2hvdWxkIG5vdCB0cmljayB1c2Vy cyBpbnRvIHRoaW5raW5nIHRoYXQgYSBnaXZlbgo+ID4gPj4gbW9kZSBpcyBzdXBwb3J0ZWQgd2hl biBpdCB3aWxsIGFsd2F5cyBmYWlsIGF0IGNvbW1pdC4KPiA+ID4gWWVzLCB5b3UgYXJlIHN1cHBv c2VkIHRvIGZpbHRlciB0aGVzZSBvdXQgaW4gLT5tb2RlX3ZhbGlkLiBCdXQgbXkKPiA+ID4gc3Rh bmNlIGlzIHRoYXQgb25seSBhZGRpbmcgYSBoYWxmLWJha2VkIHN1cHBvcnQgZm9yIGEgbmV3IGNh bGxiYWNrIHRvCj4gPiA+IHRoZSBjb3JlIGlzbid0IGdvaW5nIHRvIG1ha2UgbGlmZSBlYXNpZXIg Zm9yIGRyaXZlcnMsIGl0IHdpbGwganVzdCBhZGQKPiA+ID4gdG8gdGhlIGNvbmZ1c2lvbi4gVGhl cmUncyBhbHJlYWR5IHBpbGVzIG9mIGRvY3MgZm9yIGJvdGggQG1vZGVfdmFsaWQKPiA+ID4gYW5k IEBtb2RlX2ZpeHVwIGhvb2tzIGV4cGxhaW5pbmcgdGhpcywgSSBkb24ndCB3YW50IHRvIG1ha2Ug dGhlCj4gPiA+IGRvY3VtZW50YXRpb24gZXZlbiBtb3JlIGNvbXBsZXguIEFuZCBoYWxmLWJha2Vk IGNydGMgY2hlY2tpbmcgaXMKPiA+ID4gX211Y2hfIGVhc2llciB0byBpbXBsZW1lbnQgaW4gdGhl IGRyaXZlciBkaXJlY3RseSAoZS5nLiBpOTE1IGNoZWNrcwo+ID4gPiBmb3IgY3J0YyBjb25zdHJh aW50cyBzaW5jZSBmb3JldmVyLCBhcyBkbyB0aGUgb3RoZXIgYmlnIHg4NiBkcml2ZXJzKS4KPiA+ IAo+ID4gQnV0IGk5MTUgY3J0YyBjaGVja3MgYXJlIGRvbmUgYWZ0ZXIgaGFuZGluZyB0aGUgbW9k ZSB0bwo+ID4gdXNlcnNwYWNlLCBhcmNwZ3UgYWxzbyBkb2VzIHRoYXQuIFdlIG11c3QgbGV0IHVz ZXJzIHNwZWNpZnkKPiA+IG1hbnVhbGx5IGEgbW9kZSBidXQgdGhlcmUgaXMgbm8gcG9pbnQgaW4g cmV0dXJuaW5nIG1vZGVzIGluCj4gPiBnZXRfY29ubmVjdG9yIHdoaWNoIHdpbGwgYWx3YXlzIGZh aWwgdG8gY29tbWl0LiBJIGdldCB5b3VyIHBvaW50Cj4gPiBhbmQgdGhpcyBjYW4gbGVhZCB0byBj b2RlIGR1cGxpY2F0aW9uLCBidXQgSSBkb24ndCB0aGluayBpdCB3aWxsCj4gPiBsZWFkIHRvIGNv bmZ1c2lvbiBhcyBsb25nIGFzIGl0IGlzIHdlbGwgZG9jdW1lbnRlZC4gQW5kIGJlc2lkZXMsCj4g PiB0aGUgY2FsbGJhY2sgaXMgY29tcGxldGVseSBvcHRpb25hbC4KPiAKPiBMb29rIGNsb3Nlciwg ZS5nLiBpbnRlbF9kcF9tb2RlX3ZhbGlkIGNhbGxzCj4gaW50ZWxfZHBfZG93bnN0cmVhbV9tYXhf ZG90Y2xvY2sgd2hpY2ggYWxzbyBsb29rcyBhdAo+IGRldl9wcml2LT5tYXhfZG90Y2xrY19mcmVx ICh3aGljaCBpcyB0aGUgc291cmNlIGRvdGNsayBsaW1pdCwgeWVhaCBpdCdzIGEKPiBtaXNuYW1l ZCBmdW5jdGlvbikuCj4gCj4gQW5kIHRoZSBtYXggZG90Y2xrIGlzIHZlcnkgbXVjaCBhIGNydGMg bGltaXQsIG5vdCBhIHBvcnQgbGltaXQuIE5vdGUgdGhhdAo+IGEgYnVuY2ggb2Ygb3RoZXIgcG9y dHMgaGF2ZSBwb3J0IGxpbWl0cyB3aGljaCBhcmUgZ3VhcmFudGVlZCB0byBiZSBsb3dlcgo+IHRo YW4gdGhlIGNydGMgbGltaXQsIGhlbmNlIHRoZSBhYnNlbmNlIG9mIHRoZSBjaGVja3MuCj4gCj4g PiA+IFNvIGFsbCB0YWtlbiB0b2dldGhlciwgaWYgd2UgYWRkIGEgLT5tb2RlX3ZhbGlkIHRvIGNy dGNzLCB0aGVuIGltbyB3ZQo+ID4gPiBzaG91bGQgZG8gaXQgcmlnaHQgYW5kIGFjdHVhbGx5IG1h a2UgbGlmZSBlYXNpZXIgZm9yIGRyaXZlcnMuIEEgZ29vZAo+ID4gPiBwcm9vZiB3b3VsZCBiZSBp ZiB5b3VyIHBhdGNoIHdvdWxkIGFsbG93IHVzIHRvIGRyb3AgYSBsb3Qgb2YgdGhlCj4gPiA+IGxl bmdodHkgbGFuZ3VhZ2UgZnJvbSB0aGUgQG1vZGVfdmFsaWQgaG9va3MuCj4gPiAKPiA+IEkgY29t cGxldGVseSBhZ3JlZSB0aGF0IGl0IHNob3VsZCBtYWtlIGxpZmUgZWFzaWVyIGZvciBkcml2ZXJz Cj4gPiBidXQgdW5mb3J0dW5hdGVseSBJIGRvbid0IHJlYWxseSBzZWUgaG93IDovCj4gPiAKPiA+ IFNvLCBpbiBzdW1tYXJ5Ogo+ID4gICAgIERpc2FkdmFudGFnZSAxOiBDb2RlIGR1cGxpY2F0aW9u Cj4gPiAgICAgRGlzYWR2YW50YWdlIDI6IENvbmZ1c2luZyBkb2N1bWVudGF0aW9uIGNhbiBsZWFk IHRvIGNhbGxiYWNrCj4gPiBtaXN1c2UKPiA+IAo+ID4gICAgIEFkdmFudGFnZSAxOiBVc2VyIHdp bGwgZ2V0IGxpZmUgc2ltcGxlcgo+IAo+IE9rLCBsZXQgbWUgdHJ5IHRvIGV4cGxhaW4gYSBiaXQg aW4gbW9yZSBkZXRhaWwgd2hhdCBJIHRoaW5rIHdvdWxkIGJlIGEKPiByZWFsIGltcHJvdmVtZW50 Ogo+IC0gQWRkIC0+bW9kZV92YWxpZCBjaGVja3MgdG8gYWxsIHRoZSBwbGFjZXMgd2hlcmUgd2Ug Y3VycmVudGx5IGhhdmUKPiAgIC0+bW9kZV9maXh1cC4gVGhhdCdkIGJlIGNydGMsIGVuY29kZXIg YW5kIGJyaWRnZXMuCj4gCj4gLSBQaW1wIHRoZSBwcm9iZSBoZWxwZXIgY29kZSB0byBnbyB0aHJv dWdoIGFsbCBvZiB0aGUgY29tYmluYXRpb25zLAo+ICAgZmlsdGVyaW5nIG91dCB0aG9zZSB0aGF0 IGFyZW4ndCBhbGxvd2VkIGJ5IHBvc3NpYmxlXyogbWFza3MgKGVzc2VudGlhbGx5Cj4gICBkbyB0 aGUgc2FtZSB0aGluZyB0aGF0IHVzZXJzcGFjZSBpcyBzdXBwb3NlZCB0byBkbykuCj4gCj4gLSBD YWxsIGFsbCB0aGVzZSAtPm1vZGVfdmFsaWQgY2hlY2tzIGZyb20gdGhlIGF0b21pYyBjaGVjayBm dW5jdGlvbnMgKEkKPiAgIHRoaW5rIHdlIGNhbiBmb3JnZXQgYWJvdXQgdGhlIGxlZ2FjeSBjcnRj IGhlbHBlcnMgZm9yIG9sZCBkcml2ZXJzKS4gRG8KPiAgIHRoaXMgYWxzbyBmb3IgY29ubmVjdG9y LT5tb2RlX3ZhbGlkLgo+IAo+IFRha2VuIGFsbCB0b2dldGhlciB0aGlzIGdpdmVzIHVzIHRoZSBn dWFyYW50ZWUgdGhhdCB0aGF0IGFueSBtb2RlIHdoaWNoCj4gZmFpbHMgdGhlIGNoZWNrIGluIHRo ZSBwcm9iZSBwYXRoIGlzIGd1YXJhbnRlZWQgdG8gbmV2ZXIgcGFzcyBpbiBhbiBhdG9taWMKPiBj b21taXQuCgpXZSBkb24ndCBhY3R1YWxseSB3YW50IHRoZSBjb2RlcGF0aHMgdG8gbWF0Y2ggZXhh Y3RseS4gSW4gaTkxNQp3ZSBhbGxvdyB0aGUgdXNlciB0byBleGNlZWQgc29tZSBvZiB0aGUgZGlz cGxheS9kb25nbGUgbGltaXRzCmJlY2F1c2UgdGhvc2UgdGhpbmdzIG9mdGVuIHRlbGwgdXMgdGhh dCBzb21ldGhpbmcgc2hvdWxkbid0IHdvcmsKd2hlbiBpbiBmYWN0IGl0IGRvZXMuIEFuZCBzb21l IHVzZXJzIGFyZSBxdWljayB0byBjb21wbGFpbiBpZgpzb21ldGhpbmcgc3RvcHMgd29ya2luZyBm b3IgdGhlbS4KCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=