From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6116-0002f9-JL for qemu-devel@nongnu.org; Wed, 03 May 2017 16:36:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6115-0002L7-PC for qemu-devel@nongnu.org; Wed, 03 May 2017 16:36:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59028) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d6115-0002Jv-JA for qemu-devel@nongnu.org; Wed, 03 May 2017 16:36:55 -0400 From: Eduardo Habkost Date: Wed, 3 May 2017 17:35:52 -0300 Message-Id: <20170503203604.31462-10-ehabkost@redhat.com> In-Reply-To: <20170503203604.31462-1-ehabkost@redhat.com> References: <20170503203604.31462-1-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH RESEND v2 09/21] kvmvapic: Remove user_creatable flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Laszlo Ersek , Thomas Huth , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Peter Maydell , Igor Mammedov , Paolo Bonzini , Richard Henderson , "Michael S. Tsirkin" The kvmvapic device is only usable when created by apic_common_realize(), not using -device. Remove the user_creatable flag from the device class. Cc: Igor Mammedov Cc: Marcel Apfelbaum Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: "Michael S. Tsirkin" Acked-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Commit message rewrite only --- hw/i386/kvmvapic.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c index 45f6267c93..82a49556af 100644 --- a/hw/i386/kvmvapic.c +++ b/hw/i386/kvmvapic.c @@ -856,11 +856,6 @@ static void vapic_class_init(ObjectClass *klass, void *data) dc->reset = vapic_reset; dc->vmsd = &vmstate_vapic; dc->realize = vapic_realize; - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ - dc->user_creatable = true; } static const TypeInfo vapic_type = { -- 2.11.0.259.g40922b1