All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Lance Richardson <lrichard@redhat.com>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH v4] sparse: add support for _Static_assert
Date: Thu, 4 May 2017 16:58:35 +0200	[thread overview]
Message-ID: <20170504145834.mef3psritw2lxf35@ltop.local> (raw)
In-Reply-To: <1089027793.4868687.1493906030607.JavaMail.zimbra@redhat.com>

On Thu, May 04, 2017 at 09:53:50AM -0400, Lance Richardson wrote:
> Thanks for the quick feedback, will incorporate in v5. 

I also saw a small issue, possibly related to the problem with
the mixup between 'declaration-list' and 'struct-declarator-list'
that you noticed. In the following code, the static assert is not
recognized:
	void foo(void)
	{
		int i = 0;
		for (_Static_assert(1, "ok"); 1; )
			;
		for (_Static_assert(0, "ko"); 1; )
			;
	}

It should because (since C99) the first part of the for-statement
is just a 'declaration', which include the static assert.
Not that it's very important, though.

Probably, it's best to leave it as is for the moment and just
add a new test case, annotated with 'check-known-to-fail'.

-- Luc

  reply	other threads:[~2017-05-04 14:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 16:55 [PATCH v4] sparse: add support for _Static_assert Lance Richardson
2017-05-03 23:54 ` Luc Van Oostenryck
2017-05-04  2:29   ` Luc Van Oostenryck
2017-05-04 13:53     ` Lance Richardson
2017-05-04 14:58       ` Luc Van Oostenryck [this message]
2017-05-04 15:46         ` Lance Richardson
2017-05-04 16:29           ` Luc Van Oostenryck
2017-05-04  3:03 ` Christopher Li
2017-05-04 13:56   ` Lance Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170504145834.mef3psritw2lxf35@ltop.local \
    --to=luc.vanoostenryck@gmail.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=lrichard@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.