From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Wajdeczko Subject: Re: [PATCH v2 2/3] drm/i915/guc: Make scratch register base and count flexible Date: Thu, 4 May 2017 18:26:04 +0200 Message-ID: <20170504162604.GB41764@mwajdecz-MOBL1.ger.corp.intel.com> References: <20170502123937.53556-1-michal.wajdeczko@intel.com> <20170504124813.47776-1-michal.wajdeczko@intel.com> <874lx0pxiw.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 45E3C6E16F for ; Thu, 4 May 2017 16:26:07 +0000 (UTC) Content-Disposition: inline In-Reply-To: <874lx0pxiw.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXkgMDQsIDIwMTcgYXQgMDQ6MjI6MTVQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVGh1LCAwNCBNYXkgMjAxNywgTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRl Y3prb0BpbnRlbC5jb20+IHdyb3RlOgo+ID4gV2UgYXJlIHVzaW5nIHNvbWUgc2NyYXRjaCByZWdp c3RlcnMgaW4gTU1JTyBiYXNlZCBzZW5kIGZ1bmN0aW9uLgo+ID4gTWFrZSB0aGVpciBiYXNlIGFu ZCBjb3VudCBmbGV4aWJsZSBpbiBwcmVwYXJhdGlvbiBvZiB1cGNvbWluZwo+ID4gR3VDIGZpcm13 YXJlL2hhcmR3YXJlIGNoYW5nZXMuIFdoaWxlIGFyb3VuZCwgY2hhbmdlIGNtZCBsZW4KPiA+IHBh cmFtZXRlciB2ZXJpZmljYXRpb24gZnJvbSBXQVJOX09OIHRvIEdFTV9CVUdfT04gYXMgd2UgZG9u J3QKPiA+IG5lZWQgdGhpcyBhbGwgdGhlIHRpbWUuCj4gCj4gSSdtIG5vdCBnZW5lcmFsbHkgZm9u ZCBvZiBjYWNoaW5nIHRoZSByZWdpc3RlcnMgbGlrZSB0aGlzIG9yIGFkZGluZwo+IF9NTUlPKCkg d3JhcHBpbmcgb3V0c2lkZSBvZiBpOTE1X3JlZy5oLiBTdXJlLCB3ZSBoYXZlIHNvbWUgb2YgdGhh dCBoZXJlCj4gYW5kIHRoZXJlLCBidXQgaGVyZSBpdCdzIGhhcmQgdG8gc2VlIHRoZSByYXRpb25h bGUgYmVjYXVzZSB5b3UgZG8gdGhpcwo+IGluIHByZXBhcmF0aW9uIGZvciBzb21ldGhpbmcgdGhh dCB3ZSB5b3UncmUgbm90IHNoYXJpbmcuCj4gCgpJIGNhbid0IHNoYXJlIGRldGFpbHMgYXRtLCBi dXQgYXMgY29tbWl0IG1lc3NhZ2Ugc2F5cywgdGhlcmUgd2lsbCBiZSBhCmNoYW5nZSBpbiBib3Ro IG9mZnNldHMgYW5kIG51bWJlciBvZiBzY3JhdGNoIHJlZ2lzdGVycy4KCkltaG8gYW55IHdyYXBw aW5nIGFyb3VuZCB0aGVzZSB2YWx1ZXMgY2FuJ3QgZ28gdG8gdGhlIGk5MTVfW2d1Y19dcmVnLmgg ZmlsZQphcyB0aGF0IGZpbGUgc2hhbGwgaW5jbHVkZSBvbmx5IHJhdyBNTUlPIGRlZmluaXRpb25z LCB3aXRob3V0IGFueSBleHRyYQpsb2dpYyB0aGF0IGlzIGJhc2VkIG9uIEdFTiBvciBQTEFURk9S TSBvciBGVyB2ZXJzaW9uLgoKQWx0ZXJuYXRlIGFwcHJvYWNoIHdvdWxkIGJlLCB0aGFua3MgdG8g dGhlIGFscmVhZHkgZGVmaW5lZCB2aXJ0dWFsIGZ1bmN0aW9uCnNlbmQoKSwgdG8gY3JlYXRlIG5l dyBzZW5kX21taW8gZnVuY3Rpb24ocykgdGhhdCB3aWxsIGJlIDEwMCUgdGhlIHNhbWUgYXMKdGhl IG9sZCBzZW5kX21taW8gZXhjZXB0IG9mZnNldCBhbmQgY291bnQgb2YgdGhlIHNjcmF0Y2ggcmVn aXN0ZXJzLgoKVGhlbiB3ZSBjYW4gYmVuZWZpdCBmcm9tIG1vc3Qgb3B0aW1hbCBpbXBsZW1lbnRh dGlvbiBwZXIgR0VOfFBMQVRGT1JNfEZXIHRoYXQKY2FuIHJ1biB3aXRob3V0IHJlYWRpbmcgY2Fj aGVkIHJlZ3Mgb2Zmc2V0cy9jb3VudCwgYnV0IGF0IHRoZSBjb3N0IG9mIGV4dHJhCmNvZGUgdGhh dCBuZWVkIHRvIGJlIG1haW50YWluZWQgdG8gYmUgaW4gc3luYyB3aXRoIHRoZSBvcmlnaW5hbCBm dW5jdGlvbi4KQW5kIHRoZW4gc29tZW9uZSBlbHNlIGNhbiBwb2ludCBvdXQgdGhhdCB3ZSBtaXNz ZWQgY29kZSBzaGFyaW5nIG9wcG9ydHVuaXR5LgoKSSdtIGFmcmFpZCB0aGVyZSBpcyBubyBjbGVh ciB3aW5uZXIuIAoKLU1pY2hhbAoKCj4gQlIsCj4gSmFuaS4KPiAKPiA+Cj4gPiB2MjogY2FsbCBv dXQgV0FSTi9HRU1fQlVHIGNoYW5nZSBpbiB0aGUgY29tbWl0IG1zZyAoRGFuaWVsZSkKPiA+Cj4g PiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWwgV2FqZGVjemtvIDxtaWNoYWwud2FqZGVjemtvQGludGVs LmNvbT4KPiA+IFN1Z2dlc3RlZC1ieTogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5j ZXJhb2xvc3B1cmlvQGludGVsLmNvbT4KPiA+IENjOiBEYW5pZWxlIENlcmFvbG8gU3B1cmlvIDxk YW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+ID4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8 am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiA+IFJldmlld2VkLWJ5OiBEYW5pZWxl IENlcmFvbG8gU3B1cmlvIDxkYW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+ID4gLS0t Cj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYyB8IDQxICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfdWMuaCB8ICA3ICsrKysrKysKPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDQxIGluc2VydGlvbnMo KyksIDcgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3VjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jCj4gPiBpbmRl eCA3MmY0OWU2Li45ZDExYzQyIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfdWMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+ID4g QEAgLTI2MCw5ICsyNjAsMzYgQEAgdm9pZCBpbnRlbF91Y19maW5pX2Z3KHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAJX19pbnRlbF91Y19md19maW5pKCZkZXZfcHJpdi0+ aHVjLmZ3KTsKPiA+ICB9Cj4gPiAgCj4gPiArc3RhdGljIGlubGluZSBpOTE1X3JlZ190IGd1Y19z ZW5kX3JlZyhzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsIHUzMiBpKQo+ID4gK3sKPiA+ICsJR0VNX0JV R19PTighZ3VjLT5zZW5kX3JlZ3MuYmFzZSk7Cj4gPiArCUdFTV9CVUdfT04oIWd1Yy0+c2VuZF9y ZWdzLmNvdW50KTsKPiA+ICsJR0VNX0JVR19PTihpID49IGd1Yy0+c2VuZF9yZWdzLmNvdW50KTsK PiA+ICsKPiA+ICsJcmV0dXJuIF9NTUlPKGd1Yy0+c2VuZF9yZWdzLmJhc2UgKyA0ICogaSk7Cj4g PiArfQo+ID4gKwo+ID4gK3N0YXRpYyB2b2lkIGd1Y19pbml0X3NlbmRfcmVncyhzdHJ1Y3QgaW50 ZWxfZ3VjICpndWMpCj4gPiArewo+ID4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYgPSBndWNfdG9faTkxNShndWMpOwo+ID4gKwllbnVtIGZvcmNld2FrZV9kb21haW5zIGZ3X2Rv bWFpbnMgPSAwOwo+ID4gKwl1MzIgaTsKPiA+ICsKPiA+ICsJZ3VjLT5zZW5kX3JlZ3MuYmFzZSA9 IGk5MTVfbW1pb19yZWdfb2Zmc2V0KFNPRlRfU0NSQVRDSCgwKSk7Cj4gPiArCWd1Yy0+c2VuZF9y ZWdzLmNvdW50ID0gU09GVF9TQ1JBVENIX0NPVU5UIC0gMTsKPiA+ICsKPiA+ICsJZm9yIChpID0g MDsgaSA8IGd1Yy0+c2VuZF9yZWdzLmNvdW50OyBpKyspIHsKPiA+ICsJCWZ3X2RvbWFpbnMgfD0g aW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9mb3JfcmVnKGRldl9wcml2LAo+ID4gKwkJCQkJZ3VjX3Nl bmRfcmVnKGd1YywgaSksCj4gPiArCQkJCQlGV19SRUdfUkVBRCB8IEZXX1JFR19XUklURSk7Cj4g PiArCX0KPiA+ICsJZ3VjLT5zZW5kX3JlZ3MuZndfZG9tYWlucyA9IGZ3X2RvbWFpbnM7Cj4gPiAr fQo+ID4gKwo+ID4gIHN0YXRpYyBpbnQgZ3VjX2VuYWJsZV9jb21tdW5pY2F0aW9uKHN0cnVjdCBp bnRlbF9ndWMgKmd1YykKPiA+ICB7Cj4gPiAgCS8qIFhYWDogcGxhY2Vob2xkZXIgZm9yIGFsdGVy bmF0ZSBzZXR1cCAqLwo+ID4gKwlndWNfaW5pdF9zZW5kX3JlZ3MoZ3VjKTsKPiA+ICAJZ3VjLT5z ZW5kID0gaW50ZWxfZ3VjX3NlbmRfbW1pbzsKPiA+ICAJcmV0dXJuIDA7Cj4gPiAgfQo+ID4gQEAg LTQwNywxOSArNDM0LDE5IEBAIGludCBpbnRlbF9ndWNfc2VuZF9tbWlvKHN0cnVjdCBpbnRlbF9n dWMgKmd1YywgY29uc3QgdTMyICphY3Rpb24sIHUzMiBsZW4pCj4gPiAgCWludCBpOwo+ID4gIAlp bnQgcmV0Owo+ID4gIAo+ID4gLQlpZiAoV0FSTl9PTihsZW4gPCAxIHx8IGxlbiA+IDE1KSkKPiA+ IC0JCXJldHVybiAtRUlOVkFMOwo+ID4gKwlHRU1fQlVHX09OKCFsZW4pOwo+ID4gKwlHRU1fQlVH X09OKGxlbiA+IGd1Yy0+c2VuZF9yZWdzLmNvdW50KTsKPiA+ICAKPiA+ICAJbXV0ZXhfbG9jaygm Z3VjLT5zZW5kX211dGV4KTsKPiA+IC0JaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9nZXQoZGV2X3By aXYsIEZPUkNFV0FLRV9CTElUVEVSKTsKPiA+ICsJaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9nZXQo ZGV2X3ByaXYsIGd1Yy0+c2VuZF9yZWdzLmZ3X2RvbWFpbnMpOwo+ID4gIAo+ID4gIAlkZXZfcHJp di0+Z3VjLmFjdGlvbl9jb3VudCArPSAxOwo+ID4gIAlkZXZfcHJpdi0+Z3VjLmFjdGlvbl9jbWQg PSBhY3Rpb25bMF07Cj4gPiAgCj4gPiAgCWZvciAoaSA9IDA7IGkgPCBsZW47IGkrKykKPiA+IC0J CUk5MTVfV1JJVEUoU09GVF9TQ1JBVENIKGkpLCBhY3Rpb25baV0pOwo+ID4gKwkJSTkxNV9XUklU RShndWNfc2VuZF9yZWcoZ3VjLCBpKSwgYWN0aW9uW2ldKTsKPiA+ICAKPiA+IC0JUE9TVElOR19S RUFEKFNPRlRfU0NSQVRDSChpIC0gMSkpOwo+ID4gKwlQT1NUSU5HX1JFQUQoZ3VjX3NlbmRfcmVn KGd1YywgaSAtIDEpKTsKPiA+ICAKPiA+ICAJaW50ZWxfZ3VjX25vdGlmeShndWMpOwo+ID4gIAo+ ID4gQEAgLTQyOCw3ICs0NTUsNyBAQCBpbnQgaW50ZWxfZ3VjX3NlbmRfbW1pbyhzdHJ1Y3QgaW50 ZWxfZ3VjICpndWMsIGNvbnN0IHUzMiAqYWN0aW9uLCB1MzIgbGVuKQo+ID4gIAkgKiBGYXN0IGNv bW1hbmRzIHNob3VsZCBzdGlsbCBjb21wbGV0ZSBpbiAxMHVzLgo+ID4gIAkgKi8KPiA+ICAJcmV0 ID0gX19pbnRlbF93YWl0X2Zvcl9yZWdpc3Rlcl9mdyhkZXZfcHJpdiwKPiA+IC0JCQkJCSAgIFNP RlRfU0NSQVRDSCgwKSwKPiA+ICsJCQkJCSAgIGd1Y19zZW5kX3JlZyhndWMsIDApLAo+ID4gIAkJ CQkJICAgSU5URUxfR1VDX1JFQ1ZfTUFTSywKPiA+ICAJCQkJCSAgIElOVEVMX0dVQ19SRUNWX01B U0ssCj4gPiAgCQkJCQkgICAxMCwgMTAsICZzdGF0dXMpOwo+ID4gQEAgLTQ1MCw3ICs0NzcsNyBA QCBpbnQgaW50ZWxfZ3VjX3NlbmRfbW1pbyhzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsIGNvbnN0IHUz MiAqYWN0aW9uLCB1MzIgbGVuKQo+ID4gIAl9Cj4gPiAgCWRldl9wcml2LT5ndWMuYWN0aW9uX3N0 YXR1cyA9IHN0YXR1czsKPiA+ICAKPiA+IC0JaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9wdXQoZGV2 X3ByaXYsIEZPUkNFV0FLRV9CTElUVEVSKTsKPiA+ICsJaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9w dXQoZGV2X3ByaXYsIGd1Yy0+c2VuZF9yZWdzLmZ3X2RvbWFpbnMpOwo+ID4gIAltdXRleF91bmxv Y2soJmd1Yy0+c2VuZF9tdXRleCk7Cj4gPiAgCj4gPiAgCXJldHVybiByZXQ7Cj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuaCBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3VjLmgKPiA+IGluZGV4IDA5NzI4OWIuLmEzN2E4Y2MgMTAwNjQ0Cj4gPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5oCj4gPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF91Yy5oCj4gPiBAQCAtMjA1LDYgKzIwNSwxMyBAQCBzdHJ1Y3QgaW50ZWxf Z3VjIHsKPiA+ICAJdWludDY0X3Qgc3VibWlzc2lvbnNbSTkxNV9OVU1fRU5HSU5FU107Cj4gPiAg CXVpbnQzMl90IGxhc3Rfc2Vxbm9bSTkxNV9OVU1fRU5HSU5FU107Cj4gPiAgCj4gPiArCS8qIEd1 QydzIEZXIHNwZWNpZmljIHJlZ2lzdGVycyB1c2VkIGluIE1NSU8gc2VuZCAqLwo+ID4gKwlzdHJ1 Y3Qgewo+ID4gKwkJdTMyIGJhc2U7Cj4gPiArCQl1MzIgY291bnQ7Cj4gPiArCQl1MzIgZndfZG9t YWluczsgLyogZW51bSBmb3JjZXdha2VfZG9tYWlucyAqLwo+ID4gKwl9IHNlbmRfcmVnczsKPiA+ ICsKPiA+ICAJLyogVG8gc2VyaWFsaXplIHRoZSBpbnRlbF9ndWNfc2VuZCBhY3Rpb25zICovCj4g PiAgCXN0cnVjdCBtdXRleCBzZW5kX211dGV4Owo+IAo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRl bCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK