From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932424AbdEDR4x (ORCPT ); Thu, 4 May 2017 13:56:53 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:36474 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932337AbdEDR4s (ORCPT ); Thu, 4 May 2017 13:56:48 -0400 Date: Thu, 4 May 2017 13:56:44 -0400 From: "Gabriel L. Somlo" To: Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Alexander Graf , "Michael S. Tsirkin" Subject: Re: [PATCH 0/4] KVM: x86: kvm_mwait_in_guest() cleanup and fixes Message-ID: <20170504175642.GH2246@HEDWIG.INI.CMU.EDU> References: <20170503193733.13409-1-rkrcmar@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170503193733.13409-1-rkrcmar@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Radim, On Wed, May 03, 2017 at 09:37:29PM +0200, Radim Krčmář wrote: > kvm_mwait_in_guest() was overcomplicated and also missed one AMD bug > that should prevent MWAIT pass through. > > This series ignores errata that don't have any Linux bug defined; > I know of two minor (not affecting the host) Core 2 errata: > AG36. Split Locked Stores May not Trigger the Monitoring Hardware > AG106. A REP STOS/MOVS to a MONITOR/MWAIT Address Range May Prevent > Triggering of the Monitoring Hardware > > None of them are really worthy of a new condition if Linux never hit > them ... we still have the OS X bug that Gabriel is hitting, but I'm ok > with the original approach that sacrificed it for "greater good". If I wanted to test this (e.g. with OS X 10.8 guests on several of my older Mac boxes running Fedora), which git repo would you have me use? (The series won't apply directly on top of git://git.kernel.org/pub/scm/virt/kvm/kvm.git). Thanks much, --Gabriel > Radim Krčmář (4): > KVM: svm: prevent MWAIT in guest with erratum 400 > KVM: x86: prevent MWAIT in guest with buggy MONITOR > KVM: x86: drop bogus MWAIT check > KVM: x86: simplify kvm_mwait_in_guest() > > arch/x86/kvm/x86.h | 33 +++------------------------------ > 1 file changed, 3 insertions(+), 30 deletions(-) > > -- > 2.12.2 >