From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbdEDUZP (ORCPT ); Thu, 4 May 2017 16:25:15 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:60145 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751281AbdEDUZO (ORCPT ); Thu, 4 May 2017 16:25:14 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Thu, 4 May 2017 21:25:03 +0100 From: Chris Wilson To: Laura Abbott Cc: Daniel Vetter , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sumit Semwal , intel-gfx@lists.freedesktop.org, Joonas Lahtinen Subject: Re: [PATCHv4 3/3] drm/vgem: Enable dmabuf import interfaces Message-ID: <20170504202503.GP24019@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Laura Abbott , Daniel Vetter , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sumit Semwal , intel-gfx@lists.freedesktop.org, Joonas Lahtinen References: <1493923548-20878-1-git-send-email-labbott@redhat.com> <1493923548-20878-4-git-send-email-labbott@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493923548-20878-4-git-send-email-labbott@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 04, 2017 at 11:45:48AM -0700, Laura Abbott wrote: > > Enable the GEM dma-buf import interfaces in addition to the export > interfaces. This lets vgem be used as a test source for other allocators > (e.g. Ion). > > Reviewed-by: Chris Wilson > Signed-off-by: Laura Abbott > --- > v4: Use new drm_gem_prime_import_dev function > --- > static const struct vm_operations_struct vgem_gem_vm_ops = { > @@ -114,12 +142,8 @@ static void vgem_postclose(struct drm_device *dev, struct drm_file *file) > kfree(vfile); > } > > -/* ioctls */ > - > -static struct drm_gem_object *vgem_gem_create(struct drm_device *dev, > - struct drm_file *file, > - unsigned int *handle, > - unsigned long size) > +static struct drm_vgem_gem_object *__vgem_gem_create(struct drm_device *dev, > + unsigned long size) I'm going to guess that doesn't line up anymore. If checkpatch isn't complaining, then sorry for the noise. > +static struct drm_gem_object *vgem_gem_create(struct drm_device *dev, > + struct drm_file *file, > + unsigned int *handle, > + unsigned long size) Ditto. Lgtm, so r-b still good. -Chris -- Chris Wilson, Intel Open Source Technology Centre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCHv4 3/3] drm/vgem: Enable dmabuf import interfaces Date: Thu, 4 May 2017 21:25:03 +0100 Message-ID: <20170504202503.GP24019@nuc-i3427.alporthouse.com> References: <1493923548-20878-1-git-send-email-labbott@redhat.com> <1493923548-20878-4-git-send-email-labbott@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1493923548-20878-4-git-send-email-labbott@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Laura Abbott Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sumit Semwal List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXkgMDQsIDIwMTcgYXQgMTE6NDU6NDhBTSAtMDcwMCwgTGF1cmEgQWJib3R0IHdy b3RlOgo+IAo+IEVuYWJsZSB0aGUgR0VNIGRtYS1idWYgaW1wb3J0IGludGVyZmFjZXMgaW4gYWRk aXRpb24gdG8gdGhlIGV4cG9ydAo+IGludGVyZmFjZXMuIFRoaXMgbGV0cyB2Z2VtIGJlIHVzZWQg YXMgYSB0ZXN0IHNvdXJjZSBmb3Igb3RoZXIgYWxsb2NhdG9ycwo+IChlLmcuIElvbikuCj4gCj4g UmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IFNp Z25lZC1vZmYtYnk6IExhdXJhIEFiYm90dCA8bGFiYm90dEByZWRoYXQuY29tPgo+IC0tLQo+IHY0 OiBVc2UgbmV3IGRybV9nZW1fcHJpbWVfaW1wb3J0X2RldiBmdW5jdGlvbgo+IC0tLQo+ICBzdGF0 aWMgY29uc3Qgc3RydWN0IHZtX29wZXJhdGlvbnNfc3RydWN0IHZnZW1fZ2VtX3ZtX29wcyA9IHsK PiBAQCAtMTE0LDEyICsxNDIsOCBAQCBzdGF0aWMgdm9pZCB2Z2VtX3Bvc3RjbG9zZShzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpCj4gIAlrZnJlZSh2ZmlsZSk7 Cj4gIH0KPiAgCj4gLS8qIGlvY3RscyAqLwo+IC0KPiAtc3RhdGljIHN0cnVjdCBkcm1fZ2VtX29i amVjdCAqdmdlbV9nZW1fY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gLQkJCQkJICAg ICAgc3RydWN0IGRybV9maWxlICpmaWxlLAo+IC0JCQkJCSAgICAgIHVuc2lnbmVkIGludCAqaGFu ZGxlLAo+IC0JCQkJCSAgICAgIHVuc2lnbmVkIGxvbmcgc2l6ZSkKPiArc3RhdGljIHN0cnVjdCBk cm1fdmdlbV9nZW1fb2JqZWN0ICpfX3ZnZW1fZ2VtX2NyZWF0ZShzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LAo+ICsJCQkJCQl1bnNpZ25lZCBsb25nIHNpemUpCgpJJ20gZ29pbmcgdG8gZ3Vlc3MgdGhh dCBkb2Vzbid0IGxpbmUgdXAgYW55bW9yZS4gSWYgY2hlY2twYXRjaCBpc24ndApjb21wbGFpbmlu ZywgdGhlbiBzb3JyeSBmb3IgdGhlIG5vaXNlLgoKPiArc3RhdGljIHN0cnVjdCBkcm1fZ2VtX29i amVjdCAqdmdlbV9nZW1fY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gKwkJCQkJICAg ICAgc3RydWN0IGRybV9maWxlICpmaWxlLAo+ICsJCQkJCSAgICAgIHVuc2lnbmVkIGludCAqaGFu ZGxlLAo+ICsJCQkJCSAgICAgIHVuc2lnbmVkIGxvbmcgc2l6ZSkKCkRpdHRvLgoKTGd0bSwgc28g ci1iIHN0aWxsIGdvb2QuCi1DaHJpcwoKLS0gCkNocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3Vy Y2UgVGVjaG5vbG9neSBDZW50cmUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==