All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maksim Salau <maksim.salau@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Juergen Stuber <starblue@users.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	legousb-devel@lists.sourceforge.net, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Alfredo Rafael Vicente Boix <alviboi@gmail.com>
Subject: Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack
Date: Thu, 4 May 2017 22:11:23 +0300	[thread overview]
Message-ID: <20170504221101.094c5061@h01rn72.ncal.norcal.wdc.com> (raw)
In-Reply-To: <20170504123623.GB26032@kuha.fi.intel.com>

> > @@ -913,6 +929,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device  
> 
> Don't you need to free get_version_reply here?
> 
> >  	return retval;
> >  
> >  error:
> > +	kfree(get_version_reply);
> >  	tower_delete(dev);
> >  	return retval;
> >  }  

Thank you very much, Heikki!

I was so focused on failure cases, that missed memory leak in the case
 when all calls succeeded.

I'll prepare a patch shortly to fix this.

Regards,
Maksim.

  reply	other threads:[~2017-05-04 19:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAE+v5Of10hZOEC8zyhVgszWmBaFzcMjqCGdLSDJEKjWwt9F+sg@mail.gmail.com>
2017-04-22 16:24 ` [PATCH v2] usb: misc: legousbtower: Fix buffers on stack Maksim Salau
2017-04-25 18:04   ` Greg Kroah-Hartman
2017-04-25 19:28     ` Maksim Salau
2017-04-25 19:49       ` [PATCH v3] " Maksim Salau
2017-04-26  9:29         ` Greg Kroah-Hartman
2017-04-27  6:30           ` Maksim Salau
2017-05-04 12:36         ` Heikki Krogerus
2017-05-04 19:11           ` Maksim Salau [this message]
2017-04-26  9:28       ` [PATCH v2] " Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170504221101.094c5061@h01rn72.ncal.norcal.wdc.com \
    --to=maksim.salau@gmail.com \
    --cc=alviboi@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=legousb-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=starblue@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.