Re: [Qemu-devel] [PATCH v2 1/7] dmg: Introduce a new struct to cache random access points

From: Stefan Hajnoczi <stefanha@gmail.com>
To: Ashijeet Acharya <ashijeetacharya@gmail.com>
Cc: kwolf@redhat.com, jsnow@redhat.com, mreitz@redhat.com,
	famz@redhat.com, peter@lekensteyn.nl, qemu-devel@nongnu.org,
	qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/7] dmg: Introduce a new struct to cache random access points
Date: Fri, 5 May 2017 14:12:56 +0100	[thread overview]
Message-ID: <20170505131256.GF11350@stefanha-x1.localdomain> (raw)
In-Reply-To: <1493280397-9622-2-git-send-email-ashijeetacharya@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

On Thu, Apr 27, 2017 at 01:36:31PM +0530, Ashijeet Acharya wrote:
> @@ -51,6 +60,7 @@ typedef struct BDRVDMGState {
>      uint8_t *compressed_chunk;
>      uint8_t *uncompressed_chunk;
>      z_stream zstream;
> +    DMGReadState *drs;

This doesn't need to be a pointer.  The object is allocated in
.bdrv_open() and freed in .bdrv_close().  It's simpler to drop the heap
allocation and simply inline the struct:

    DMGReadState drs;

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]