From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom Rini <trini@konsulko.com>
Date: Fri, 5 May 2017 14:14:33 -0400
Subject: [U-Boot] board/BuR/common: incorrect check of dtb
In-Reply-To: <20170505201154.01b8aaed@crub>
References: <20170503214411.14270-1-xypron.glpk@gmx.de>
 <20170505163806.GU12511@bill-the-cat>
 <20170505201154.01b8aaed@crub>
Message-ID: <20170505181433.GV12511@bill-the-cat>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, May 05, 2017 at 08:11:54PM +0200, Anatolij Gustschin wrote:
> On Fri, 5 May 2017 12:38:06 -0400
> Tom Rini trini at konsulko.com wrote:
> ...
> > >  	char *dtbname = getenv("dtb");
> > >  	char *dtbdev = getenv("dtbdev");
> > >  	char *dtppart = getenv("dtbpart");
> > > -	if (!dtbdev || !dtbdev || !dtbname) {
> > > +	if (!dtbdev || !dtbpart || !dtbname) {
> > >  		printf("%s: <dtbdev>/<dtbpart>/<dtb> missing.\n", __func__);
> > >  		return -1;
> > >  	}  
> > 
> > This breaks some boards such as brppt1_mmc, which I agree doesn't make a
> > lot of sense with just the above context, can you please test building
> > 'BuR' via buildman?  Thanks!
> 
> dtbpart is wrong here, the defined variable is dtppart.

Ah-ha!  Time to clean off the laptop screen...

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170505/d9525728/attachment.sig>