From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Fri, 5 May 2017 20:11:54 +0200 Subject: [U-Boot] board/BuR/common: incorrect check of dtb In-Reply-To: <20170505163806.GU12511@bill-the-cat> References: <20170503214411.14270-1-xypron.glpk@gmx.de> <20170505163806.GU12511@bill-the-cat> Message-ID: <20170505201154.01b8aaed@crub> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, 5 May 2017 12:38:06 -0400 Tom Rini trini at konsulko.com wrote: ... > > char *dtbname = getenv("dtb"); > > char *dtbdev = getenv("dtbdev"); > > char *dtppart = getenv("dtbpart"); > > - if (!dtbdev || !dtbdev || !dtbname) { > > + if (!dtbdev || !dtbpart || !dtbname) { > > printf("%s: // missing.\n", __func__); > > return -1; > > } > > This breaks some boards such as brppt1_mmc, which I agree doesn't make a > lot of sense with just the above context, can you please test building > 'BuR' via buildman? Thanks! dtbpart is wrong here, the defined variable is dtppart. -- Anatolij