From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753459AbdEHBg4 (ORCPT ); Sun, 7 May 2017 21:36:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53886 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171AbdEHBgz (ORCPT ); Sun, 7 May 2017 21:36:55 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 379963DBD7 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=bhe@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 379963DBD7 Date: Mon, 8 May 2017 09:36:49 +0800 From: Baoquan He To: Bhupesh Sharma , Borislav Petkov , Matt Fleming Cc: linux-kernel@vger.kernel.org, Dave Young , Ard Biesheuvel , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Thomas Garnier , Kees Cook , x86@kernel.org, linux-efi@vger.kernel.org, Alex Thorlton , Russ Anderson , Dimitri Sivanich , Mike Travis Subject: Re: [PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled Message-ID: <20170508013649.GA2315@x1> References: <1493294823-9315-1-git-send-email-bhe@redhat.com> <20170505204214.GB5225@codeblueprint.co.uk> <20170505233620.eka5md5mmnp4ituz@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 08 May 2017 01:36:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for explaining, Bhupesh. BIOS issue of SGI uv1 is still not fixed. There's a quirk for uv1 to use efi old map: void __init efi_apply_memmap_quirks(void) { ... ... /* UV2+ BIOS has a fix for this issue. UV1 still needs the quirk. */ if (dmi_check_system(sgi_uv1_dmi)) set_bit(EFI_OLD_MEMMAP, &efi.flags); } And because of some reasons, redhat also need efi old_map now. Hi Matt, This v2 patch works on my kvm guest, however there's still problem on SGI system. I will post v3 later after it's handled. So nack this v2 patch. Thanks Baoquan On 05/08/17 at 12:07am, Bhupesh Sharma wrote: > On Sat, May 6, 2017 at 5:06 AM, Borislav Petkov wrote: > > On Fri, May 05, 2017 at 09:42:14PM +0100, Matt Fleming wrote: > >> (Including the folks from SGI since this was hit on a UV system) > > > > Wasn't there a BIOS fix supplied at some point which obviated the need > > to boot with efi=old_map on SGI boxes? > > > > AFAICR, the bios fixes were provided only for SGI boxes with BIOS > version greater than or equal to UV2 (so upstream with recent bios > works on UV2, UV3, and UV4 hardware platforms, both with old and new > mapping, with new mapping being the default), however the UV1 > platforms still use efi=old_map > > Also as mentioned above since commit > caef78b6cdeddf4ad364f95910bba6b43b8eb9bf fixed the efi=old_map support > on UV systems even with new bios, they should ideally all boot up > properly in upstream both with 'nokaslr' and without 'nokaslr' in the > bootargs when efi=old_map is used. > > Regards, > Bhupesh From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baoquan He Subject: Re: [PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled Date: Mon, 8 May 2017 09:36:49 +0800 Message-ID: <20170508013649.GA2315@x1> References: <1493294823-9315-1-git-send-email-bhe@redhat.com> <20170505204214.GB5225@codeblueprint.co.uk> <20170505233620.eka5md5mmnp4ituz@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bhupesh Sharma , Borislav Petkov , Matt Fleming Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dave Young , Ard Biesheuvel , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Thomas Garnier , Kees Cook , x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alex Thorlton , Russ Anderson , Dimitri Sivanich , Mike Travis List-Id: linux-efi@vger.kernel.org Thanks for explaining, Bhupesh. BIOS issue of SGI uv1 is still not fixed. There's a quirk for uv1 to use efi old map: void __init efi_apply_memmap_quirks(void) { ... ... /* UV2+ BIOS has a fix for this issue. UV1 still needs the quirk. */ if (dmi_check_system(sgi_uv1_dmi)) set_bit(EFI_OLD_MEMMAP, &efi.flags); } And because of some reasons, redhat also need efi old_map now. Hi Matt, This v2 patch works on my kvm guest, however there's still problem on SGI system. I will post v3 later after it's handled. So nack this v2 patch. Thanks Baoquan On 05/08/17 at 12:07am, Bhupesh Sharma wrote: > On Sat, May 6, 2017 at 5:06 AM, Borislav Petkov wrote: > > On Fri, May 05, 2017 at 09:42:14PM +0100, Matt Fleming wrote: > >> (Including the folks from SGI since this was hit on a UV system) > > > > Wasn't there a BIOS fix supplied at some point which obviated the need > > to boot with efi=old_map on SGI boxes? > > > > AFAICR, the bios fixes were provided only for SGI boxes with BIOS > version greater than or equal to UV2 (so upstream with recent bios > works on UV2, UV3, and UV4 hardware platforms, both with old and new > mapping, with new mapping being the default), however the UV1 > platforms still use efi=old_map > > Also as mentioned above since commit > caef78b6cdeddf4ad364f95910bba6b43b8eb9bf fixed the efi=old_map support > on UV systems even with new bios, they should ideally all boot up > properly in upstream both with 'nokaslr' and without 'nokaslr' in the > bootargs when efi=old_map is used. > > Regards, > Bhupesh