From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754175AbdEHKfs (ORCPT ); Mon, 8 May 2017 06:35:48 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34403 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752788AbdEHKfr (ORCPT ); Mon, 8 May 2017 06:35:47 -0400 Date: Mon, 8 May 2017 11:35:42 +0100 From: Rui Miguel Silva To: karthik@techveda.org Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: greybus: Prefer kcalloc over kzalloc Message-ID: <20170508103542.GA1089@arch-late.localdomain> References: <1494080050-20236-1-git-send-email-karthik@techveda.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1494080050-20236-1-git-send-email-karthik@techveda.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Karthik, Thanks for the patch. On Sat, May 06, 2017 at 07:44:10PM +0530, karthik@techveda.org wrote: >From: Karthik Tummala > >Fixed following checkpatch.pl warning: > * WARNING: Prefer kcalloc over kzalloc with multiply > >Instead of specifying no.of bytes * size as arugment >in kzalloc, prefer kcalloc. > >Signed-off-by: Karthik Tummala Can you send a v2 with a subject similar to the other commits in the file. i.e, starting with staging: greybus: light: ... And you have a typo in the change log s/arugment/argument/. If this two are fixed, you can add my: Reviewed-by: Rui Miguel Silva Cheers, Rui >--- > drivers/staging/greybus/light.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c >index 1681362..861a249 100644 >--- a/drivers/staging/greybus/light.c >+++ b/drivers/staging/greybus/light.c >@@ -1030,7 +1030,7 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id) > light->channels_count = conf.channel_count; > light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL); > >- light->channels = kzalloc(light->channels_count * >+ light->channels = kcalloc(light->channels_count, > sizeof(struct gb_channel), GFP_KERNEL); > if (!light->channels) > return -ENOMEM; >@@ -1167,7 +1167,7 @@ static int gb_lights_create_all(struct gb_lights *glights) > if (ret < 0) > goto out; > >- glights->lights = kzalloc(glights->lights_count * >+ glights->lights = kcalloc(glights->lights_count, > sizeof(struct gb_light), GFP_KERNEL); > if (!glights->lights) { > ret = -ENOMEM; >-- >1.9.1 >