Re: [PATCH v3 9/9] mm: Make sure pages are scrubbed

From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: tim@xen.org, sstabellini@kernel.org, wei.liu2@citrix.com,
	George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
	ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v3 9/9] mm: Make sure pages are scrubbed
Date: Mon, 8 May 2017 11:48:42 -0400	[thread overview]
Message-ID: <20170508154842.GW13896@char.us.oracle.com> (raw)
In-Reply-To: <590CB0F202000078001574A0@prv-mh.provo.novell.com>

On Fri, May 05, 2017 at 09:05:54AM -0600, Jan Beulich wrote:
> >>> On 14.04.17 at 17:37, <boris.ostrovsky@oracle.com> wrote:
> > --- a/xen/Kconfig.debug
> > +++ b/xen/Kconfig.debug
> > @@ -114,6 +114,13 @@ config DEVICE_TREE_DEBUG
> >  	  logged in the Xen ring buffer.
> >  	  If unsure, say N here.
> >  
> > +config SCRUB_DEBUG
> > +    bool "Page scrubbing test"
> > +    default DEBUG
> > +    ---help---
> > +      Verify that pages that need to be scrubbed before being allocated to
> > +      a guest are indeed scrubbed.
> 
> Indentation.
> 
> > --- a/xen/common/page_alloc.c
> > +++ b/xen/common/page_alloc.c
> > @@ -694,6 +694,31 @@ static void page_list_add_scrub(struct page_info *pg, 
> > unsigned int node,
> >          page_list_add(pg, &heap(node, zone, order));
> >  }
> >  
> > +#define SCRUB_BYTE_PATTERN 0xc2c2c2c2c2c2c2c2
> 
> This likely needs a ULL suffix at least for the ARM32 build.

See 3ac7ca1

So 0xe7f000f0 for ARM32 and AARCH64_BREAK_FAULT for ARM64.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel