From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751832AbdEHQRR (ORCPT <rfc822;w@1wt.eu>);
        Mon, 8 May 2017 12:17:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58917 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750876AbdEHQRP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 May 2017 12:17:15 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C1A537AE84
Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=acme@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C1A537AE84
Date: Mon, 8 May 2017 13:17:11 -0300
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Milian Wolff <milian.wolff@kdab.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        David Ahern <dsahern@gmail.com>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Yao Jin <yao.jin@linux.intel.com>
Subject: Re: [PATCH v2] perf report: distinguish between inliners in the same
 function
Message-ID: <20170508161711.GL2222@redhat.com>
References: <20170503213536.13905-1-milian.wolff@kdab.com>
 <11256670.HWKrRQARBr@agathebauer>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <11256670.HWKrRQARBr@agathebauer>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.20 (2009-12-10)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 08 May 2017 16:17:15 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Mon, May 08, 2017 at 10:45:18AM +0200, Milian Wolff escreveu:
> On Mittwoch, 3. Mai 2017 23:35:36 CEST Milian Wolff wrote:
> > When different functions get inlined into the same function, we
> > want to show them individually in the reports. But when we group by
> > function, we would aggregate all IPs and would only keep the first
> > one in that function. E.g. for C++ code like the following:

<SNIP>

> Ping? Any chance that I could get a review on this one please? It works really 
> well for me and greatly improves perf's usability for C++ code bases.

yeah, indeed that would be great to have someone reviewing this,

- Arnaldo