From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754284AbdEIFdB (ORCPT ); Tue, 9 May 2017 01:33:01 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:33512 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909AbdEIFc6 (ORCPT ); Tue, 9 May 2017 01:32:58 -0400 Date: Tue, 9 May 2017 11:02:55 +0530 From: Viresh Kumar To: karthik@techveda.org Cc: rmfrfs@gmail.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, sunil.m@techveda.org, linux-kernel@vger.kernel.org Subject: Re: [greybus-dev] [PATCH v2] Staging: greybus: light: Prefer kcalloc over kzalloc Message-ID: <20170509053255.GA17481@vireshk-i7> References: <20170508103542.GA1089@arch-late.localdomain> <1494246955-14245-1-git-send-email-karthik@techveda.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494246955-14245-1-git-send-email-karthik@techveda.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08-05-17, 18:05, karthik@techveda.org wrote: > From: Karthik Tummala > > Fixed following checkpatch.pl warning: > * WARNING: Prefer kcalloc over kzalloc with multiply > > Instead of specifying no.of bytes * size as argument > in kzalloc, prefer kcalloc. > > Signed-off-by: Karthik Tummala > Reviewed-by: Rui Miguel Silva > --- > Changes for v2: > - Changed subject line & fixed typo as suggested by > Rui Miguel Silva > --- > drivers/staging/greybus/light.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c > index 1681362..861a249 100644 > --- a/drivers/staging/greybus/light.c > +++ b/drivers/staging/greybus/light.c > @@ -1030,7 +1030,7 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id) > light->channels_count = conf.channel_count; > light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL); > > - light->channels = kzalloc(light->channels_count * > + light->channels = kcalloc(light->channels_count, > sizeof(struct gb_channel), GFP_KERNEL); > if (!light->channels) > return -ENOMEM; > @@ -1167,7 +1167,7 @@ static int gb_lights_create_all(struct gb_lights *glights) > if (ret < 0) > goto out; > > - glights->lights = kzalloc(glights->lights_count * > + glights->lights = kcalloc(glights->lights_count, > sizeof(struct gb_light), GFP_KERNEL); > if (!glights->lights) { > ret = -ENOMEM; Acked-by: Viresh Kumar -- viresh