From: Christoph Hellwig <hch@lst.de>
To: davem@davemloft.net
Cc: ubraun@linux.vnet.ibm.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH] net/smc: mark as BROKEN due to remote memory exposure
Date: Wed, 10 May 2017 09:26:27 +0200 [thread overview]
Message-ID: <20170510072627.12060-1-hch@lst.de> (raw)
The driver has a lot of quality issues due to the lack of RDMA-side
review, and explicitly bypasses APIs to register all memory once a
connection is made, and thus allows remote access to memoery.
Mark it as broken until at least that part is fixed.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Cc: stable@vger.kernel.org
---
net/smc/Kconfig | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/net/smc/Kconfig b/net/smc/Kconfig
index c717ef0896aa..fe6b78bc515f 100644
--- a/net/smc/Kconfig
+++ b/net/smc/Kconfig
@@ -1,6 +1,6 @@
config SMC
tristate "SMC socket protocol family"
- depends on INET && INFINIBAND
+ depends on INET && INFINIBAND && BROKEN
---help---
SMC-R provides a "sockets over RDMA" solution making use of
RDMA over Converged Ethernet (RoCE) technology to upgrade
@@ -8,6 +8,10 @@ config SMC
The Linux implementation of the SMC-R solution is designed as
a separate socket family SMC.
+ Warning: SMC will expose all memory for remote reads and writes
+ once a connection is established. Don't enable this option except
+ for tightly controlled lab environment.
+
Select this option if you want to run SMC socket applications
config SMC_DIAG
--
2.11.0
next reply other threads:[~2017-05-10 7:26 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 7:26 Christoph Hellwig [this message]
2017-05-11 14:57 ` [PATCH] net/smc: mark as BROKEN due to remote memory exposure Bart Van Assche
[not found] ` <1494514662.2489.1.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-14 5:58 ` Christoph Hellwig
2017-05-14 5:58 ` Christoph Hellwig
2017-05-14 5:58 ` Christoph Hellwig
2017-05-14 15:51 ` David Miller
2017-05-14 19:08 ` Bart Van Assche
2017-05-15 0:44 ` David Miller
[not found] ` <20170514.204404.1844909849561204299.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2017-05-15 1:58 ` Parav Pandit
2017-05-15 1:58 ` Parav Pandit
2017-05-16 15:57 ` Doug Ledford
2017-05-16 15:57 ` Doug Ledford
2017-05-16 16:29 ` David Miller
2017-05-16 16:29 ` David Miller
[not found] ` <20170516.122923.869994491617365845.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2017-05-16 16:30 ` Christoph Hellwig
2017-05-16 16:30 ` Christoph Hellwig
[not found] ` <20170516163041.GA5132-jcswGhMUV9g@public.gmane.org>
2017-05-16 16:33 ` David Miller
2017-05-16 16:33 ` David Miller
2017-05-16 16:35 ` Christoph Hellwig
2017-05-16 16:36 ` Doug Ledford
2017-05-16 16:36 ` Doug Ledford
2017-05-16 16:41 ` David Miller
2017-05-16 16:41 ` David Miller
2017-05-16 17:12 ` Doug Ledford
2017-05-16 16:42 ` Doug Ledford
2017-05-16 16:49 ` David Miller
2017-05-16 16:49 ` David Miller
[not found] ` <20170516.124945.386235742645153398.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2017-05-16 17:20 ` Doug Ledford
2017-05-16 17:20 ` Doug Ledford
[not found] ` <1494955244.3259.130.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-05-16 17:36 ` David Miller
2017-05-16 17:36 ` David Miller
[not found] ` <20170516.133644.850927380166261577.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2017-05-16 18:03 ` Doug Ledford
2017-05-16 18:03 ` Doug Ledford
2017-05-16 18:52 ` David Miller
2017-05-16 18:52 ` David Miller
[not found] ` <20170516.145249.871010194359061722.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2017-05-16 19:28 ` Doug Ledford
2017-05-16 19:28 ` Doug Ledford
2017-05-17 20:37 ` Doug Ledford
2017-05-17 22:37 ` Parav Pandit
[not found] ` <VI1PR0502MB3008604A216B388A440A8B53D1E70-o1MPJYiShExKsLr+rGaxW8DSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-05-18 0:07 ` Doug Ledford
2017-05-18 0:07 ` Doug Ledford
2017-05-18 4:22 ` Leon Romanovsky
[not found] ` <20170514.115116.499149210596634881.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2017-05-15 6:41 ` Sagi Grimberg
2017-05-15 6:41 ` Sagi Grimberg
2017-05-15 7:18 ` Leon Romanovsky
2017-05-15 7:18 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170510072627.12060-1-hch@lst.de \
--to=hch@lst.de \
--cc=davem@davemloft.net \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=ubraun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.