From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753114AbdEJOsQ (ORCPT ); Wed, 10 May 2017 10:48:16 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:53483 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752882AbdEJOsP (ORCPT ); Wed, 10 May 2017 10:48:15 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Wed, 10 May 2017 15:48:07 +0100 From: Chris Wilson To: Laura Abbott Cc: Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/prime: include device.h Message-ID: <20170510144807.GJ7978@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Laura Abbott , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org References: <20170510081508.ornstbloztolsvf7@phenom.ffwll.local> <1494427201-14365-1-git-send-email-labbott@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494427201-14365-1-git-send-email-labbott@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 10, 2017 at 07:40:01AM -0700, Laura Abbott wrote: > Explictly add linux/device.h to ensure struct device is defined: > > In file included from include/drm/drm_file.h:38:0, > from drivers/gpu/drm/drm_file.c:38: > include/drm/drm_prime.h:71:14: warning: 'struct device' declared inside > parameter list will not be visible outside of this definition or > declaration > struct device *attach_dev); We aren't using it for anything other than an opaque pointer, so a struct device; forward decl will suffice? -Chris -- Chris Wilson, Intel Open Source Technology Centre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/prime: include device.h Date: Wed, 10 May 2017 15:48:07 +0100 Message-ID: <20170510144807.GJ7978@nuc-i3427.alporthouse.com> References: <20170510081508.ornstbloztolsvf7@phenom.ffwll.local> <1494427201-14365-1-git-send-email-labbott@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1494427201-14365-1-git-send-email-labbott@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Laura Abbott Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXkgMTAsIDIwMTcgYXQgMDc6NDA6MDFBTSAtMDcwMCwgTGF1cmEgQWJib3R0IHdy b3RlOgo+IEV4cGxpY3RseSBhZGQgbGludXgvZGV2aWNlLmggdG8gZW5zdXJlIHN0cnVjdCBkZXZp Y2UgaXMgZGVmaW5lZDoKPiAKPiBJbiBmaWxlIGluY2x1ZGVkIGZyb20gaW5jbHVkZS9kcm0vZHJt X2ZpbGUuaDozODowLAo+ICAgICAgICAgICAgICAgICAgZnJvbSBkcml2ZXJzL2dwdS9kcm0vZHJt X2ZpbGUuYzozODoKPiBpbmNsdWRlL2RybS9kcm1fcHJpbWUuaDo3MToxNDogd2FybmluZzogJ3N0 cnVjdCBkZXZpY2UnIGRlY2xhcmVkIGluc2lkZQo+IAkgIHBhcmFtZXRlciBsaXN0IHdpbGwgbm90 IGJlIHZpc2libGUgb3V0c2lkZSBvZiB0aGlzIGRlZmluaXRpb24gb3IKPiAJICBkZWNsYXJhdGlv bgo+ICAgICAgICAgICBzdHJ1Y3QgZGV2aWNlICphdHRhY2hfZGV2KTsKCldlIGFyZW4ndCB1c2lu ZyBpdCBmb3IgYW55dGhpbmcgb3RoZXIgdGhhbiBhbiBvcGFxdWUgcG9pbnRlciwgc28gYQpzdHJ1 Y3QgZGV2aWNlOwpmb3J3YXJkIGRlY2wgd2lsbCBzdWZmaWNlPwotQ2hyaXMKCi0tIApDaHJpcyBX aWxzb24sIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudHJlCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=