From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753761AbdEJR4Q (ORCPT ); Wed, 10 May 2017 13:56:16 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34581 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752978AbdEJR4P (ORCPT ); Wed, 10 May 2017 13:56:15 -0400 Date: Wed, 10 May 2017 19:55:56 +0200 From: Daniel Vetter To: Archit Taneja Cc: Jose Abreu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Carlos Palminha , Alexey Brodkin , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Daniel Vetter , Dave Airlie , Andrzej Hajda Subject: Re: [PATCH v2 7/8] drm: Use mode_valid() in atomic modeset Message-ID: <20170510175556.wxdrgjzdxosdnbx2@phenom.ffwll.local> Mail-Followup-To: Archit Taneja , Jose Abreu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Carlos Palminha , Alexey Brodkin , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Dave Airlie , Andrzej Hajda References: <61cee0404343a363c459a377d2ff53f5c13b1230.1494347165.git.joabreu@synopsys.com> <089951fb-2d89-b874-1e48-5ffbf3a4288d@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <089951fb-2d89-b874-1e48-5ffbf3a4288d@codeaurora.org> X-Operating-System: Linux phenom 4.9.0-2-amd64 User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 10, 2017 at 09:38:00PM +0530, Archit Taneja wrote: > > > On 5/9/2017 10:30 PM, Jose Abreu wrote: > > This patches makes use of the new mode_valid() callbacks introduced > > previously to validate the full video pipeline when modesetting. > > > > This calls the connector->mode_valid(), encoder->mode_valid(), > > bridge->mode_valid() and crtc->mode_valid() so that we can > > make sure that the mode will be accepted in every components. > > > > Signed-off-by: Jose Abreu > > Cc: Carlos Palminha > > Cc: Alexey Brodkin > > Cc: Ville Syrjälä > > Cc: Daniel Vetter > > Cc: Dave Airlie > > Cc: Andrzej Hajda > > Cc: Archit Taneja > > --- > > > > Changes v1->v2: > > - Removed call to connector->mode_valid (Ville, Daniel) > > - Change function name (Ville) > > - Use for_each_new_connector_in_state (Ville) > > - Do not validate if connector and mode didn't change (Ville) > > - Use new helpers to call mode_valid > > > > drivers/gpu/drm/drm_atomic_helper.c | 75 +++++++++++++++++++++++++++++++++++-- > > 1 file changed, 72 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > > index 8be9719..19d0ea1 100644 > > --- a/drivers/gpu/drm/drm_atomic_helper.c > > +++ b/drivers/gpu/drm/drm_atomic_helper.c > > @@ -452,6 +452,69 @@ static int handle_conflicting_encoders(struct drm_atomic_state *state, > > return 0; > > } > > +static enum drm_mode_status mode_valid_path(struct drm_connector *connector, > > + struct drm_encoder *encoder, > > + struct drm_crtc *crtc, > > + struct drm_display_mode *mode) > > +{ > > + enum drm_mode_status ret; > > + > > + ret = drm_encoder_mode_valid(encoder, mode); > > + if (ret != MODE_OK) { > > + DRM_DEBUG_ATOMIC("[ENCODER:%d:%s] mode_valid() failed\n", > > + encoder->base.id, encoder->name); > > + return ret; > > + } > > + > > + ret = drm_bridge_mode_valid(encoder->bridge, mode); > > + if (ret != MODE_OK) { > > + DRM_DEBUG_ATOMIC("[BRIDGE] mode_valid() failed\n"); > > + return ret; > > + } > > + > > + ret = drm_crtc_mode_valid(crtc, mode); > > + if (ret != MODE_OK) { > > + DRM_DEBUG_ATOMIC("[CRTC:%d:%s] mode_valid() failed\n", > > + crtc->base.id, crtc->name); > > + return ret; > > + } > > + > > + return ret; > > +} > > + > > +static int > > +mode_valid(struct drm_atomic_state *state) > > +{ > > + struct drm_connector_state *conn_state; > > + struct drm_connector *connector; > > + int i; > > + > > + for_each_new_connector_in_state(state, connector, conn_state, i) { > > + struct drm_encoder *encoder = conn_state->best_encoder; > > + struct drm_crtc *crtc = conn_state->crtc; > > + struct drm_crtc_state *crtc_state; > > + enum drm_mode_status mode_status; > > + struct drm_display_mode *mode; > > + > > + if (!crtc || !encoder) > > + continue; > > + > > + crtc_state = drm_atomic_get_new_crtc_state(state, crtc); > > + if (!crtc_state) > > + continue; > > + if (!crtc_state->mode_changed && !crtc_state->connectors_changed) > > + continue; > > + > > + mode = &crtc_state->mode; > > + > > + mode_status = mode_valid_path(connector, encoder, crtc, mode); > > + if (mode_status != MODE_OK) > > + return -EINVAL; > > + } > > + > > + return 0; > > +} > > + > > /** > > * drm_atomic_helper_check_modeset - validate state object for modeset changes > > * @dev: DRM device > > @@ -466,13 +529,15 @@ static int handle_conflicting_encoders(struct drm_atomic_state *state, > > * 2. &drm_connector_helper_funcs.atomic_check to validate the connector state. > > * 3. If it's determined a modeset is needed then all connectors on the affected crtc > > * crtc are added and &drm_connector_helper_funcs.atomic_check is run on them. > > - * 4. &drm_bridge_funcs.mode_fixup is called on all encoder bridges. > > - * 5. &drm_encoder_helper_funcs.atomic_check is called to validate any encoder state. > > + * 4. &drm_encoder_helper_funcs.mode_valid, &drm_bridge_funcs.mode_valid and > > + * &drm_crtc_helper_funcs.mode_valid are called on the affected components. > > + * 5. &drm_bridge_funcs.mode_fixup is called on all encoder bridges. > > + * 6. &drm_encoder_helper_funcs.atomic_check is called to validate any encoder state. > > * This function is only called when the encoder will be part of a configured crtc, > > * it must not be used for implementing connector property validation. > > * If this function is NULL, &drm_atomic_encoder_helper_funcs.mode_fixup is called > > * instead. > > - * 6. &drm_crtc_helper_funcs.mode_fixup is called last, to fix up the mode with crtc constraints. > > + * 7. &drm_crtc_helper_funcs.mode_fixup is called last, to fix up the mode with crtc constraints. > > * > > * &drm_crtc_state.mode_changed is set when the input mode is changed. > > * &drm_crtc_state.connectors_changed is set when a connector is added or > > @@ -617,6 +682,10 @@ static int handle_conflicting_encoders(struct drm_atomic_state *state, > > return ret; > > } > > + ret = mode_valid(state); > > + if (ret) > > + return ret; > > + > > Since we've ensured that the modes won't fail, can mode_fixup() and > the mode_fixup() ops for crtc/bridge/encoders be assured to not fail > too? This is assuming that all drivers have moved to using the new > mode_valid() ops correctly. The entire point of re-checking is that userspace can create its own modes and submit them to the kernel, bypassing the current connector->mode_valid() check. I think almost all drivers get this wrong unfortunately :( -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 7/8] drm: Use mode_valid() in atomic modeset Date: Wed, 10 May 2017 19:55:56 +0200 Message-ID: <20170510175556.wxdrgjzdxosdnbx2@phenom.ffwll.local> References: <61cee0404343a363c459a377d2ff53f5c13b1230.1494347165.git.joabreu@synopsys.com> <089951fb-2d89-b874-1e48-5ffbf3a4288d@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 368266E3B4 for ; Wed, 10 May 2017 17:56:15 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id y10so1455460wmh.0 for ; Wed, 10 May 2017 10:56:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <089951fb-2d89-b874-1e48-5ffbf3a4288d@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja Cc: Jose Abreu , Daniel Vetter , Alexey Brodkin , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Carlos Palminha List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXkgMTAsIDIwMTcgYXQgMDk6Mzg6MDBQTSArMDUzMCwgQXJjaGl0IFRhbmVqYSB3 cm90ZToKPiAKPiAKPiBPbiA1LzkvMjAxNyAxMDozMCBQTSwgSm9zZSBBYnJldSB3cm90ZToKPiA+ IFRoaXMgcGF0Y2hlcyBtYWtlcyB1c2Ugb2YgdGhlIG5ldyBtb2RlX3ZhbGlkKCkgY2FsbGJhY2tz IGludHJvZHVjZWQKPiA+IHByZXZpb3VzbHkgdG8gdmFsaWRhdGUgdGhlIGZ1bGwgdmlkZW8gcGlw ZWxpbmUgd2hlbiBtb2Rlc2V0dGluZy4KPiA+IAo+ID4gVGhpcyBjYWxscyB0aGUgY29ubmVjdG9y LT5tb2RlX3ZhbGlkKCksIGVuY29kZXItPm1vZGVfdmFsaWQoKSwKPiA+IGJyaWRnZS0+bW9kZV92 YWxpZCgpIGFuZCBjcnRjLT5tb2RlX3ZhbGlkKCkgc28gdGhhdCB3ZSBjYW4KPiA+IG1ha2Ugc3Vy ZSB0aGF0IHRoZSBtb2RlIHdpbGwgYmUgYWNjZXB0ZWQgaW4gZXZlcnkgY29tcG9uZW50cy4KPiA+ IAo+ID4gU2lnbmVkLW9mZi1ieTogSm9zZSBBYnJldSA8am9hYnJldUBzeW5vcHN5cy5jb20+Cj4g PiBDYzogQ2FybG9zIFBhbG1pbmhhIDxwYWxtaW5oYUBzeW5vcHN5cy5jb20+Cj4gPiBDYzogQWxl eGV5IEJyb2RraW4gPGFicm9ka2luQHN5bm9wc3lzLmNvbT4KPiA+IENjOiBWaWxsZSBTeXJqw6Rs w6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gQ2M6IERhbmllbCBWZXR0ZXIg PGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gPiBDYzogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAbGlu dXguaWU+Cj4gPiBDYzogQW5kcnplaiBIYWpkYSA8YS5oYWpkYUBzYW1zdW5nLmNvbT4KPiA+IENj OiBBcmNoaXQgVGFuZWphIDxhcmNoaXR0QGNvZGVhdXJvcmEub3JnPgo+ID4gLS0tCj4gPiAKPiA+ IENoYW5nZXMgdjEtPnYyOgo+ID4gCS0gUmVtb3ZlZCBjYWxsIHRvIGNvbm5lY3Rvci0+bW9kZV92 YWxpZCAoVmlsbGUsIERhbmllbCkKPiA+IAktIENoYW5nZSBmdW5jdGlvbiBuYW1lIChWaWxsZSkK PiA+IAktIFVzZSBmb3JfZWFjaF9uZXdfY29ubmVjdG9yX2luX3N0YXRlIChWaWxsZSkKPiA+IAkt IERvIG5vdCB2YWxpZGF0ZSBpZiBjb25uZWN0b3IgYW5kIG1vZGUgZGlkbid0IGNoYW5nZSAoVmls bGUpCj4gPiAJLSBVc2UgbmV3IGhlbHBlcnMgdG8gY2FsbCBtb2RlX3ZhbGlkCj4gPiAKPiA+ICAg ZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgfCA3NSArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0tCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCA3MiBpbnNlcnRpb25z KCspLCAzIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2RybV9hdG9taWNfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIu Ywo+ID4gaW5kZXggOGJlOTcxOS4uMTlkMGVhMSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pY19oZWxwZXIuYwo+ID4gQEAgLTQ1Miw2ICs0NTIsNjkgQEAgc3RhdGljIGludCBoYW5kbGVf Y29uZmxpY3RpbmdfZW5jb2RlcnMoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ID4g ICAJcmV0dXJuIDA7Cj4gPiAgIH0KPiA+ICtzdGF0aWMgZW51bSBkcm1fbW9kZV9zdGF0dXMgbW9k ZV92YWxpZF9wYXRoKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gPiArCQkJCQkg ICAgc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyLAo+ID4gKwkJCQkJICAgIHN0cnVjdCBkcm1f Y3J0YyAqY3J0YywKPiA+ICsJCQkJCSAgICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSkK PiA+ICt7Cj4gPiArCWVudW0gZHJtX21vZGVfc3RhdHVzIHJldDsKPiA+ICsKPiA+ICsJcmV0ID0g ZHJtX2VuY29kZXJfbW9kZV92YWxpZChlbmNvZGVyLCBtb2RlKTsKPiA+ICsJaWYgKHJldCAhPSBN T0RFX09LKSB7Cj4gPiArCQlEUk1fREVCVUdfQVRPTUlDKCJbRU5DT0RFUjolZDolc10gbW9kZV92 YWxpZCgpIGZhaWxlZFxuIiwKPiA+ICsJCQkJZW5jb2Rlci0+YmFzZS5pZCwgZW5jb2Rlci0+bmFt ZSk7Cj4gPiArCQlyZXR1cm4gcmV0Owo+ID4gKwl9Cj4gPiArCj4gPiArCXJldCA9IGRybV9icmlk Z2VfbW9kZV92YWxpZChlbmNvZGVyLT5icmlkZ2UsIG1vZGUpOwo+ID4gKwlpZiAocmV0ICE9IE1P REVfT0spIHsKPiA+ICsJCURSTV9ERUJVR19BVE9NSUMoIltCUklER0VdIG1vZGVfdmFsaWQoKSBm YWlsZWRcbiIpOwo+ID4gKwkJcmV0dXJuIHJldDsKPiA+ICsJfQo+ID4gKwo+ID4gKwlyZXQgPSBk cm1fY3J0Y19tb2RlX3ZhbGlkKGNydGMsIG1vZGUpOwo+ID4gKwlpZiAocmV0ICE9IE1PREVfT0sp IHsKPiA+ICsJCURSTV9ERUJVR19BVE9NSUMoIltDUlRDOiVkOiVzXSBtb2RlX3ZhbGlkKCkgZmFp bGVkXG4iLAo+ID4gKwkJCQljcnRjLT5iYXNlLmlkLCBjcnRjLT5uYW1lKTsKPiA+ICsJCXJldHVy biByZXQ7Cj4gPiArCX0KPiA+ICsKPiA+ICsJcmV0dXJuIHJldDsKPiA+ICt9Cj4gPiArCj4gPiAr c3RhdGljIGludAo+ID4gK21vZGVfdmFsaWQoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRl KQo+ID4gK3sKPiA+ICsJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGU7Cj4g PiArCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3I7Cj4gPiArCWludCBpOwo+ID4gKwo+ ID4gKwlmb3JfZWFjaF9uZXdfY29ubmVjdG9yX2luX3N0YXRlKHN0YXRlLCBjb25uZWN0b3IsIGNv bm5fc3RhdGUsIGkpIHsKPiA+ICsJCXN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciA9IGNvbm5f c3RhdGUtPmJlc3RfZW5jb2RlcjsKPiA+ICsJCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9IGNvbm5f c3RhdGUtPmNydGM7Cj4gPiArCQlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4g PiArCQllbnVtIGRybV9tb2RlX3N0YXR1cyBtb2RlX3N0YXR1czsKPiA+ICsJCXN0cnVjdCBkcm1f ZGlzcGxheV9tb2RlICptb2RlOwo+ID4gKwo+ID4gKwkJaWYgKCFjcnRjIHx8ICFlbmNvZGVyKQo+ ID4gKwkJCWNvbnRpbnVlOwo+ID4gKwo+ID4gKwkJY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0 X25ld19jcnRjX3N0YXRlKHN0YXRlLCBjcnRjKTsKPiA+ICsJCWlmICghY3J0Y19zdGF0ZSkKPiA+ ICsJCQljb250aW51ZTsKPiA+ICsJCWlmICghY3J0Y19zdGF0ZS0+bW9kZV9jaGFuZ2VkICYmICFj cnRjX3N0YXRlLT5jb25uZWN0b3JzX2NoYW5nZWQpCj4gPiArCQkJY29udGludWU7Cj4gPiArCj4g PiArCQltb2RlID0gJmNydGNfc3RhdGUtPm1vZGU7Cj4gPiArCj4gPiArCQltb2RlX3N0YXR1cyA9 IG1vZGVfdmFsaWRfcGF0aChjb25uZWN0b3IsIGVuY29kZXIsIGNydGMsIG1vZGUpOwo+ID4gKwkJ aWYgKG1vZGVfc3RhdHVzICE9IE1PREVfT0spCj4gPiArCQkJcmV0dXJuIC1FSU5WQUw7Cj4gPiAr CX0KPiA+ICsKPiA+ICsJcmV0dXJuIDA7Cj4gPiArfQo+ID4gKwo+ID4gICAvKioKPiA+ICAgICog ZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfbW9kZXNldCAtIHZhbGlkYXRlIHN0YXRlIG9iamVjdCBm b3IgbW9kZXNldCBjaGFuZ2VzCj4gPiAgICAqIEBkZXY6IERSTSBkZXZpY2UKPiA+IEBAIC00NjYs MTMgKzUyOSwxNSBAQCBzdGF0aWMgaW50IGhhbmRsZV9jb25mbGljdGluZ19lbmNvZGVycyhzdHJ1 Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gPiAgICAqIDIuICZkcm1fY29ubmVjdG9yX2hl bHBlcl9mdW5jcy5hdG9taWNfY2hlY2sgdG8gdmFsaWRhdGUgdGhlIGNvbm5lY3RvciBzdGF0ZS4K PiA+ICAgICogMy4gSWYgaXQncyBkZXRlcm1pbmVkIGEgbW9kZXNldCBpcyBuZWVkZWQgdGhlbiBh bGwgY29ubmVjdG9ycyBvbiB0aGUgYWZmZWN0ZWQgY3J0Ywo+ID4gICAgKiAgICBjcnRjIGFyZSBh ZGRlZCBhbmQgJmRybV9jb25uZWN0b3JfaGVscGVyX2Z1bmNzLmF0b21pY19jaGVjayBpcyBydW4g b24gdGhlbS4KPiA+IC0gKiA0LiAmZHJtX2JyaWRnZV9mdW5jcy5tb2RlX2ZpeHVwIGlzIGNhbGxl ZCBvbiBhbGwgZW5jb2RlciBicmlkZ2VzLgo+ID4gLSAqIDUuICZkcm1fZW5jb2Rlcl9oZWxwZXJf ZnVuY3MuYXRvbWljX2NoZWNrIGlzIGNhbGxlZCB0byB2YWxpZGF0ZSBhbnkgZW5jb2RlciBzdGF0 ZS4KPiA+ICsgKiA0LiAmZHJtX2VuY29kZXJfaGVscGVyX2Z1bmNzLm1vZGVfdmFsaWQsICZkcm1f YnJpZGdlX2Z1bmNzLm1vZGVfdmFsaWQgYW5kCj4gPiArICogICAgJmRybV9jcnRjX2hlbHBlcl9m dW5jcy5tb2RlX3ZhbGlkIGFyZSBjYWxsZWQgb24gdGhlIGFmZmVjdGVkIGNvbXBvbmVudHMuCj4g PiArICogNS4gJmRybV9icmlkZ2VfZnVuY3MubW9kZV9maXh1cCBpcyBjYWxsZWQgb24gYWxsIGVu Y29kZXIgYnJpZGdlcy4KPiA+ICsgKiA2LiAmZHJtX2VuY29kZXJfaGVscGVyX2Z1bmNzLmF0b21p Y19jaGVjayBpcyBjYWxsZWQgdG8gdmFsaWRhdGUgYW55IGVuY29kZXIgc3RhdGUuCj4gPiAgICAq ICAgIFRoaXMgZnVuY3Rpb24gaXMgb25seSBjYWxsZWQgd2hlbiB0aGUgZW5jb2RlciB3aWxsIGJl IHBhcnQgb2YgYSBjb25maWd1cmVkIGNydGMsCj4gPiAgICAqICAgIGl0IG11c3Qgbm90IGJlIHVz ZWQgZm9yIGltcGxlbWVudGluZyBjb25uZWN0b3IgcHJvcGVydHkgdmFsaWRhdGlvbi4KPiA+ICAg ICogICAgSWYgdGhpcyBmdW5jdGlvbiBpcyBOVUxMLCAmZHJtX2F0b21pY19lbmNvZGVyX2hlbHBl cl9mdW5jcy5tb2RlX2ZpeHVwIGlzIGNhbGxlZAo+ID4gICAgKiAgICBpbnN0ZWFkLgo+ID4gLSAq IDYuICZkcm1fY3J0Y19oZWxwZXJfZnVuY3MubW9kZV9maXh1cCBpcyBjYWxsZWQgbGFzdCwgdG8g Zml4IHVwIHRoZSBtb2RlIHdpdGggY3J0YyBjb25zdHJhaW50cy4KPiA+ICsgKiA3LiAmZHJtX2Ny dGNfaGVscGVyX2Z1bmNzLm1vZGVfZml4dXAgaXMgY2FsbGVkIGxhc3QsIHRvIGZpeCB1cCB0aGUg bW9kZSB3aXRoIGNydGMgY29uc3RyYWludHMuCj4gPiAgICAqCj4gPiAgICAqICZkcm1fY3J0Y19z dGF0ZS5tb2RlX2NoYW5nZWQgaXMgc2V0IHdoZW4gdGhlIGlucHV0IG1vZGUgaXMgY2hhbmdlZC4K PiA+ICAgICogJmRybV9jcnRjX3N0YXRlLmNvbm5lY3RvcnNfY2hhbmdlZCBpcyBzZXQgd2hlbiBh IGNvbm5lY3RvciBpcyBhZGRlZCBvcgo+ID4gQEAgLTYxNyw2ICs2ODIsMTAgQEAgc3RhdGljIGlu dCBoYW5kbGVfY29uZmxpY3RpbmdfZW5jb2RlcnMoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0 YXRlLAo+ID4gICAJCQlyZXR1cm4gcmV0Owo+ID4gICAJfQo+ID4gKwlyZXQgPSBtb2RlX3ZhbGlk KHN0YXRlKTsKPiA+ICsJaWYgKHJldCkKPiA+ICsJCXJldHVybiByZXQ7Cj4gPiArCj4gCj4gU2lu Y2Ugd2UndmUgZW5zdXJlZCB0aGF0IHRoZSBtb2RlcyB3b24ndCBmYWlsLCBjYW4gbW9kZV9maXh1 cCgpIGFuZAo+IHRoZSBtb2RlX2ZpeHVwKCkgb3BzIGZvciBjcnRjL2JyaWRnZS9lbmNvZGVycyBi ZSBhc3N1cmVkIHRvIG5vdCBmYWlsCj4gdG9vPyBUaGlzIGlzIGFzc3VtaW5nIHRoYXQgYWxsIGRy aXZlcnMgaGF2ZSBtb3ZlZCB0byB1c2luZyB0aGUgbmV3Cj4gbW9kZV92YWxpZCgpIG9wcyBjb3Jy ZWN0bHkuCgpUaGUgZW50aXJlIHBvaW50IG9mIHJlLWNoZWNraW5nIGlzIHRoYXQgdXNlcnNwYWNl IGNhbiBjcmVhdGUgaXRzIG93biBtb2RlcwphbmQgc3VibWl0IHRoZW0gdG8gdGhlIGtlcm5lbCwg YnlwYXNzaW5nIHRoZSBjdXJyZW50CmNvbm5lY3Rvci0+bW9kZV92YWxpZCgpIGNoZWNrLiBJIHRo aW5rIGFsbW9zdCBhbGwgZHJpdmVycyBnZXQgdGhpcyB3cm9uZwp1bmZvcnR1bmF0ZWx5IDooCi1E YW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0 aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=