From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754123AbdEJT32 (ORCPT ); Wed, 10 May 2017 15:29:28 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:17019 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752853AbdEJT30 (ORCPT ); Wed, 10 May 2017 15:29:26 -0400 Date: Wed, 10 May 2017 22:28:57 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: linux-s390@vger.kernel.org, Heiko Carstens , Jan =?iso-8859-1?Q?H=F6ppner?= , Martin Schwidefsky , Stefan Haberland , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/3] s390/dasd: Adjust buffer output in dasd_hosts_print() Message-ID: <20170510192857.o5cyi4xx2xdo66d7@mwanda> References: <4af00744-1c8a-6b33-22c8-d26d569f6c5f@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 10, 2017 at 08:01:17PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 10 May 2017 18:52:28 +0200 > > * Use a special format string specification for the desired output of the > array "pgid" into a sequence. > > This issue was detected by using the Coccinelle software. > > * Delete the local variable "j" and a call of the function "seq_puts" > wich became unnecessary with this refactoring. > > Fixes: 5a3b7b112884f80ff19b18028fabeb4f9c035518 ("s390/dasd: add query host access to volume support") Stop using the fixes tag when you are not fixing bugs. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 10 May 2017 19:28:57 +0000 Subject: Re: [PATCH 1/3] s390/dasd: Adjust buffer output in dasd_hosts_print() Message-Id: <20170510192857.o5cyi4xx2xdo66d7@mwanda> List-Id: References: <4af00744-1c8a-6b33-22c8-d26d569f6c5f@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-s390@vger.kernel.org, Heiko Carstens , Jan =?iso-8859-1?Q?H=F6ppner?= , Martin Schwidefsky , Stefan Haberland , LKML , kernel-janitors@vger.kernel.org On Wed, May 10, 2017 at 08:01:17PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 10 May 2017 18:52:28 +0200 > > * Use a special format string specification for the desired output of the > array "pgid" into a sequence. > > This issue was detected by using the Coccinelle software. > > * Delete the local variable "j" and a call of the function "seq_puts" > wich became unnecessary with this refactoring. > > Fixes: 5a3b7b112884f80ff19b18028fabeb4f9c035518 ("s390/dasd: add query host access to volume support") Stop using the fixes tag when you are not fixing bugs. regards, dan carpenter