From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0054421A16E57 for ; Thu, 11 May 2017 00:59:27 -0700 (PDT) Date: Thu, 11 May 2017 09:59:26 +0200 From: Christoph Hellwig Subject: Re: [PATCH 03/16] uuid: rename uuid types Message-ID: <20170511075926.GC19837@lst.de> References: <20170510180214.16852-1-hch@lst.de> <20170510180214.16852-4-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Amir Goldstein Cc: linux-xfs , linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, Mimi Zohar , linux-kernel , Steven Whitehouse , David Howells , linux-fsdevel , Andy Shevchenko , Shaohua Li , Christoph Hellwig List-ID: On Wed, May 10, 2017 at 10:15:51PM +0300, Amir Goldstein wrote: > > +static inline int uuid_cmp(const uuid_t u1, const uuid_t u2) > > { > > - return memcmp(&u1, &u2, sizeof(uuid_be)); > > + return memcmp(&u1, &u2, sizeof(uuid_t)); > > } > > > > > I think we should use this opportunity to change these to (uuid_t *, uuid_t *) > which is more in line with the rest of the helpers including the new helpers > hoisted from xfs. Or just kill them off - uuid/guid_equals is the better interface for all existing users as far as I can tell. My updated series already kills off the be/uuid one, the le/guid one will need a bit more work, though. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 03/16] uuid: rename uuid types Date: Thu, 11 May 2017 09:59:26 +0200 Message-ID: <20170511075926.GC19837@lst.de> References: <20170510180214.16852-1-hch@lst.de> <20170510180214.16852-4-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Amir Goldstein Cc: linux-xfs , linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Mimi Zohar , linux-kernel , Steven Whitehouse , David Howells , linux-fsdevel , Andy Shevchenko , Shaohua Li , Christoph Hellwig List-Id: linux-raid.ids On Wed, May 10, 2017 at 10:15:51PM +0300, Amir Goldstein wrote: > > +static inline int uuid_cmp(const uuid_t u1, const uuid_t u2) > > { > > - return memcmp(&u1, &u2, sizeof(uuid_be)); > > + return memcmp(&u1, &u2, sizeof(uuid_t)); > > } > > > > > I think we should use this opportunity to change these to (uuid_t *, uuid_t *) > which is more in line with the rest of the helpers including the new helpers > hoisted from xfs. Or just kill them off - uuid/guid_equals is the better interface for all existing users as far as I can tell. My updated series already kills off the be/uuid one, the le/guid one will need a bit more work, though. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755308AbdEKH7a (ORCPT ); Thu, 11 May 2017 03:59:30 -0400 Received: from verein.lst.de ([213.95.11.211]:53562 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755279AbdEKH72 (ORCPT ); Thu, 11 May 2017 03:59:28 -0400 Date: Thu, 11 May 2017 09:59:26 +0200 From: Christoph Hellwig To: Amir Goldstein Cc: Christoph Hellwig , Andy Shevchenko , linux-fsdevel , Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs , linux-raid@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel Subject: Re: [PATCH 03/16] uuid: rename uuid types Message-ID: <20170511075926.GC19837@lst.de> References: <20170510180214.16852-1-hch@lst.de> <20170510180214.16852-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 10, 2017 at 10:15:51PM +0300, Amir Goldstein wrote: > > +static inline int uuid_cmp(const uuid_t u1, const uuid_t u2) > > { > > - return memcmp(&u1, &u2, sizeof(uuid_be)); > > + return memcmp(&u1, &u2, sizeof(uuid_t)); > > } > > > > > I think we should use this opportunity to change these to (uuid_t *, uuid_t *) > which is more in line with the rest of the helpers including the new helpers > hoisted from xfs. Or just kill them off - uuid/guid_equals is the better interface for all existing users as far as I can tell. My updated series already kills off the be/uuid one, the le/guid one will need a bit more work, though. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 11 May 2017 09:59:26 +0200 From: Christoph Hellwig To: Amir Goldstein Cc: Christoph Hellwig , Andy Shevchenko , linux-fsdevel , Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs , linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel Subject: Re: [PATCH 03/16] uuid: rename uuid types Message-ID: <20170511075926.GC19837@lst.de> References: <20170510180214.16852-1-hch@lst.de> <20170510180214.16852-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wed, May 10, 2017 at 10:15:51PM +0300, Amir Goldstein wrote: > > +static inline int uuid_cmp(const uuid_t u1, const uuid_t u2) > > { > > - return memcmp(&u1, &u2, sizeof(uuid_be)); > > + return memcmp(&u1, &u2, sizeof(uuid_t)); > > } > > > > > I think we should use this opportunity to change these to (uuid_t *, uuid_t *) > which is more in line with the rest of the helpers including the new helpers > hoisted from xfs. Or just kill them off - uuid/guid_equals is the better interface for all existing users as far as I can tell. My updated series already kills off the be/uuid one, the le/guid one will need a bit more work, though.