From: Kevin Wolf <kwolf@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-block@nongnu.org, eblake@redhat.com, qemu-devel@nongnu.org,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] qemu-img: Check for backing image if specified during create
Date: Thu, 11 May 2017 11:37:39 +0200 [thread overview]
Message-ID: <20170511093739.GB4235@noname.str.redhat.com> (raw)
In-Reply-To: <20170509180946.17046-1-jsnow@redhat.com>
Am 09.05.2017 um 20:09 hat John Snow geschrieben:
> Or, rather, force the open of a backing image if one was specified
> for creation. Using a similar -unsafe option as rebase, allow qemu-img
> to ignore the backing file validation if possible.
>
> It may not always be possible, as in the existing case when a filesize
> for the new image was not specified.
>
> This is accomplished by shifting around the conditionals in
> bdrv_img_create, such that a backing file is always opened unless we
> provide BDRV_O_NO_BACKING. qemu-img is adjusted to pass this new flag
> when -u is provided to create.
>
> Sorry for the heinous looking diffstat, but it's mostly whitespace.
>
> Inspired by: https://bugzilla.redhat.com/show_bug.cgi?id=1213786
>
> Signed-off-by: John Snow <jsnow@redhat.com>
The idea makes sense to me, but the patch needs a rebase.
Kevin
next prev parent reply other threads:[~2017-05-11 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 18:09 [Qemu-devel] [PATCH v2] qemu-img: Check for backing image if specified during create John Snow
2017-05-09 18:17 ` Eric Blake
2017-05-09 18:19 ` Eric Blake
2017-05-09 18:21 ` John Snow
2017-05-11 9:37 ` Kevin Wolf [this message]
2017-05-11 14:51 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511093739.GB4235@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.